From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 0D8433858C53 for ; Thu, 3 Nov 2022 18:01:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0D8433858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.96,134,1665475200"; d="scan'208";a="88911311" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 03 Nov 2022 10:01:15 -0800 IronPort-SDR: 3zw//ixeT+KEpSRDL8ELgvekp57pRsVkoLt2tHZf0fqCK7iSwDaW9vTdHub4mXMvg5Rv8VEiZY nrwftccXtAZYJ35gq5ILd71TbigvCtPmwGtHVVyAhx/IvWonpXUec5rXTZQEcsS6qBmgBdpe4H fYrl4gjsOm7UzSNlvrH4VRTCrZtLRE0lhBfAyNwumnKzpFkiVc873G9tFPmVJj0B+xJcJwvmAO +LBpec2kPQPzIYv9CQ4AOKH+Q0Z2UcOY5Jjvk48g3nraH7R4AYDT2h3WmOySGCV098KdX2SAbY CvY= Message-ID: Date: Thu, 3 Nov 2022 18:01:08 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] amdgcn: Fix instruction generation for exp2 and log2 operations To: Kwok Cheung Yeung , gcc-patches References: Content-Language: en-GB From: Andrew Stubbs In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03/11/2022 17:47, Kwok Cheung Yeung wrote: > Hello > > This patch fixes a bug introduced in a previous patch adding support for > generating native instructions for the exp2 and log2 patterns. The > problem is that the name of the instruction implementing the exp2 > operation is v_exp (and not v_exp2), and similarly log2 is implemented > by v_log, so we cannot use the RTL name of the operation when outputting > the instruction. > > I've added an extra iterator for the GCN operation name and used that > when outputting instructions instead. I have also added an extra > testcase for GCN that exercises this case. > > Okay for trunk? OK. Andrew