Re: [PATCH] Test for sigsetjmp support in analyzer tests requiring that feature.

[Tobias Burnus <tobias@codesourcery.com>]

Interestingly, only those two testcases use the effective-target check:
gcc.dg/analyzer/sigsetjmp-5.c, gcc.dg/analyzer/sigsetjmp-6.c

Regarding the link test: No header file is included – it just
defines the function ("extern char $funcname();") and calls it.
The check fails as "sigsetjmp" does not exist in glibc –
the symbol is "__sigsetjmp" in glibc.

If one includes '#include <setjmp.h>', it works – even without
explicitly setting _POSIX_C_SOURCE.

BTW: sigsetjmp is also used by the following testcase, but without the
effective-target check:
g++.dg/asan/asan_test.cc, g++.dg/torture/pr57190.C, gcc.dg/pr69167.c,
gcc.dg/torture/float128-exact-underflow.c,
gcc.dg/torture/float128-extendxf-underflow.c,
gcc.dg/torture/pr57147-3.c, gcc.dg/torture/pr81900.c,
gcc.dg/ubsan/pr94423.c, gcc.target/sh/torture/pr30807.c

Cheers,

Tobias

On 4/2/20 11:36 AM, Thomas Schwinge wrote:

> Hi!
>
> On 2020-03-22T11:31:31-0600, Sandra Loosemore <sandra@codesourcery.com> wrote:
>> The new-ish analyzer test cases sigsetjmp-5.c and sigsetjmp-6.c were
>> failing on nios2-elf and probably other newlib targets due to lack of
>> support for sigsetjmp.  I didn't see a suitable existing
>> effective-target test for this, so I added one.
>> --- a/gcc/testsuite/gcc.dg/analyzer/sigsetjmp-5.c
>> +++ b/gcc/testsuite/gcc.dg/analyzer/sigsetjmp-5.c
>> @@ -1,3 +1,5 @@
>> +/* { dg-require-effective-target sigsetjmp } */
>> --- a/gcc/testsuite/gcc.dg/analyzer/sigsetjmp-6.c
>> +++ b/gcc/testsuite/gcc.dg/analyzer/sigsetjmp-6.c
>> @@ -1,3 +1,5 @@
>> +/* { dg-require-effective-target sigsetjmp } */
>> --- a/gcc/testsuite/lib/target-supports.exp
>> +++ b/gcc/testsuite/lib/target-supports.exp
>> +# Returns 1 if "sigsetjmp" is available on the target system.
>> +
>> +proc check_effective_target_sigsetjmp {} {
>> +    return [check_function_available "sigsetjmp"]
>> +}
> That got pushed to master branch as commit
> adaf4b6c66e789d927684003b9ee05ed04c105ea "Test for sigsetjmp support in
> analyzer tests requiring that feature".
>
> On x86_64-pc-linux-gnu I now see these tests regress to:
>
>      UNSUPPORTED: gcc.dg/analyzer/sigsetjmp-5.c
>      UNSUPPORTED: gcc.dg/analyzer/sigsetjmp-6.c
>
> ..., because of:
>
>      Executing on host: [xgcc] sigsetjmp_available6728.c [...] -fno-builtin  -lm    -o sigsetjmp_available6728.exe    (timeout = 300)
>      spawn [xgcc] sigsetjmp_available6728.c [...] -fno-builtin -lm -o sigsetjmp_available6728.exe
>      /tmp/ccKsf87z.o: In function `main':
>      sigsetjmp_available6728.c:(.text+0xa): undefined reference to `sigsetjmp'
>      collect2: error: ld returned 1 exit status
>      [...]
>
> Does that maybe have something to do with feature test macros required
> for 'sigsetjmp'?
>
>
> Grüße
>   Thomas
> -----------------
> Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
> Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter