public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Hashtable: Add missing std qualification on a forward call
@ 2020-02-11 18:16 François Dumont
  2020-02-12  7:48 ` Jonathan Wakely
  0 siblings, 1 reply; 2+ messages in thread
From: François Dumont @ 2020-02-11 18:16 UTC (permalink / raw)
  To: libstdc++, gcc-patches

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

I just notice that in a recent patch I forgot a std:: on a call to forward.

* include/bits/hashtable.h (_Hashtable<>(_Hashtable&&, 
std::allocator_type&)):
     Add missing std namespace qualification to forward call.

Ok to commit ?

François


[-- Attachment #2: hashtable.patch --]
[-- Type: text/x-patch, Size: 545 bytes --]

diff --git a/libstdc++-v3/include/bits/hashtable.h b/libstdc++-v3/include/bits/hashtable.h
index 9e721aad8cc..b00319a668b 100644
--- a/libstdc++-v3/include/bits/hashtable.h
+++ b/libstdc++-v3/include/bits/hashtable.h
@@ -1371,7 +1371,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
 	  using _Fwd_Ht = typename
 	    conditional<__move_if_noexcept_cond<value_type>::value,
 			const _Hashtable&, _Hashtable&&>::type;
-	  _M_assign(forward<_Fwd_Ht>(__ht), __alloc_gen);
+	  _M_assign(std::forward<_Fwd_Ht>(__ht), __alloc_gen);
 	  __ht.clear();
 	}
     }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Hashtable: Add missing std qualification on a forward call
  2020-02-11 18:16 [PATCH] Hashtable: Add missing std qualification on a forward call François Dumont
@ 2020-02-12  7:48 ` Jonathan Wakely
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Wakely @ 2020-02-12  7:48 UTC (permalink / raw)
  To: François Dumont; +Cc: libstdc++, gcc-patches

On 11/02/20 19:15 +0100, François Dumont wrote:
>I just notice that in a recent patch I forgot a std:: on a call to forward.
>
>* include/bits/hashtable.h (_Hashtable<>(_Hashtable&&, 
>std::allocator_type&)):
>    Add missing std namespace qualification to forward call.
>
>Ok to commit ?

Yes please - thanks.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-12  7:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 18:16 [PATCH] Hashtable: Add missing std qualification on a forward call François Dumont
2020-02-12  7:48 ` Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).