public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Aldy Hernandez <aldyh@redhat.com>
Cc: GCC patches <gcc-patches@gcc.gnu.org>,
	Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [PATCH] Add debug counters to back threader.
Date: Mon, 1 Nov 2021 07:02:27 -0600	[thread overview]
Message-ID: <c6ce5313-d209-d7cd-5b4b-91db46f73ff1@gmail.com> (raw)
In-Reply-To: <20211101095443.727405-1-aldyh@redhat.com>



On 11/1/2021 3:54 AM, Aldy Hernandez wrote:
> Chasing down stage3 miscomparisons is never fun, and having no way to
> distinguish between jump threads registered by a particular
> pass, is even harder.  This patch adds debug counters for the individual
> back threading passes.  I've left the ethread pass alone, as that one is
> usually benign, but we could easily add it if needed.
>
> The fact that we can only pass one boolean argument to the passes
> infrastructure has us do all sorts of gymnastics to differentiate
> between the various back threading passes.
>
> Tested on x86-64 Linux.
>
> OK?
>
> gcc/ChangeLog:
>
> 	* dbgcnt.def: Add debug counter for back_thread[12] and
> 	back_threadfull[12].
> 	* passes.def: Pass "first" argument to each back threading pass.
> 	* tree-ssa-threadbackward.c (back_threader::back_threader): Add
> 	first argument.
> 	(back_threader::debug_counter): New.
> 	(back_threader::maybe_register_path): Call debug_counter.
OK
jeff


  reply	other threads:[~2021-11-01 13:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-01  9:54 Aldy Hernandez
2021-11-01 13:02 ` Jeff Law [this message]
2021-11-02 13:27   ` Richard Biener
2021-11-02 13:35     ` Aldy Hernandez
2021-11-02 14:12       ` Richard Biener
2021-11-06 15:53         ` Aldy Hernandez
2021-11-08 12:22           ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6ce5313-d209-d7cd-5b4b-91db46f73ff1@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=aldyh@redhat.com \
    --cc=amacleod@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).