From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id 7AC963858C53 for ; Wed, 10 Jan 2024 16:27:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7AC963858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7AC963858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704904074; cv=none; b=nZqLZlAFvBXJKkhFpkZgbAdzArsl8ialYP7LFM5q8OzKIh63G5MHA3bSBvPhYcmjPr6GKH/IcI4GJsLiVW3SYRPafbhx1KMgyBq4wG248N2nWBi9eqxR8r+JvX6vapVN26Sjfw7umoCKloQOAGA3nJmi9Mg5A+J1uzarXbHIojk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704904074; c=relaxed/simple; bh=vEDhNGiOF+hO4UO1I8fc+SbfvmMlqHb7sXPUCfJ8oTg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=rPGcvVzvRY9r6xZK/yX5AbIId4NGQB3MTzQgdolTHxzh9YW6OE792FgIFf7y9HXcFnUMyeR7RCFqi4hZivA7ru+gOmz9iDXOOPr5zgSJwxDt0EkUQmOOcee1McS2kO36ovcsLf39hkXoFRK6iMfx80BijnaenkPyWiLwaA0EvUo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-3606dda206aso23483465ab.3 for ; Wed, 10 Jan 2024 08:27:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704904070; x=1705508870; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D4K38B95W/3nScAq5UJ/X508UV7IIFMKJ2ra8px4Si0=; b=anwGIYs9Ps2mU162yHMxUoRV48TOye+cAmslpIornGoSjcbJoHJbeKi/JfJxfYw5FC Bq2rgMJpr6j4tBv3kcwnNOZ4/eEtgtrLNcUTNOCl66hnIgX9WmAk+yp/N/sKE7V04M2B LBptoMw+pw1OupFyfq9vYKGg+6XZr9vlrFOXoKzhl7OTOt/RByTQiL8CvtilIbfGhy7I Ns5qtbChhAm2WzwF4mkDJHOQhlBD4P7RmI1yAIpdrndFkitThsjtj36UT/HxtEdTddPg hkd7CoHryqszYUHzmHLcfYWcplKgF7OT8SKkjenpFKVMcefu9kM6hLkZ1eGopoQrKN9F W6jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704904070; x=1705508870; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D4K38B95W/3nScAq5UJ/X508UV7IIFMKJ2ra8px4Si0=; b=ijTPXgrDJ/DVY/u62vwpenqfV45CbgCYBFcVorFsMBYXRg8dh1kAF92BEfdQgXOJwn a0dPxEK1aphRPcY8mMu/l3+ju2fchY6VWn+L2IvhFvCcmWEpzcmfDqwDyMARYNNNFoag PpqWMyCur/+0ql+5EGaG2k8GQAC0x+lPYZCq8FMzvU5TeCCpnpaJeAptAiU+ZVZzhgJN iJz0NGwYrJZv22ABHNdqAQY2/gxBg6wWNxFF2vf33QlOqkMLj7455TmPiCQEvVS6T5Vy dgJdkGXRMiE5jdgnR9gt0rbMfOlP7NqNxaGfhBXArGu9VTqmq+23fardACHDwQOwNLDe Bp8g== X-Gm-Message-State: AOJu0YwJpSmmpdGn3fkJalqchOS/CqBrIJE7oeWXcmuxhSjamKy2RrOo hjZIWjgc4BSoRAjqG7tYbM0= X-Google-Smtp-Source: AGHT+IGmem/QxbAjRRIsAkajeuY30FHNhKIZGgQRA7AvykaTbbLSIU3ElVweiSQrVT0NEVMHRVCBbQ== X-Received: by 2002:a5e:8f4a:0:b0:7be:f7e5:44fc with SMTP id x10-20020a5e8f4a000000b007bef7e544fcmr1136139iop.21.1704904070070; Wed, 10 Jan 2024 08:27:50 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id do29-20020a0566384c9d00b0046e0566ebe9sm1400776jab.107.2024.01.10.08.27.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jan 2024 08:27:49 -0800 (PST) Message-ID: Date: Wed, 10 Jan 2024 09:27:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Add a late-combine pass [PR106594] Content-Language: en-US To: Richard Biener , Richard Sandiford Cc: gcc-patches@gcc.gnu.org, jlaw@ventanamicro.com, rdapp.gcc@gmail.com, jakub@redhat.com References: <9s771497-p7p7-03p0-s417-96qqo9q917n0@fhfr.qr> From: Jeff Law In-Reply-To: <9s771497-p7p7-03p0-s417-96qqo9q917n0@fhfr.qr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/10/24 06:35, Richard Biener wrote: > > I think x86 maintainers could opt to disable the pass - so it would > be opt-out. It's reasonable to expect them to fix the backend given > there's nothing really wrong with the new pass, it just does > something that wasn't done before at that point? That's been both Richard S and my experience so far -- it's exposing latent target issues (which we're pushing forward as independent fixes) as well as a few latent issues in various generic RTL bits (which I'll leave to Richard S to submit). Nothing major though. I'm a bit disappointed it's not going forward for gcc-14, but understand and will support the decision. Jeff