From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id C41953858D35 for ; Sat, 17 Jun 2023 16:51:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C41953858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-25e7fe2fb51so920000a91.2 for ; Sat, 17 Jun 2023 09:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687020711; x=1689612711; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J5X9QqTfO85gGoaf0Tz5I+Ro/wj87I3nbN+wdd7y/Xw=; b=jWKBGYTLe8oErhGjsq0O1HemL60kDn3LUGesqeRvItbvohStAk5EJwoi4bme9Os9Xw 5MZI3dDks3gewWo1GiWoZof/smuQyWgqS4S6xUzX3g9+SARvsyQcHWo7q/Kd2Nx2ywXK 73nZziSnXGwIDTJVOB8RYsvBMktgW3nX3dDrjOqHKT2kzkcFwgbo3XScx+bqufgNB3hY VdJ7bQ84bQRH2V6+As+tT0XN1b4Qdrliu5rWxz3FcgZq/oebbRWF5hzQEp8LxLc7Cm3q r1SdG77tu++c8ttKRjeQpU6K83EHY/z4DDRHzgqy1/F26Q0IAAxsiwOv+E0oWa+gwoIM TCsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687020711; x=1689612711; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J5X9QqTfO85gGoaf0Tz5I+Ro/wj87I3nbN+wdd7y/Xw=; b=ACbUGua0MY9JxiHvJnAm++3delv4SFzlbhuvUqdRqkhX1HJALlty8nu+lK+XmxH4ed tzkDwoZJN5f+kC58tii0ttdyN+0SV8Tyv+N+bV1JTh9VknsFwKGvcbbCfPggm69KgY9s DE7dKpn3qmrbODAkqD3dXZ/VLIFmyb1NIaB0bFrJuJt/HaT/pXAbLzwfVQprb2FOyaxy Ek7rRCYqksjXYHbFPzk4Cxls2dPrSDQWC5QRhdDY1srM1ZWt2DZZcPpWMds78DP2J5jV i4ceCFG4Ljikp/ZGe3pgCvgJtwB9cbEnj29ki0IbtNGnyoaHCjm6zCUtauzT7/10u1bY aPmg== X-Gm-Message-State: AC+VfDwFgUL5bT3jKfmkqENa6ATtsmzp6tgsPM4WMn/7NJxt04JGaW+5 4p9zI3o1eV14afK1bfqoXHQ= X-Google-Smtp-Source: ACHHUZ5D4Dr5GU53/D1+lrfrBkPB+20u/xRn5bxUVCgHwvevaiuYnOPzgdC96/3N/9JpFE6rZjc6LQ== X-Received: by 2002:a17:90a:c717:b0:259:3d01:c151 with SMTP id o23-20020a17090ac71700b002593d01c151mr3462666pjt.21.1687020710602; Sat, 17 Jun 2023 09:51:50 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id j10-20020a17090a2a8a00b0025e2358f146sm3323468pjd.13.2023.06.17.09.51.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jun 2023 09:51:49 -0700 (PDT) Message-ID: Date: Sat, 17 Jun 2023 10:51:48 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] RTL: Merge rtx_equal_p and hash_rtx functions with their callback variants Content-Language: en-US To: Uros Bizjak , "gcc-patches@gcc.gnu.org" References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SCC_BODY_URI_ONLY,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/14/23 04:15, Uros Bizjak via Gcc-patches wrote: > Use default argument when callback function is not required to merge > rtx_equal_p and hash_rtx functions with their callback variants. > > gcc/ChangeLog: > > * cse.cc (hash_rtx_cb): Rename to hash_rtx. > (hash_rtx): Remove. > * early-remat.cc (remat_candidate_hasher::equal): Update > to call rtx_equal_p with rtx_equal_p_callback_function argument. > * rtl.cc (rtx_equal_p_cb): Rename to rtx_equal_p. > (rtx_equal_p): Remove. > * rtl.h (rtx_equal_p): Add rtx_equal_p_callback_function > argument with NULL default value. > (rtx_equal_p_cb): Remove function declaration. > (hash_rtx_cb): Ditto. > (hash_rtx): Add hash_rtx_callback_function argument > with NULL default value. > * sel-sched-ir.cc (free_nop_pool): Update function comment. > (skip_unspecs_callback): Ditto. > (vinsn_init): Update to call hash_rtx with > hash_rtx_callback_function argument. > (vinsn_equal_p): Ditto. > > Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. > > OK for master? OK jeff