From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 910F1385840E for ; Tue, 16 Apr 2024 08:59:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 910F1385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 910F1385840E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713258001; cv=none; b=c6X94ZKxSjAcUUb3M6h46MAtPoSmrP0jRa/A4EuuXbaF7ywbfjURtZcLh1kKZ5Hcs213jBdTLbLqAXyKJG2O1mEBrY55Z2ISPYFau4pKhblAiY5gCyxX2vVQUiKsHiZZqhXHFreipr1WlUeUzgEv2kSXs8XgTodLsytsYgAENUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713258001; c=relaxed/simple; bh=VHBSXAvY7DJGoJBsNUJIIHOC8zemBiCRgcGJsfwr3iA=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=hAwrweB3t+O4YVYSi+qQCcA7ylfb8DxagOH3IEu1ZbhwS+fBQJ7IebRML8/j+cGi5zEbeSLRG9+R+rTrkog9/yzgJBATGWqKnGwvZugQUpsiHqp/YnDMchHcyj48srP7hnLn2Swhbtz5eqIkQnH6jC8mhQ5cGZl4GN0wBfubpKA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7939B1063; Tue, 16 Apr 2024 02:00:26 -0700 (PDT) Received: from [10.2.78.64] (e120077-lin.cambridge.arm.com [10.2.78.64]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 41D733F792; Tue, 16 Apr 2024 01:59:57 -0700 (PDT) Message-ID: Date: Tue, 16 Apr 2024 09:59:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [testsuite] [arm] accept empty init for bfloat16 To: Alexandre Oliva , gcc-patches@gcc.gnu.org Cc: Rainer Orth , Mike Stump , Nick Clifton , Ramana Radhakrishnan References: From: "Richard Earnshaw (lists)" Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3497.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 16/04/2024 04:50, Alexandre Oliva wrote: > > Complete r13-2205, adjusting an arm-specific test that expects a > no-longer-issued error at an empty initializer. > > Regstrapped on x86_64-linux-gnu. Also tested with gcc-13 on arm-, > aarch64-, x86- and x86_64-vxworks7r2. Ok to install? > > > for gcc/testsuite/ChangeLog > > * gcc.target/arm/bfloat16_scalar_typecheck.c: Accept C23 > empty initializers. > --- > .../gcc.target/arm/bfloat16_scalar_typecheck.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/arm/bfloat16_scalar_typecheck.c b/gcc/testsuite/gcc.target/arm/bfloat16_scalar_typecheck.c > index 8c80c55bc9f4c..04ede93bda152 100644 > --- a/gcc/testsuite/gcc.target/arm/bfloat16_scalar_typecheck.c > +++ b/gcc/testsuite/gcc.target/arm/bfloat16_scalar_typecheck.c > @@ -42,7 +42,7 @@ bfloat16_t footest (bfloat16_t scalar0) > short initi_1_4 = glob_bfloat; /* { dg-error {invalid conversion from type 'bfloat16_t'} } */ > double initi_1_5 = glob_bfloat; /* { dg-error {invalid conversion from type 'bfloat16_t'} } */ > > - bfloat16_t scalar2_1 = {}; /* { dg-error {empty scalar initializer} } */ > + bfloat16_t scalar2_1 = {}; > bfloat16_t scalar2_2 = { glob_bfloat }; > bfloat16_t scalar2_3 = { 0 }; /* { dg-error {invalid conversion to type 'bfloat16_t'} } */ > bfloat16_t scalar2_4 = { 0.1 }; /* { dg-error {invalid conversion to type 'bfloat16_t'} } */ > @@ -94,7 +94,7 @@ bfloat16_t footest (bfloat16_t scalar0) > > /* Compound literals. */ > > - (bfloat16_t) {}; /* { dg-error {empty scalar initializer} } */ > + (bfloat16_t) {}; > (bfloat16_t) { glob_bfloat }; > (bfloat16_t) { 0 }; /* { dg-error {invalid conversion to type 'bfloat16_t'} } */ > (bfloat16_t) { 0.1 }; /* { dg-error {invalid conversion to type 'bfloat16_t'} } */ > This test is checking for errors. Perhaps it would be better to select an older version of the standard and then set pedantic-error mode. R.