public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Xi Ruoyao <xry111@xry111.site>
To: Peng Fan <fanpeng@loongson.cn>, gcc-patches@gcc.gnu.org
Cc: chenglulu@loongson.cn
Subject: Re: [PATCH] LoongArch: fix MUSL_DYNAMIC_LINKER
Date: Mon, 17 Apr 2023 14:36:52 +0800	[thread overview]
Message-ID: <c72d6ad8d5c49380b3270d71a5e139ffe0d13442.camel@xry111.site> (raw)
In-Reply-To: <20230417023919.7015-1-fanpeng@loongson.cn>

On Mon, 2023-04-17 at 10:39 +0800, Peng Fan wrote:
> The system based on musl has no '/lib64', so change it.

I like the change.  IMO Glibc-based systems should avoid /lib64 as well
but it's too late to change it now.

Could you provide a link to the Musl doc as a reference?  I'd like to
include the link in the commit message.

> gcc/
>         * config/loongarch/gnu-user.h (MUSL_DYNAMIC_LINKER): Redefine.
> 
> Signed-off-by: Peng Fan <fanpeng@loongson.cn>
> ---
>  gcc/config/loongarch/gnu-user.h | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/gcc/config/loongarch/gnu-user.h
> b/gcc/config/loongarch/gnu-user.h
> index aecaa02a199..fa1a5211419 100644
> --- a/gcc/config/loongarch/gnu-user.h
> +++ b/gcc/config/loongarch/gnu-user.h
> @@ -33,9 +33,14 @@ along with GCC; see the file COPYING3.  If not see
>  #define GLIBC_DYNAMIC_LINKER \
>    "/lib" ABI_GRLEN_SPEC "/ld-linux-loongarch-" ABI_SPEC ".so.1"
>  
> +#define MUSL_ABI_SPEC \
> +  "%{mabi=lp64d:-lp64d}" \
> +  "%{mabi=lp64f:-lp64f}" \
> +  "%{mabi=lp64s:-lp64s}"
> +
>  #undef MUSL_DYNAMIC_LINKER
>  #define MUSL_DYNAMIC_LINKER \
> -  "/lib" ABI_GRLEN_SPEC "/ld-musl-loongarch-" ABI_SPEC ".so.1"
> +  "/lib/ld-musl-loongarch" ABI_GRLEN_SPEC MUSL_ABI_SPEC ".so.1"
>  
>  #undef GNU_USER_TARGET_LINK_SPEC
>  #define GNU_USER_TARGET_LINK_SPEC \

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

  reply	other threads:[~2023-04-17  6:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17  2:39 Peng Fan
2023-04-17  6:36 ` Xi Ruoyao [this message]
2023-04-17  6:51   ` 樊鹏
2023-04-19  7:19     ` Lulu Cheng
2023-04-19  8:23 Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c72d6ad8d5c49380b3270d71a5e139ffe0d13442.camel@xry111.site \
    --to=xry111@xry111.site \
    --cc=chenglulu@loongson.cn \
    --cc=fanpeng@loongson.cn \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).