From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Rx7J=57=mentor.com=joseph_myers@sourceware.org>
Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180])
	by sourceware.org (Postfix) with ESMTPS id 108433858C52
	for <gcc-patches@gcc.gnu.org>; Fri,  3 Feb 2023 20:55:17 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 108433858C52
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com
X-IronPort-AV: E=Sophos;i="5.97,271,1669104000"; 
   d="scan'208";a="95593434"
Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165])
  by esa3.mentor.iphmx.com with ESMTP; 03 Feb 2023 12:55:17 -0800
IronPort-SDR: hY8WQRwKnZK3RbgntSPBAjooSkKTWMdMEvKutIsQknQ3cYxvoxCcaFQ1kRTNdzySZMZecGR96f
 IHN4auuTQQPj/5PX2xdSpe/mbcbKMY/qmPf45rehW8z0GjD8qI/dyQspzoI4CRMXH5qNzhJR1d
 hLittM3NRP3D4VCc2jA8KH0Hz9mlL3s0cC8Qwx4c55qgV9CthSnMhNzqOeRBlN5VUDeSGSgCxB
 BqqUYST+UC4m3OIP8Ervi8R2mHj1E9Px1ycM4gZI7ScsGAr1/wEuo+big0b3IQfMlQYpqRagKj
 odQ=
Date: Fri, 3 Feb 2023 20:55:06 +0000
From: Joseph Myers <joseph@codesourcery.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
CC: Richard Biener <rguenther@suse.de>, Qing Zhao <qing.zhao@oracle.com>, gcc
 Patches <gcc-patches@gcc.gnu.org>, "keescook@chromium.org"
	<keescook@chromium.org>
Subject: Re: [PATCH 2/2] Documentation Update.
In-Reply-To: <870439b5-0eca-608e-ddcc-ec885ac3f6b8@gotplt.org>
Message-ID: <c7cc37f5-33ca-ceb5-e36-c1281956f4d0@codesourcery.com>
References: <20230131141140.3610133-1-qing.zhao@oracle.com> <20230131141140.3610133-3-qing.zhao@oracle.com> <f7fa47c9-2bad-e11c-ea31-74ef4bd8068d@gotplt.org> <1AB22124-10D2-416D-B1BD-D4FF728AB0E2@oracle.com> <b214fe7e-583a-f9ab-7e46-b03c440a4543@gotplt.org>
 <nycvar.YFH.7.77.849.2302020824440.6551@jbgna.fhfr.qr> <870439b5-0eca-608e-ddcc-ec885ac3f6b8@gotplt.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To
 svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10)
X-Spam-Status: No, score=-3108.6 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Thu, 2 Feb 2023, Siddhesh Poyarekar wrote:

> I dug into this on the glibc end and it looks like this commit:
> 
> commit 63fb8f9aa9d19f85599afe4b849b567aefd70a36
> Author: Zack Weinberg <zackw@panix.com>
> Date:   Mon Feb 5 14:13:41 2018 -0500
> 
>     Post-cleanup 2: minimize _G_config.h.
> 
> ripped all of that gunk out.  AFAICT there's no use of struct __gconv_info
> anywhere else in the code.
> 
> I reckon it is safe to say now that glibc no longer needs this misfeature.

It would be worth testing whether any change warns anywhere else in glibc 
(not necessarily in installed headers).  And to have fixincludes for the 
installed _G_config.h from old glibc if we start rejecting such code.

-- 
Joseph S. Myers
joseph@codesourcery.com