From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by sourceware.org (Postfix) with ESMTPS id 7196A3858C66 for ; Tue, 27 Dec 2022 15:38:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7196A3858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-io1-xd2a.google.com with SMTP id q190so7035059iod.10 for ; Tue, 27 Dec 2022 07:38:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1essol9hM8tMoAq2iE0Nqx3lT39K4FxRsZuqOiHP5ls=; b=XmKErD2r0vd2rpeBtMzx2WX63gaHoUw7KB8gXt+MEnTOdMiuEj4Cr7bKMkwoxgAIYi ROLYJ3Vdl9fEXXzF8VtwbpDudjHHIXHTI56pd50GNQgarmCrof2kuqkKQKdeCA7WGob4 l7ORLddoNN2++eXYgab2jssqgcPYjMcOQkNZIQmB8x8OW3AWP9al3Xtbg87inbhGXbHh qxy4+cx1UMxpy2+WYmKelulGoWPEBYWj6qCfqgDL57YEbolvD2SmPm80/H2I5NxzJphi zkor71QW+SUjOMWdSIrM9R+WFubP53rQzspPZXtmVe9PoiPVwNsrgp5U3SJmo8Tp4cxl Cfsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1essol9hM8tMoAq2iE0Nqx3lT39K4FxRsZuqOiHP5ls=; b=J18cKUfRh4xuGhyaB8I1vLe8BL6/OWwZGje1XmcSnjOlPIDP3wO7Ih/YFhEbo1mN4y D+wEkHpf0avFDk845F7vM2sUruiocJPH1OQQ4sRKdBPTNCnfGXjgB4hl0/cAm0KYbZ18 PHY7tJKVAKhpv3pBoYf3ZV+4oGADHcatoXzBZyBdK6OHDPSTAXxVygE2eS4nxD4QCFLH uyZ41ladPQHq+zxIgas6UZs7LkVl69PjNHOmyKI0LlI/PCxd5xrrxIEZaO3+lChEX1CY NExq+ENMUOD/ibc14hwCugtTX+qcShy9OqKpz6N5/9faKiMoRz8vUxrRgJ2+Wswaq6XK dltw== X-Gm-Message-State: AFqh2krixL1KhXvqTXj+cvIEUcXp4LyyYZR2waCuWqn0ujLvTo8c2/Yf GbYkBjZ6HOzu4Afeyry3lG4= X-Google-Smtp-Source: AMrXdXvXYnFi6zeY0AniZTf5hpjVK9OZfibSNXjq54NEVC8P6khMwKfYX3xprNsanxdv+JHL3rNcGQ== X-Received: by 2002:a6b:8f82:0:b0:6eb:da60:be0b with SMTP id r124-20020a6b8f82000000b006ebda60be0bmr15123814iod.4.1672155485633; Tue, 27 Dec 2022 07:38:05 -0800 (PST) Received: from [172.31.1.18] (65-130-81-249.slkc.qwest.net. [65.130.81.249]) by smtp.gmail.com with ESMTPSA id w26-20020a05660205da00b006df3382b659sm5106879iox.42.2022.12.27.07.38.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Dec 2022 07:38:05 -0800 (PST) Message-ID: Date: Tue, 27 Dec 2022 08:38:03 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [09/13] [C++] constexpr: request insert iff depth is ok Content-Language: en-US To: Alexandre Oliva , gcc-patches@gcc.gnu.org Cc: Jason Merrill , Nathan Sidwell References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/26/22 21:30, Alexandre Oliva via Gcc-patches wrote: > > cxx_eval_call_expression requests an INSERT even in cases when it > would later decide not to insert. This could break double-hashing > chains. Arrange for it to use NO_INSERT when the insertion would not > be completed. > > Regstrapped on x86_64-linux-gnu. Ok to install? > > > for gcc/cp/ChangeLog > > * constexpr.cc (cxx_eval_call_expression): Do not request an > INSERT that would not be completed. OK. Jeff