From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id C2D663858D37 for ; Mon, 23 Oct 2023 10:16:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C2D663858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C2D663858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698056176; cv=none; b=NBfZZsW2TUAzy04hs6Jm46jqSo4b+exQSBjwGbC4wEiTAd1gWuR58WqIRcwSpm7eqviSCua3woQGibycBiI94gnS3uNYlPmK0FVySGmExF1PtDohPPfnzAxCDwMcO76fdzKLsj6gqeS6wQxqjKu/DfaxxrvGk5FB2q29OB3p9lE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698056176; c=relaxed/simple; bh=ycRGCj7P5IVhiyJxn038Q0ZrxNKKFDlTwNTbbhci98U=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=bNtlhqJwpDqqWT+glHy1VYf2QnB3sgRcl1tPy0+VuK7/BjZ8WZUiSQvrTGZJMCZpsh6FhPSa57gQ1PRTGc7ERD4OmBFdsUIXmbM2Skp7Pdr37qgpiAhKemXPXUx7sisCtKx7QPH1+bRr8oq/jZ7DMc0BXPpntPo08JYo7+i7eFo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C6762F4; Mon, 23 Oct 2023 03:16:55 -0700 (PDT) Received: from [10.57.67.232] (unknown [10.57.67.232]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A370B3F64C; Mon, 23 Oct 2023 03:16:13 -0700 (PDT) Message-ID: Date: Mon, 23 Oct 2023 11:16:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PING][PATCH 2/2] arm: Add support for MVE Tail-Predicated Low Overhead Loops To: Stamatis Markianos-Wright , Kyrylo Tkachov , "gcc-patches@gcc.gnu.org" Cc: Richard Earnshaw , "jlaw@ventanamicro.com" References: <949f5dd0-cdf0-715a-f04c-3de80c9b974f@arm.com> <965e9d26-5664-ccee-888c-8151b4c0abcb@arm.com> Content-Language: en-US From: "Andre Vieira (lists)" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping for Jeff or another global maintainer to review the target agnostic bits of this, that's: loop-doloop.cc df-core.{c,h} I do have a nitpick myself that I missed last time around: /* We expect the condition to be of the form (reg != 0) */ cond = XEXP (SET_SRC (cmp), 0); - if (GET_CODE (cond) != NE || XEXP (cond, 1) != const0_rtx) + if ((GET_CODE (cond) != NE && GET_CODE (cond) != GE) + || XEXP (cond, 1) != const0_rtx) return 0; } Could do with updating the comment to reflect allowing >= now. But happy for you to change this once approved by a maintainer. Kind regards, Andre On 11/10/2023 12:34, Stamatis Markianos-Wright wrote: > Hi all, > > On 28/09/2023 13:51, Andre Vieira (lists) wrote: >> Hi, >> >> On 14/09/2023 13:10, Kyrylo Tkachov via Gcc-patches wrote: >>> Hi Stam, >>> >> >>> >>> The arm parts look sensible but we'd need review for the df-core.h >>> and df-core.cc changes. >>> Maybe Jeff can help or can recommend someone to take a look? > > Just thought I'd do a follow-up "ping" on this :) > > >>> Thanks, >>> Kyrill >>> >> >> FWIW the changes LGTM, if we don't want these in df-core we can always >> implement the extra utility locally. It's really just a helper >> function to check if df_bb_regno_first_def_find and >> df_bb_regno_last_def_find yield the same result, meaning we only have >> a single definition. >> >> Kind regards, >> Andre > > Thanks, > > Stam >