public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Eric Gallager <egall@gwmail.gwu.edu>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html
Date: Wed, 1 Dec 2021 17:54:15 +0200 (EET)	[thread overview]
Message-ID: <c7e4e24-2a8-a8d-de3d-fe4fdc731173@pfeifer.com> (raw)
In-Reply-To: <CAMfHzOtCofmeEKNvMQ2MggYt0t_g+Y6-CxjXaDQixrpBvTCfnw@mail.gmail.com>

Hi Eric,

On Wed, 24 Nov 2021, Eric Gallager wrote:
> This next patch does more than just removing old stuff: it adds an
> extra sentence to describe a shell command used to generate a list, so
> to verify that I've got the shell command right, I'm asking for a
> review.

-<p>There are several other files in this size range, which I have left
+<p>There are several other files in this size range, which are left
 out because touching them at all is unwise (reload, the Fortran front
 end).  You can try, but I am not responsible for any damage to your
 sanity which may result.</p>

while we are touching this, how about toning the second half of this
paragraph down and moving away from first person?

How about something like "...breaking them up likely may prove rather
difficult" (or similar, happy to leave this to you as native spaker)?


+<p>Note that the list of large files in this section is generated with the
+following shell command, run from the gcc subdirectory:</p>
+
+<pre>
+	du -sh *.{c,h,cc} */*.{c,h,cc} | sort -hr | grep -v fortran | head -n 14
+</pre>

This looks like it does what you want it to do.

(Pulling up the database courses I have given in a previous life, I'd pull 
in the grep before the sort - O(n) filtering before O(n·log n) processing
- but even on my notebook both are instantenous. ;-) )


Please consider the two suggestions above and commit the result; just
share the final patch here (no review required).

Thanks,
Gerald

  parent reply	other threads:[~2021-12-01 15:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  1:37 [PATCH][wwwdocs] remove references to java " Eric Gallager
2021-11-19  6:48 ` Gerald Pfeifer
2021-11-19 13:14   ` Eric Gallager
2021-11-23 23:27     ` [committed][wwwdocs] Remove section on traditional C from htdocs/projects/beginner.html Eric Gallager
2021-11-24  7:11       ` [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html Eric Gallager
2021-12-01 15:14         ` PING " Eric Gallager
2021-12-01 15:54         ` Gerald Pfeifer [this message]
2021-12-01 17:26           ` Eric Gallager

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7e4e24-2a8-a8d-de3d-fe4fdc731173@pfeifer.com \
    --to=gerald@pfeifer.com \
    --cc=egall@gwmail.gwu.edu \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).