From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) by sourceware.org (Postfix) with ESMTPS id D4D863858401 for ; Wed, 1 Dec 2021 15:54:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D4D863858401 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=pfeifer.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=pfeifer.com Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 89ED033EFD; Wed, 1 Dec 2021 10:54:18 -0500 (EST) Received: from [172.20.3.196] (unknown [41.33.240.196]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id CDFA633EF4; Wed, 1 Dec 2021 10:54:17 -0500 (EST) Date: Wed, 1 Dec 2021 17:54:15 +0200 (EET) From: Gerald Pfeifer To: Eric Gallager cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html In-Reply-To: Message-ID: References: MIME-Version: 1.0 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Dec 2021 15:54:20 -0000 Hi Eric, On Wed, 24 Nov 2021, Eric Gallager wrote: > This next patch does more than just removing old stuff: it adds an > extra sentence to describe a shell command used to generate a list, so > to verify that I've got the shell command right, I'm asking for a > review. -

There are several other files in this size range, which I have left +

There are several other files in this size range, which are left out because touching them at all is unwise (reload, the Fortran front end). You can try, but I am not responsible for any damage to your sanity which may result.

while we are touching this, how about toning the second half of this paragraph down and moving away from first person? How about something like "...breaking them up likely may prove rather difficult" (or similar, happy to leave this to you as native spaker)? +

Note that the list of large files in this section is generated with the +following shell command, run from the gcc subdirectory:

+ +
+	du -sh *.{c,h,cc} */*.{c,h,cc} | sort -hr | grep -v fortran | head -n 14
+
This looks like it does what you want it to do. (Pulling up the database courses I have given in a previous life, I'd pull in the grep before the sort - O(n) filtering before O(n·log n) processing - but even on my notebook both are instantenous. ;-) ) Please consider the two suggestions above and commit the result; just share the final patch here (no review required). Thanks, Gerald