From: Jeff Law <law@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>,
Joseph Myers <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/3] (v2) On-demand locations within string-literals
Date: Thu, 04 Aug 2016 17:37:00 -0000 [thread overview]
Message-ID: <c7e959c5-6922-03cb-4660-db3f3dbe044e@redhat.com> (raw)
In-Reply-To: <1470320820.8203.21.camel@redhat.com>
On 08/04/2016 08:27 AM, David Malcolm wrote:
>
> As for test coverage, v2 and v3 of the kit add over a thousand lines of
> selftest code that heavily exercise string lexing, using the
> line_table_case machinery to run the tests with various interesting
> boundary conditions with line_table (e.g. near
> LINE_MAP_MAX_LOCATION_WITH_PACKED_RANGES).
>
> In terms of test coverage of the fallbacks, patch 2 of v3 of the kit
> directly exercises the substr_loc.get_range in
> gcc.dg/plugin/diagnostic_plugin_test_string_literals.c via
> gcc.dg/plugin/diagnostic-test-string-literals-1.c, and some of the
> tests there cover the failures, via:
>
> error_at (strloc, "unable to read substring range: %s", err);
>
> which we wouldn't do in a normal diagnostic (but which is appropriate
> for testing the machinery itself).
>
> Patch 3 of the v3 kit adds a format_warning_va function to c-format.c
> which is responsible for dealing with failures:
> https://gcc.gnu.org/ml/gcc-patches/2016-08/msg00204.html
THanks for pointing this out. I hadn't started looking at the meat of
the on-demand locations until this morning.
>
>
> Looking at patch 3, there's a fair amount of end-to-end testing in
> gcc.dg/format/diagnostic-ranges.c but it looks like I forgot to add an
> end-to-end test there of failure due to stringification; I can add one.
> Is the rest of the v3 patch kit reviewable?
Absolutely. I wasn't trying to imply that it wasn't -- in fact most of
it is self-approvable stuff and I've only got a couple questions about
the rest.
Jeff
next prev parent reply other threads:[~2016-08-04 17:37 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 21:22 [PATCH] RFC: " David Malcolm
2016-07-20 19:38 ` David Malcolm
2016-07-21 16:38 ` Jeff Law
2016-07-26 16:43 ` [PATCH 1/3] (v2) " David Malcolm
2016-07-26 16:43 ` [PATCH 2/3] Use class substring_loc in c-format.c (PR c/52952) David Malcolm
2016-07-26 16:43 ` [PATCH 3/3] c-format.c: suggest the correct format string to use (PR c/64955) David Malcolm
2016-07-26 18:06 ` [PATCH 1/3] (v2) On-demand locations within string-literals Manuel López-Ibáñez
2016-07-27 14:30 ` David Malcolm
2016-07-27 22:42 ` Manuel López-Ibáñez
2016-07-28 20:12 ` David Malcolm
2016-07-28 20:38 ` Martin Sebor
2016-07-28 21:17 ` Martin Sebor
2016-07-29 12:37 ` David Malcolm
2016-07-29 14:22 ` Martin Sebor
2016-07-29 14:46 ` David Malcolm
2016-07-29 15:26 ` David Malcolm
2016-07-29 16:54 ` Manuel López-Ibáñez
2016-07-29 17:27 ` David Malcolm
2016-07-30 1:18 ` Manuel López-Ibáñez
2016-08-03 15:56 ` Jeff Law
2016-08-01 21:13 ` Joseph Myers
2016-07-29 21:42 ` Joseph Myers
2016-07-30 1:16 ` David Malcolm
2016-08-03 15:17 ` [PATCH 1/4] selftest.h: Add ASSERT_TRUE_AT and ASSERT_FALSE_AT David Malcolm
2016-08-03 15:17 ` [PATCH 4/4] c-format.c: suggest the correct format string to use (PR c/64955) David Malcolm
2016-08-04 19:55 ` Jeff Law
2016-08-04 21:06 ` David Malcolm
2016-08-03 15:17 ` [PATCH 2/4] (v3) On-demand locations within string-literals David Malcolm
2016-08-04 17:38 ` Jeff Law
2016-08-04 19:21 ` David Malcolm
2016-08-04 20:18 ` Jeff Law
2016-08-05 18:17 ` [Committed] [PATCH 2/4] (v4) " David Malcolm
2016-08-06 5:48 ` Markus Trippelsdorf
2016-08-06 5:59 ` Prathamesh Kulkarni
2016-08-06 18:10 ` [committed] Fix crash in selftest::test_lexer_string_locations_ucn4 (PR bootstrap/72823) David Malcolm
2021-09-02 13:59 ` [Committed] [PATCH 2/4] (v4) On-demand locations within string-literals Thomas Schwinge
2021-09-02 19:09 ` Thomas Schwinge
2021-09-03 16:33 ` Thomas Schwinge
2021-09-10 7:48 ` [PING] " Thomas Schwinge
2021-09-17 11:16 ` [PING^2] " Thomas Schwinge
2021-09-30 6:47 ` [PING^3] Generalize 'gcc/input.h:struct location_hash' (was: [Committed] [PATCH 2/4] (v4) On-demand locations within string-literals) Thomas Schwinge
2021-10-17 22:33 ` Jeff Law
2021-11-09 13:48 ` Thomas Schwinge
2021-09-19 5:52 ` [PING] Re: [Committed] [PATCH 2/4] (v4) On-demand locations within string-literals Jeff Law
2016-08-03 15:17 ` [PATCH 3/4] Use class substring_loc in c-format.c (PR c/52952) David Malcolm
2016-08-04 18:09 ` Jeff Law
2016-08-04 19:25 ` David Malcolm
2016-08-04 20:22 ` Jeff Law
2016-08-06 0:56 ` [PATCH] c-format.c: cleanup of check_format_info_main David Malcolm
2016-08-08 17:20 ` Jeff Law
2016-08-08 20:16 ` [PATCH 3/4] Use class substring_loc in c-format.c (PR c/52952) David Malcolm
2016-08-03 16:06 ` [PATCH 1/4] selftest.h: Add ASSERT_TRUE_AT and ASSERT_FALSE_AT Jeff Law
2016-08-04 19:02 ` David Malcolm
2016-08-03 15:59 ` [PATCH 1/3] (v2) On-demand locations within string-literals Jeff Law
2016-08-04 14:27 ` David Malcolm
2016-08-04 17:37 ` Jeff Law [this message]
2016-07-23 21:36 ` [PATCH] RFC: " Martin Sebor
2016-07-24 0:37 ` David Malcolm
2016-08-23 3:25 ` Martin Sebor
2016-08-23 13:59 ` David Malcolm
2016-08-23 15:18 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7e959c5-6922-03cb-4660-db3f3dbe044e@redhat.com \
--to=law@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).