From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76157 invoked by alias); 15 Jan 2019 22:37:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76130 invoked by uid 89); 15 Jan 2019 22:37:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:755, H*f:sk:119d761, 33PM X-HELO: cc-smtpout1.netcologne.de Received: from cc-smtpout1.netcologne.de (HELO cc-smtpout1.netcologne.de) (89.1.8.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Jan 2019 22:37:53 +0000 Received: from cc-smtpin1.netcologne.de (cc-smtpin1.netcologne.de [89.1.8.201]) by cc-smtpout1.netcologne.de (Postfix) with ESMTP id A35EC13100; Tue, 15 Jan 2019 23:37:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=netcologne.de; s=nc1116a; t=1547591871; bh=h/rMS40q0lBdvkS6rJ76QOPYU3d2/ZhFddtrQpOgXWo=; h=Subject:To:Cc:References:From:Message-ID:Date:In-Reply-To:From; b=dP+DC7QReGoEJtcmY0sS56na7AXXzXOlPLzxYCRAMI1p5XsqGGFRco1eAr9Ls1Gc3 MiYsL0C8xPPnl/RVTE/uzdH2zIJDAXI+zc9kxKbuCtJf5f3EazbKGY4YakwuMmwM5n KTebjSboIBH2s9RRU653xIe74W/Oj1pR/JmxLYZJqeWK+fUJEh24KVkcA2blqxQQQ5 hADEIb8eRHQ0+anxwIX4R9N2A0oqF166a+3UaaoWseN7feO72FeyFCaBT3uTXyzPdM z33d00M5/eNC3SQA77lD98b+qO5ltE6X23MI7E6dWCfpRCDCzQ/KjNJQSGsgewTwmz u1/CvveNFsZFA== Received: from localhost (localhost [127.0.0.1]) by cc-smtpin1.netcologne.de (Postfix) with ESMTP id A001311D76; Tue, 15 Jan 2019 23:37:51 +0100 (CET) Received: from [78.35.146.213] (helo=cc-smtpin1.netcologne.de) by localhost with ESMTP (eXpurgate 4.6.0) (envelope-from ) id 5c3e60bf-5f8a-7f0000012729-7f0000018454-1 for ; Tue, 15 Jan 2019 23:37:51 +0100 Received: from [192.168.178.68] (xdsl-78-35-146-213.nc.de [78.35.146.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by cc-smtpin1.netcologne.de (Postfix) with ESMTPSA; Tue, 15 Jan 2019 23:37:48 +0100 (CET) Subject: Re: [patch, fortran] Fix PR 43072 To: sgk@troutmask.apl.washington.edu Cc: "fortran@gcc.gnu.org" , gcc-patches References: <119d7610-8bca-30e2-fcb0-86ed2e9eeb09@netcologne.de> <20190115221135.GA4744@troutmask.apl.washington.edu> From: Thomas Koenig Message-ID: Date: Tue, 15 Jan 2019 22:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20190115221135.GA4744@troutmask.apl.washington.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-01/txt/msg00875.txt.bz2 Hi Steve, > On Tue, Jan 15, 2019 at 10:58:33PM +0100, Thomas Koenig wrote: >> >> the attached patch fixes a missed optimization where a substring equal >> in length to the original variable currently leads to an unneeded >> temporary. >> >> Regression-tested. OK for trunk? > > Yes. See below. Thanks. >> >> 2019-01-15 Thomas Koenig >> >> PR fortran/43072 >> * resolve.c (resolve_array_ref): Add equal_length argument; set it >> if the length of the substring equals that of the orignal >> variable. >> (resolve_ref): Remove the substring if it is equal in length >> length to the original variable, unless it is an EXPR_SUBSTRING). > > in length length? Fixed in the commit. Regards Thomas