From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2058.outbound.protection.outlook.com [40.107.220.58]) by sourceware.org (Postfix) with ESMTPS id 9D8E5385C6F1 for ; Fri, 1 Dec 2023 17:44:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9D8E5385C6F1 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=siemens.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siemens.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9D8E5385C6F1 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.220.58 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701452647; cv=pass; b=cxof7PDYENjKjhigD7XTjM7ao6IylGRZ2OLTgq/YIPYqLbf8Dd2gG2bm+Dw6px5X+AHfoTJqHmAddIuGugSMHwz8Vax2q7CvYPQhzKk4LA+WwYujbxNQJenihscoIHn4alF9bdXyTzauLq7TWQ/LxoJ+LizbsK8nyd7jZNdENDM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701452647; c=relaxed/simple; bh=AiZmaeigmavddE5iFZp17jK/RaxSFYrvv0s/4FJDNqo=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=pvUO6nW1D5WovvAixdL/ijqgAj78ch3iHi4zjOuCuhuB9yYE894IMY7skwxZdaKznlbtRot0QZjlmx6Omj72p5FOyDNKrxCPgyClCYLjNh1X66eOdbdZv9iabp0gbjKfezs8L0VIXArX6BGVCeobyTMRIXoJ/6QyDzfcqwbf6Wk= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=llbZ4gIQFuA+4wspj+Bn1p/qD64m8rUCns3AQPvddNSsontsBvF1UNkZm/hEph2MOBEAcBDyM0DpZm+xVGUOuQSXsmHHN6I0GAYE2Ch/pGG73TT+BJyUBMgaKYXmoEihM5yr6UTPnqkb2JvfAHVXWRiewm8RkOAlBj/gxRFigtr/S6F903maxFkJrxO9RFpC2mI13vA1jVVQKonSlPmszfDQeYHBD18AlHo1bFw8/zFiGleZN596zO5WdILHv9NjxvmfTSwZNzV3uT7mEEXmKm9A24Lgct2AoCtGmGhk2upvribvb9bz05aSim0gVacycs9UOGYkeJySs8raoEQeQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fzGWpoDuKIDcDylSCWYgo+Z9RS2zlywmfxrordXMz6Q=; b=J/hO8bg24jI3V+LmNYe9Spne3aYbeBS+RxLHJ17bm1GCwSZFoDut/2g9OOmJyJVP+b/s03NfMr/lE9NIaJsN3WKJV2bEtS8ct4wMkEdbvsgprU4AawO6cw48TMQ5DggA8RezZJmwynyJzC7pAJP0KIVtXqa7qkSv9jSn3vUmGDomCkYwZdUoHvH15xFMrv5oJ5nv/HU5jE8T+vUHV9RG4LHfic19MNk2wmq77FYAqMH5g5bCHhmPoTWkv4RjKV+gy70uLBSfw0g8mb+kaUFVibAspkEi2JlWhHDXQlv6g5OhRQy+Yp9qvrny68GbNJ7W1kF9P/WlSHRJd6pM7UFqLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fzGWpoDuKIDcDylSCWYgo+Z9RS2zlywmfxrordXMz6Q=; b=vMPKhWzdjLWUKXEVWVoK/IgJErHsXQegkSyvT0cN6WLVA+MvrHX224HdZQUHw23fIq7eTAeTEebHEAjqbmRXaMhspz1IiOlX6lGh8XGUDaw8/r6jtGdvjiyG/i/VkvdCRqK/oWOoTsn5rkmEna+lv2J/oALcMiToJ6z//QbY9RgyjySDg9OS/S2/GFPpwdP6t577q4LfkUc7dPDj956P1EpXVM7SErIjLsM1LXmyenX9fTg/LB3bzOQwW82tTdEwVVJ1zQMG0vhTPg97TC9noL6yYqR5yuvH6EuGj1rVu+3FKkWuYqi4y48gCiBoiCkDuKd4qRBpVP5GOPh77JWu6w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from CH2PR07MB7222.namprd07.prod.outlook.com (2603:10b6:610:ab::21) by BLAPR07MB8241.namprd07.prod.outlook.com (2603:10b6:208:330::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.27; Fri, 1 Dec 2023 17:44:02 +0000 Received: from CH2PR07MB7222.namprd07.prod.outlook.com ([fe80::69bd:212e:8997:d6f9]) by CH2PR07MB7222.namprd07.prod.outlook.com ([fe80::69bd:212e:8997:d6f9%4]) with mapi id 15.20.7046.027; Fri, 1 Dec 2023 17:44:01 +0000 Message-ID: Date: Fri, 1 Dec 2023 10:43:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] extend.texi: Fix up defbuiltin* with spaces in return type Content-Language: en-US To: Jakub Jelinek Cc: Gerald Pfeifer , Joseph Myers , Sandra Loosemore , gcc-patches@gcc.gnu.org References: From: Sandra Loosemore In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR07CA0069.namprd07.prod.outlook.com (2603:10b6:a03:60::46) To CH2PR07MB7222.namprd07.prod.outlook.com (2603:10b6:610:ab::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR07MB7222:EE_|BLAPR07MB8241:EE_ X-MS-Office365-Filtering-Correlation-Id: 4eea05c1-c3d5-4720-1247-08dbf29519f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7MbIhLNIdohLqDt5JmHTYjnliKoDn4S3OnwqCxZbZi/pS3giK+R5yWnyLdD9JlPFjXwmbUOTMpG4Ihe8pNUHGlW87RwI0BKPVEZ5Oh6zOduD88YNbIu+Ye5pWOTFuQ6xI4gQztKbx4Jegvf264sRujshsqZi8xxIy6FQMWpSFfb9Mkhmdb+Xk0bRiJbIuGqtX2tUhtP2lK8xLuhzkeW+0ruHHPKeZOrIn6irPAidrMHXzV7EUQ9nLIcMo1fpJCfUeuK9Cko16mKismDjl6cLs1lBdT+8kwQnYw/qgc9vSlJ72VoQDEmH+O1Np9VXN+vW4hA5IXZn1JTDm7bBmQvcMjG/jsOIN4MXPL9QV05TPDIaWVPFxfKP5W/o/+kw/ggmAlYhNNy1bpQCImAIjXFPKgY0RxqhgGJCgmccOnq8aA/iBrIMCsiKxeqcSv6R2MYv93B7SPaK9P5MWZCmBggWMPclshnomL9gzpFvbPkCCeXzpTsLgHEdILah1qYX0NDhrouFFTP42zUjpyGHPyRfhD/MpKV5qkdbZsncv+58wMgFcTxPmOI+1sp5eDtZ239r5rsVq/NBLrLVmHG8pjGAAq+zdPMmp0VSGW4iY/jhrAQPvkyYMSgc7cbrObpI79y32nYRQ82fMp8pf9A0dw3zvw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR07MB7222.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(346002)(39860400002)(396003)(136003)(376002)(230922051799003)(186009)(451199024)(1800799012)(64100799003)(5660300002)(2906002)(66476007)(6916009)(4326008)(54906003)(316002)(66556008)(66946007)(8676002)(8936002)(41300700001)(6506007)(6666004)(6486002)(478600001)(6512007)(44832011)(53546011)(31686004)(2616005)(83380400001)(38100700002)(82960400001)(31696002)(36756003)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFFqTVN6dVBMMldtOEtXeVVmb2p2TUp3SjRaRW5SV0lReGNCQklUU2xsSDlq?= =?utf-8?B?OVpQS3FYYnFxaWYvMHE4eWc4ZFJRdzlYbWQ5Wm52YlMrNkpvK1A2bllEWlVv?= =?utf-8?B?VFVWVUpmVkdNNjdZaEx4UGh3a0M4a0hsLzIwTGMvRTM3RHpJTjd2b3FCUms0?= =?utf-8?B?c0d4S2ErUGVLcHNlODJHVWY5OGEwMURSckxJZFJka3JSZWIwYVcrY0tyN1VX?= =?utf-8?B?b2M4SXpHTjR1Q3daVGVob3BXcFhYMXVabFgxSXRkYllJclgvN2cyMFhIOEhK?= =?utf-8?B?bzJlVVJsZG5TQmlLYm43L0loV1VJR2ZOclNJZm9GOXBUOGtWd2QyNDhFbkFp?= =?utf-8?B?dWpibEIyU09kR2R2eWs4dnczQVBOS3RkSTFYMnlTNVYrL3VUcTNhdkpWLzA5?= =?utf-8?B?OUY2MXlMU3Znb0k4SWRZQktadWtsRXZieHBiUkhZVXQzVUZWc1BKUC8xc0cz?= =?utf-8?B?MDFoQ0lKdlJQekV5SkhEQmIwaGlnVGJjRzhIZGlYak4vWDQ3dktnZFNydW9B?= =?utf-8?B?NlNFOFo4cGdORlQ2R3RlMmNjS2pJcHBvT2pNTW9RdUl6Ym1ObitTY2o0ako1?= =?utf-8?B?UlpWQmlJMkt2a25wT0dQSUxLbkNtWHJuaENGTk5nd0k1b0k1VDA4akdaempW?= =?utf-8?B?blF2YzJVdEtUQTJQUC9hOHdYV0Zza3hDME1JSVVVbEowZURzckdUcWJ3MEpX?= =?utf-8?B?eXVFVUF1aGtnN2c0b3pVTXJUUTU5bFEzTDc5RVIyL1ZIWnQ2R2NLdTY5bG5E?= =?utf-8?B?M2pFODhLczJOZ3YwTFRJck96L1JQL0F5SVEwZ3V0T0ZpWjRWOG81eW9iMzNJ?= =?utf-8?B?a2lubDNlRk5iVFR0ZHdsOGlDVXpLdWRwallSQ25LTGp3bWU1NU51Nlhoc2sy?= =?utf-8?B?RE1pZTZhUnlYdEVwUjFWK0tSQ1dzZUNXYXRvSU9JRGVoOEpLb3JRUXZ2bm95?= =?utf-8?B?WHpaZEFSOXUrY2ZrTURFRTVtS2w1WDdjZHZjYjRHbnQ1VHd0M3psUkpmR2Fr?= =?utf-8?B?M0w2ZjkrRmZFQWgzQmFabWozc3lHYSt3TWNJZXJ1Y0RsU2FRMGVxOTkvaG5M?= =?utf-8?B?TTB2MGZ1N2tFMVA2bGZDcUM2OVNESTBWTlhJVXlIVER6WmdYMWpOZ1k5R2Rm?= =?utf-8?B?NXRac1RxK05KOUtEWm5FVnlpd2h1NlZJL2J6ZWgyVDVxaFNVVktJUGRyVWZY?= =?utf-8?B?UlBGcDlQY2c1RWh5MlNYc2t2NlNhZGc0UEdHeFpEZEFwUHU5TFFQUzYyTUNk?= =?utf-8?B?TDJkVk9IbFkvMm1DSUxqU2hqMC9lWE1HYTdhVTNIRDBCdHkxSm90OHhOT2Fv?= =?utf-8?B?Qmowc3FnRHAxNVNKSUJEU2YvRlpiTVN3ODFYL2Y1aEJyRldXa0RLSTRHRno3?= =?utf-8?B?Q0tONHlCYXlzQ1J6TnNJYVVKTzMzQWd6aEMwbDBUaFpIVEJPZTlRUko3K0dq?= =?utf-8?B?SFF4T1p3YWJQczBPVVFkejgwSzNGcEU0MlZMc0lCMlRnRzVseUpZMkpsV0FN?= =?utf-8?B?RWFkeHdLRU8rNU9qTm9DUHJld3hScitQR3VQNlBaazZmOXQ5YVBNOTRaSkhB?= =?utf-8?B?M1N0UWdWckxnY0Q2Q0RJU3hBSHJ1MFVKL2Z3clZOSlZYSTNKU1ZSb1NYZEFS?= =?utf-8?B?NmZ6cWJxV0tMdHRsSnN3WkppSE1zUXpvZXk4eTZHbWRLV1lINDBid0t5UXVu?= =?utf-8?B?RkFqaG96NFAvNzMyL3l2KzRxTGJzMFZHdGE4V21kc2lRL2hITTZrYXBSeko3?= =?utf-8?B?YkpuTTE2dzhvamcwMFB3ZnVyaGpnNnVoeExXcnpuOFBnLzdtY1lyVXFpckQz?= =?utf-8?B?UTNaMVlUUWdSRGo1T05uWkFubW5jTFN6Um4xWXhzQXJ2UGdsSlZoOTZXMldY?= =?utf-8?B?RFd6Y1hvdmZJMEsxcjBoVUpJc3FHKzdnMGUzc3c5c2dvZUIrWTAycnlkVE92?= =?utf-8?B?VEJPTnBxbEdkU2crMVhRRlgxSThxc2lJNGVhOGl5WlBDOWFZa0hWdS8zV1d1?= =?utf-8?B?bFV1SzMvMDZrU3VvczFTQ2pqYWFtcGFuUjVVK3UvMDIyTHoxNVJ0WkU2WUM1?= =?utf-8?B?UWpxWTFVQjhYci9nMkVKcDFrV2k0REtoTEZURVA2MDNTRjF2V0NHaGJzbEcw?= =?utf-8?B?bmw1WjlqMm9rck5tQ0s2ejFRc1djT01YUk9XYUw0WlpaN1ViTUdmZDZIOUZE?= =?utf-8?B?VjFoNy9VaXM4aGVOQmR0MXFnV0xHYjZsL0NLNUdsenNWeWdrV3Z0MVF0NGtE?= =?utf-8?B?WFBLbE9uSkRWNTQxRjB3bmsyUERRPT0=?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4eea05c1-c3d5-4720-1247-08dbf29519f7 X-MS-Exchange-CrossTenant-AuthSource: CH2PR07MB7222.namprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2023 17:44:01.0192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9P4rKbQ6CFklvaJE1DP7FRN0oWJb3mADv547vb66gbCVasTI/G+H0ubBHs/2CB5ACBBWQI+1NtfkjXoKCV6mmvHeCzyXiI7Gd6XwyUwHIbI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR07MB8241 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/1/23 10:33, Jakub Jelinek wrote: > On Fri, Dec 01, 2023 at 10:04:38AM -0700, Sandra Loosemore wrote: >> Thanks, this looks good to me. I think I also noticed this weird formatting >> in passing recently when I was looking for something else and did not have >> time to track it down myself. > > There is another question. In many cases we just specify types for the > builtin arguments, in other cases types and names with @var{name} syntax, > and in other case with just name. > > @defbuiltin{int __builtin_fpclassify (int, int, int, int, int, ...)} > vs. > @defbuiltin{size_t __builtin_object_size (const void * @var{ptr}, int @var{type})} > vs. > @defbuiltinx{bool __builtin_umull_overflow (unsigned long int a, unsigned long int b, unsigned long int *res)} > and in some cases even just name the arguments and don't specify type: > @defbuiltin{void __builtin_clear_padding (@var{ptr})} > @defbuiltin{@var{type} __builtin_choose_expr (@var{const_exp}, @var{exp1}, @var{exp2})} > > Shall we tweak that somehow? If the argument names are unimportant, perhaps > it is fine to leave that out, but shouldn't we always use @var{...} around > the parameter names when specified? Yup. The Texinfo manual says: "When using @deftypefn command and variations, you should mark parameter names with @var to distinguish these from data type names, keywords, and other parts of the literal syntax of the programming language." > And avoid leaving out the types, use something like > __builtin_clear_padding (@var{type} *@var{ptr}) > or > __builtin_choose_expr (@var{type1} @var{const_exp}, @var{type2} @var{exp1}, @var{type3} @var{exp2}) > ? That would probably be good too. -Sandra