From: David Malcolm <dmalcolm@redhat.com>
To: Qing Zhao <QING.ZHAO@ORACLE.COM>,
Richard Sandiford <richard.sandiford@arm.com>,
Jakub@redhat.com, richard Biener <richard.guenther@gmail.com>
Cc: Qing Zhao via Gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Version 4][PATCH][gcc][PR94230]provide an option to change the size limitation for -Wmisleading-indent
Date: Fri, 24 Apr 2020 18:36:41 -0400 [thread overview]
Message-ID: <c859fa3101f5b354218a57edec881d686b8f1c4b.camel@redhat.com> (raw)
In-Reply-To: <B18B6BD0-0F6C-4AEE-9A79-8C0909887157@ORACLE.COM>
On Fri, 2020-04-24 at 17:22 -0500, Qing Zhao wrote:
> Hi, Dave,
>
> Thanks a lot for the review and comments.
> I just updated the patch with all your suggestions, bootstrapped it
> and run regression test, no any issue.
>
> The newest patch is attached with this email.
>
> Richard/Jakub, please advise on whether I can commit this patch to
> Gcc10?
>
> Thanks a lot.
>
> Qing
>
Thanks Qing. One more wording nit (sorry!)
> + if (!flag_large_source_files)
> + inform (loc,
> + "adding %<-flarge-source-files%> will allow for more"
> + " column-tracking support, at the expense of compilation"
> + " and memory");
^^^^^^^^^^^^^
Please add "time" here i.e.
" time and memory");
Dave
next prev parent reply other threads:[~2020-04-24 22:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 19:55 [PATCH][gcc][PR94230]provide " Qing Zhao
2020-04-08 19:39 ` PING " Qing Zhao
2020-04-15 20:30 ` Fwd: " Qing Zhao
2020-04-21 14:04 ` Richard Sandiford
2020-04-21 15:21 ` David Malcolm
2020-04-21 18:46 ` Richard Sandiford
2020-04-22 14:22 ` Qing Zhao
2020-04-23 14:41 ` [Version 2][PATCH][gcc][PR94230]provide " Qing Zhao
2020-04-23 18:27 ` Richard Sandiford
2020-04-23 19:52 ` Qing Zhao
2020-04-23 21:05 ` [Version 3][PATCH][gcc][PR94230]provide " Qing Zhao
2020-04-23 22:13 ` David Malcolm
2020-04-24 22:22 ` [Version 4][PATCH][gcc][PR94230]provide " Qing Zhao
2020-04-24 22:36 ` David Malcolm [this message]
2020-04-27 14:23 ` Qing Zhao
2020-05-06 18:40 ` Committed [Version 3][PATCH][gcc][PR94230]provide " Qing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c859fa3101f5b354218a57edec881d686b8f1c4b.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=Jakub@redhat.com \
--cc=QING.ZHAO@ORACLE.COM \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).