From: Nathan Sidwell <nathan@acm.org>
To: marxin <mliska@suse.cz>, gcc-patches@gcc.gnu.org
Cc: hubicka@ucw.cz
Subject: Re: [PATCH 5/8] Make gcno more precise about BBs really belonging to a line (PR gcov-profile/79891).
Date: Fri, 28 Apr 2017 11:47:00 -0000 [thread overview]
Message-ID: <c8705838-e707-2b11-534a-52341cbfb2aa@acm.org> (raw)
In-Reply-To: <cf5dbf635f016f40b0b304039aef1a7f82198d9c.1493371589.git.mliska@suse.cz>
On 04/25/2017 09:08 AM, marxin wrote:
> gcc/ChangeLog:
>
> 2017-04-26 Martin Liska <mliska@suse.cz>
>
> PR gcov-profile/79891
> * gcov.c (add_line_counts): Assign BBs to lines just if the BB
> is marked by compiler as living on a line.
> (get_cycles_count): Remove usage of the union.
> (output_intermediate_file): Likewise.
> (find_source): Fix GNU coding style.
> (accumulate_line_counts): Remove old non-all block mode.
> (output_lines): Remove usage of the union.
> * profile.c (output_location): Include all BBs, even if
> belonging to a same line (and file) as a previous BB.
>
> @@ -2269,32 +2262,32 @@ add_line_counts (coverage_t *coverage, function_t *fn)
> block->cycle.arc = NULL;
> block->cycle.ident = ~0U;
>
> + if (!has_any_line)
> + has_any_line = true;
You know, you're allowed to set a true bool to true :)
Could you annotate the testcase with what the original problem was?
I think that'll help a future regression investigator.
otherwise ok.
nathan
--
Nathan Sidwell
next prev parent reply other threads:[~2017-04-28 11:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 9:31 [PATCH 0/8] GCOV improvements marxin
2017-04-28 9:31 ` [PATCH 5/8] Make gcno more precise about BBs really belonging to a line (PR gcov-profile/79891) marxin
2017-04-28 11:47 ` Nathan Sidwell [this message]
2017-04-28 13:06 ` Martin Liška
2017-04-28 9:31 ` [PATCH 2/8] Remove .gcno file when compilation does not success (PR driver/56469) marxin
2017-04-28 12:00 ` Nathan Sidwell
2017-04-28 9:31 ` [PATCH 6/8] Fix format_gcov to not print misleading values (PR gcov-profile/53915) marxin
2017-04-28 11:38 ` Nathan Sidwell
2017-04-28 9:31 ` [PATCH 1/8] gcno file: do not stream block flags (PR gcov-profile/80031) marxin
2017-04-28 11:48 ` Nathan Sidwell
2017-04-28 9:31 ` [PATCH 4/8] Introduce new option -w which shows verbose informations marxin
2017-04-28 11:41 ` Nathan Sidwell
2017-04-28 10:58 ` [PATCH 7/8] Sort options of gcov, gcov-dump and gcov-tool both in --help and documentation marxin
2017-04-28 11:32 ` Nathan Sidwell
2017-04-28 11:25 ` [PATCH 8/8] Enhance documentation of gcov marxin
2017-04-28 11:35 ` Nathan Sidwell
2017-04-29 3:20 ` Martin Sebor
2018-07-22 8:40 ` Gerald Pfeifer
2017-04-28 11:26 ` [PATCH 3/8] Simplify representation of locations of a block marxin
2017-04-28 11:57 ` Nathan Sidwell
2017-04-28 16:40 ` Martin Sebor
2017-04-28 17:48 ` Nathan Sidwell
2017-05-02 15:38 ` [PATCH] Fix documentation and a ctor in gcov.c Martin Liška
2017-05-03 13:20 ` Nathan Sidwell
2017-04-28 19:13 ` [PATCH 3/8] Simplify representation of locations of a block Pedro Alves
2017-04-28 19:46 ` Martin Sebor
2017-04-28 20:07 ` Pedro Alves
2017-04-28 12:03 ` [PATCH 0/8] GCOV improvements Nathan Sidwell
2017-04-28 12:16 ` Martin Liška
2017-04-29 16:31 ` Gerald Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8705838-e707-2b11-534a-52341cbfb2aa@acm.org \
--to=nathan@acm.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).