From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69665 invoked by alias); 28 Apr 2017 11:41:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 69646 invoked by uid 89); 28 Apr 2017 11:41:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=thatll, that'll, investigator X-HELO: mail-yw0-f196.google.com Received: from mail-yw0-f196.google.com (HELO mail-yw0-f196.google.com) (209.85.161.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Apr 2017 11:41:16 +0000 Received: by mail-yw0-f196.google.com with SMTP id u70so4750211ywe.1 for ; Fri, 28 Apr 2017 04:41:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bmaFvmmTLmEU5vDvk+ypkOYmXap5c3b2azwjOo2x9dA=; b=oqnzx4kw54YZNJQhPYMIP5xyPhdPG55N5r1/H2YKOzIGzjYjdWYKKVqKnuwR8zsnMb zTyEpMQj9K6DotnWTaPeRkbOO6GHiIjxxRrYAiYb7yK9DddfaH9q7Sm71e6xDIy0q82t gMs0XiOIlTHNnSlyLs9WfdTjrfxyUpjH+mKWtqRP8uloLEDqqlQYx4OQOngsCwbe50i5 BWerqm94/5CMAEQjkjUmfhBVnAe+3pzP3z2IePhHuodE4YsQSBezJLslBmSpH8cW0jLa dQjlgJqvq2fD7Gvjne1La3iw1u4otsCXT7CmDc57uxm/NmLCx7TtXgjvtZboY5bLQ/mZ AnYA== X-Gm-Message-State: AN3rC/6Pq/uSgAZyGC+YLeXUXuEbRVEL1WRMEGI4d5cb/XFxl5Mstp31 DzbtgLUHQO5/FA== X-Received: by 10.13.221.143 with SMTP id g137mr9297768ywe.326.1493379677442; Fri, 28 Apr 2017 04:41:17 -0700 (PDT) Received: from ?IPv6:2620:10d:c0a3:20fb:f6d0:5ac5:64cd:f102? ([2620:10d:c091:200::b:7639]) by smtp.googlemail.com with ESMTPSA id i136sm2461697ywg.66.2017.04.28.04.41.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Apr 2017 04:41:16 -0700 (PDT) Subject: Re: [PATCH 5/8] Make gcno more precise about BBs really belonging to a line (PR gcov-profile/79891). To: marxin , gcc-patches@gcc.gnu.org Cc: hubicka@ucw.cz References: From: Nathan Sidwell Message-ID: Date: Fri, 28 Apr 2017 11:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg01473.txt.bz2 On 04/25/2017 09:08 AM, marxin wrote: > gcc/ChangeLog: > > 2017-04-26 Martin Liska > > PR gcov-profile/79891 > * gcov.c (add_line_counts): Assign BBs to lines just if the BB > is marked by compiler as living on a line. > (get_cycles_count): Remove usage of the union. > (output_intermediate_file): Likewise. > (find_source): Fix GNU coding style. > (accumulate_line_counts): Remove old non-all block mode. > (output_lines): Remove usage of the union. > * profile.c (output_location): Include all BBs, even if > belonging to a same line (and file) as a previous BB. > > @@ -2269,32 +2262,32 @@ add_line_counts (coverage_t *coverage, function_t *fn) > block->cycle.arc = NULL; > block->cycle.ident = ~0U; > > + if (!has_any_line) > + has_any_line = true; You know, you're allowed to set a true bool to true :) Could you annotate the testcase with what the original problem was? I think that'll help a future regression investigator. otherwise ok. nathan -- Nathan Sidwell