From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2055.outbound.protection.outlook.com [40.107.104.55]) by sourceware.org (Postfix) with ESMTPS id 2C43B3858CDB for ; Wed, 10 Apr 2024 11:10:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2C43B3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2C43B3858CDB Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.55 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712747430; cv=pass; b=rLDweUAnAI+TKl9pRUbXuadxkNjPMc6uHIFWNKqpFrfns/b8h4eWNEPQQ3PVbkgxNIUKJbakQ7o1diMaKCFo6X04iYXL30V3WVH+oo6yihUARrbHKBrR5QPIBmgqXxaCErXlntki7chCGmN7r+rcVfg1+xwIWp8KVOB8lRa0Fa8= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712747430; c=relaxed/simple; bh=cLtWQTuK/tBFOPWRaHU/OtQnYUF2llbmKtKtomvb9Rs=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=NbhfpdIDFpLl0Kq7V4CVsOXSQtE51fo5w/5BaC04ubKZ+yddiyDow06DPQXm63s7CCeIsE9gXLZ49p4rDijhXmbrLUHqhXKNoTnsMTbN17oalfTb/YztdTBoVhs/E9hSxfpe1MDxHiOWDhMttHoiJ+D3s2FfzbbuD8sXjJxdtQQ= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=eRuSU7S+2NBI9Stm3tHK28bCYO0E1y6xSPh/lCQ481yw4xuv32qr2tm3RRmM/rNMmckKQvC4/bi5wL/f7GtO66TBSNum1eaNHpgXBulNSzSe8K9erAe+uWSJ5o8rWE5KQ9IasPX5HlOJnrhPXnP94nXZGxygVH8iD74IuDE7KrKzrcBC0YHYOwuWMKIvWJmFY8lud1aBjmpSGHUmxDGnsTXX23RjjvWfutl944bhQ4SskhKP0z/ZpODvtSbSJIXPvlA6vyVk4ND21bvAaagaSiBlpGpvprAj1z0ZC6alEH/JsjsTBRh9dunPVzZhLsMPQzb+qdiz7jYRxRqWbqYUHg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SgtOiYYNA0ywzT4J9uVNzRaSw+fw67GkSPBDsf1MeSc=; b=L6ekLAq4PrTH7RZQBkKzVS0D1Sk8lafohZNc+vJodbDE5f2c6z2DseBDzXZt49A3In8Dp0Aqv8afmzthZkqmw6uw8tHv1B28JfIdOPrXCnRa3fuYQDBa/KhDB2GpukxOSoTx3S3uPPRteWBfMEEYFDwzdEpIJGCn2dq9aUXaFSOQZ+wFD3X7rTV8t4DU7IUkiJdHlmhn0pcSs/0heJzFi0XRqN4pSkKSdciOvq5UeEi/aMWrOWE7xXqFZk6u3lu5HJho+uwxY9POCMVOhGSQq3yH19fhLlRXc74WjcgryToY62dNl2oj01v5hjqAE0VRJF5F/vKp4SHv1be2E5/G6w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SgtOiYYNA0ywzT4J9uVNzRaSw+fw67GkSPBDsf1MeSc=; b=8mSwEYStCVqPUy7F86nygup1IeqsEGJUeoWgSnkpBVGkbKWkcL6q3DIyJ8vacCeaqB+VIL6nlXO5gAKaq2GombuHBwqIDgeDa13d+GYtZX4Mof9vE7/15sIYU7Ltz6mceB99uzb9ftgzk4Lf7stZnkVCZmn4DBdTx5n+8Wlypr0= Received: from DBBPR09CA0007.eurprd09.prod.outlook.com (2603:10a6:10:c0::19) by GV2PR08MB9349.eurprd08.prod.outlook.com (2603:10a6:150:da::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Wed, 10 Apr 2024 11:10:22 +0000 Received: from DB1PEPF000509E9.eurprd03.prod.outlook.com (2603:10a6:10:c0:cafe::d0) by DBBPR09CA0007.outlook.office365.com (2603:10a6:10:c0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.19 via Frontend Transport; Wed, 10 Apr 2024 11:10:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB1PEPF000509E9.mail.protection.outlook.com (10.167.242.59) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Wed, 10 Apr 2024 11:10:22 +0000 Received: ("Tessian outbound 9d16f63426bd:v300"); Wed, 10 Apr 2024 11:10:22 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1ea998c7fca398ce X-CR-MTA-TID: 64aa7808 Received: from 7274306b44f5.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 79C68536-39D9-4E90-A5EB-5DD4B6CF1C4C.1; Wed, 10 Apr 2024 11:10:11 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7274306b44f5.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 10 Apr 2024 11:10:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CU/1hnieuU2J6gyD+4tmujTXa3A9ZZf27izdmZi/sn/Qll9wR15/yFGx8hyggftYYIndOz7pxxl1nSc2kE7O/Ecw81sX6ccsMEtKvQQAFj+KlL+/pfnk5CKZ2Ouk+9vyuyMw6hpVwsqOFF6RvwrjTC9RgWrqpHBvCUmA5p+RZJXFU9ZYiwLvZRDocAAoSJ1VXw54/iHH09PfqGanH8rB3acrLVmHu9do06VeknfPsdC+kfGlVVgekUan9usBAdGNDlGF+o7Msr4Yh3zsMp9gkidg5NbNNzvcd5qW5SblMtNf4HKDGYFaE15YVCYcR99W8mFbrTLchzBAUTHF/DRXoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SgtOiYYNA0ywzT4J9uVNzRaSw+fw67GkSPBDsf1MeSc=; b=CZqazmidIUprWQRcIGXlfukuk9aOMsujg5VN7Qr4/uWhdN1Nk9ii7flnNWeA3d2/TXzoYXJOhHMMSV3bBepxTNO0ohtZiDtYuWEzKGcVpw/IZYFy88uHMe2g0kxmSsNK07Uj0S6Fc/jp/B4h5VB8cLMf+O67WYj2VF08K579Q2VDYuxqtWZ/Zr4lu9RsZhDc5egt89ZCl6hAnc1IVDqpX0njjartgJG8JwM7YLZRrMHc+eqtvkAc7+zFmOf0CV1wk75Puxk6QwsPywJ4AyGFjLEngQibeXAD+AnQfIcWOPqSS8eJhni5LCCWU57gyV6PHSPRdaBgm42juv4o0+30bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SgtOiYYNA0ywzT4J9uVNzRaSw+fw67GkSPBDsf1MeSc=; b=8mSwEYStCVqPUy7F86nygup1IeqsEGJUeoWgSnkpBVGkbKWkcL6q3DIyJ8vacCeaqB+VIL6nlXO5gAKaq2GombuHBwqIDgeDa13d+GYtZX4Mof9vE7/15sIYU7Ltz6mceB99uzb9ftgzk4Lf7stZnkVCZmn4DBdTx5n+8Wlypr0= Received: from AS8PR08MB6678.eurprd08.prod.outlook.com (2603:10a6:20b:398::8) by AS8PR08MB9623.eurprd08.prod.outlook.com (2603:10a6:20b:618::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 10 Apr 2024 11:10:07 +0000 Received: from AS8PR08MB6678.eurprd08.prod.outlook.com ([fe80::791b:686b:e7b9:be90]) by AS8PR08MB6678.eurprd08.prod.outlook.com ([fe80::791b:686b:e7b9:be90%5]) with mapi id 15.20.7409.042; Wed, 10 Apr 2024 11:10:07 +0000 Date: Wed, 10 Apr 2024 12:10:04 +0100 From: Andrew Carlotti To: gcc-patches@gcc.gnu.org, Richard Earnshaw , richard.sandiford@arm.com Subject: Re: [PATCH 0/5] aarch64: FMV feature list fixes Message-ID: References: <33371799-7353-cd99-3f78-9abe31ad24ec@e124511.cambridge.arm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0269.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::17) To AS8PR08MB6678.eurprd08.prod.outlook.com (2603:10a6:20b:398::8) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6678:EE_|AS8PR08MB9623:EE_|DB1PEPF000509E9:EE_|GV2PR08MB9349:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PpzSRU8lHBV2JR3YIpdiJtXzmCBMvOLX86qk0UEH7OfLhipjCplbC3yoKxUaSbKzzyLEFyL/GcbtVy4kWGWAeXv1MhLxK7Q4xnsEflztXc4yjoUVccMnCLkY2UteVNRuBilzT3o+IqfbEdi8WgaKWAIwHendGGkHFI262Acrwm2T40V8IqNXnNbqicYysPIxqE4sh53C+QkiGMDIx9f6rCO4/I3IsnRq08Ej2OZ1CS9SFv22gAlwY7BzTBnaakmHMYzVK90j/xKkpWxEO8gqQFYSmi5zQnA9LIV+rid89IetLUE7dzhhn9aH5h0riAQAwSzYqNLP4WlZe1wE6IMpTigPMcKZNpDWDylUt9x0msPhj8qFJs93BAFZ9QPmHaLQzuLHwydIw70mV76A4AYIRnm0WtkWTGRHQuicluLYB6SHqUzZXpdHNwobf3osLBvW8DOuWv7hxihAoXm+iLzI9eP6j7isBKA32z+lNY2xf9wBAhQ9gbsnlwckSpuYQMRmZk8Yk+g3+ow7YK7iJMXcjGrD76f6JxnO8hMfz75kK6WHRtgG9JAkjrFPp22Kd5C6jtR7jSPkN3g0q5IB68sdFScGKO4YmblM7OQRpPERNFtAd0SnweB7o8aHL6aeHlsuaB8QTLLC2Nw3rUs7Cw+uzG8WtB+6n237CkLzx3hEcHA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6678.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(376005);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9623 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF000509E9.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 81c8231e-5c11-44bb-39da-08dc594ed09d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ObhyUibo25lruINvsr4b5Fw9qclHEreFyNQU7fUS6GNAmNMnrl/B/K5cU2dsJ3UYZc3n/HkagxRd8kyN/ysLNgHAkHWZHNj0jmI3kKCaIIpzUg4RMVlD4ChibgbeWVkwI9JPaMijfwsUa8gZv/R8rIS+ALtunIzMIYf5xkTRCV49NfESw0LqZV9bViMwEq6wjAOCsbLWu2iJyvi7R46s8bKp9Z3DGvGAmyzlw7ZpJWpDd6A4DFiX0uaFiXwEncuma+RVss20Io1XqhB/MgO8FfmHSlpNRQjw6mFbhnQzwRO+Xr2VBXzyfGpoovO5CjmoR4gXcveoUwvADFO9ag+Miez8FG+HbKvTfwO5TKAGmTsxO58FAYmohY2WGUDqmwZDW8p5W33zi+ZyoSNKcAj0qcAF6z8QDJftaPDP1XxT1BWiiOJU7/yeGe61/uBHiQG1OGxLI/Srg/mpPicEErYt85EAxfAr43KJ+UBQNfumNArhSOFkKMKMDcrLv1Rk1D3jrNUbgSp5UYgjCHNSaYI9ddJCLSWvKd1bF62WihPZU/JQaTe4pOXa+tfBGfLFlLiYa1EEkp8/2VW0RnzcqW0sDp2q/qONjP7MXa08NH/K3F1h4lBxahO6fQfxamiXPnUqBEvwiMVh+hjT9VJ1JfnHfduxypd1FDill7tIv1oy0Bv5YcNB1ExxSYcyqWLF+qHeKZlFAGTOuegk+KtKL9G/8rU4uoZyffiMvmk9aTvE8HMTd4MxSPdg39osbytxvJpB X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(82310400014)(376005)(1800799015)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 11:10:22.1897 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 81c8231e-5c11-44bb-39da-08dc594ed09d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509E9.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9349 X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_DMARC_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 09, 2024 at 04:43:16PM +0100, Richard Sandiford wrote: > Andrew Carlotti writes: > > The first three patches are trivial changes to the feature list to reflect > > recent changes in the ACLE. Patch 4 removes most of the FMV multiversioning > > features that don't work at the moment, and should be entirely uncontroversial. > > > > Patch 5 handles the remaining cases, where there's an inconsistency in how > > features are named in the current FMV specification compared to the existing > > command line options. It might be better to instead preserve the "memtag2", > > "ssbs2" and "ls64_accdata" names for now; I'd be happy to commit either > > version. > > Yeah, I suppose patch 5 leaves things in a somewhat awkward state, > since e.g.: > > -AARCH64_OPT_FMV_EXTENSION("memtag", MEMTAG, (), (), (), "") > +AARCH64_OPT_EXTENSION("memtag", MEMTAG, (), (), (), "") > > -AARCH64_FMV_FEATURE("memtag2", MEMTAG2, (MEMTAG)) > +AARCH64_FMV_FEATURE("memtag", MEMTAG2, (MEMTAG)) > > seems to drop "memtag2" and FEAT_MEMTAG, but keep "memtag" and > FEAT_MEMTAG2. Is that right? That's deliberate. The FEAT_MEMTAG bit in __aarch64_cpu_features is defined to match the definition of FEAT_MTE in the architecture, and likewise for FEAT_MEMTAG2/FEAT_MTE2. However, in Binutils the "+memtag" extension enables both FEAT_MTE and FEAT_MTE2 instructions (although none of the FEAT_MTE2 instructions can be generated from GCC without inline assembly). The FMV specification in the ACLE currently uses names "memtag" and "memtag2" that match the architecture names, but arguably don't match the command line extension names. I'm advocating for that to change to match the extension names in command line options. The LS64 example is definitely an inconsistency, since GCC uses "+ls64" to enable intrinsics for all of the FEAT_LS64/FEAT_LS64_V/FEAT_LS64_ACCDATA intrinsics. There were similar issues with "sha1", "pmull" and "sve2-pmull128", but in these cases their presence architecturally is implied by the presence of the features checked for "sha2", "aes" and "sve2-aes" so it's fine to just delete the ones without command line flags. > Apart from that and the comment on patch 2, the series looks good to me. > > While rechecking aarch64-option-extensions.def against the ACLE list: > it seems that the .def doesn't treat mops as an FMV feature. Is that > deliberate? "mops" was added to the ACLE list later, and libgcc doesn't yet support detecting it. I didn't think it was sensible to add new FMV feature support at this stage. > Thanks, > Richard