From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id CD6103858C60 for ; Wed, 29 Sep 2021 15:55:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD6103858C60 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18TFNjQx017415; Wed, 29 Sep 2021 15:55:07 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3bcg3hmr96-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Sep 2021 15:55:01 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 18TFjgp9178254; Wed, 29 Sep 2021 15:54:48 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam08lp2043.outbound.protection.outlook.com [104.47.74.43]) by aserp3020.oracle.com with ESMTP id 3bceu5n8cg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Sep 2021 15:54:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HJrppgpOYtcoXhGB3YgftIDKVHztqYmQ+D2T0B4EPoYAVERcRhERr0CkBLrhkZvdaNjc1BTLwY3ubxAjFODNMLt2/9QSA1dvMjsSmXgfudbI6nYqbNK9NMiyyVLc/uzv6mlfapZNYt4kq2n8xVK+golebLV5BtD5PqJZO6QDZZtJbSZ9RmNNXa5kBYvkL050r4zecigjBOBytvtXADk4hu1BPJsOz39NJtTJW7zJ6IZCC+SR1g6se4AHF3t5O65jbOg3NcUFOLoBOODmTEywzUJgVurTovjSTGCBztQyX8+WRHPoynU4V2lfUStqEZ8qwHu3mn0tpYApT9Cc5p2DQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ynjSMg+xxaprydFumL4BXXSWZM/Ajd1e+Z0mo0RUeNY=; b=Xppb+DBtccebWi1sIBDpiny5E717pxv9h9/zhTp6eLPDoVQxklvDR7m5zb6g3eG0s+YvnmD6gMpA9fQ6SRuQKkwC8qxBT4R5xXYN+Tp0TGsQ8mddd3nFE+U5wttA5Wy/b2qEwgYjzs8cBIHS2fJT7JjEIFAqO+MMdDMAzqVMthcuTDxWlBNhl7Ljij8KpyCjT9gtrAoX+GBQefdA49VYa+8OnWk5PVgRjJoFxqrpebeyS2RWr5RE0fSVjbQNVxEaQ3z1NFdqyjA+mcbR5SSI2xlzrvQGoa9Ro0XMCVzjTC27QnBP+CyJGFYGH6Pd0FT7g6kjE1XZbwIod3AVTN1CKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CO6PR10MB5792.namprd10.prod.outlook.com (2603:10b6:303:14d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.21; Wed, 29 Sep 2021 15:54:46 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::1180:46c:d426:11b9]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::1180:46c:d426:11b9%6]) with mapi id 15.20.4523.025; Wed, 29 Sep 2021 15:54:46 +0000 Subject: Re: [PATCH] ctf: Do not warn for CTF not supported for GNU GIMPLE To: Richard Biener Cc: GCC Patches References: <1632855067-7525-1-git-send-email-indu.bhagat@oracle.com> From: Indu Bhagat Message-ID: Date: Wed, 29 Sep 2021 08:54:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SA9PR13CA0058.namprd13.prod.outlook.com (2603:10b6:806:22::33) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 Received: from [IPv6:2606:b400:2001:93:8000::1018] (2606:b400:8004:44::1a) by SA9PR13CA0058.namprd13.prod.outlook.com (2603:10b6:806:22::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.9 via Frontend Transport; Wed, 29 Sep 2021 15:54:45 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8e928208-5710-406b-e920-08d9836175da X-MS-TrafficTypeDiagnostic: CO6PR10MB5792: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:247; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bG6bqFwz5gW8uQMyTuT+Za6/XmwuDJrLFO/a5IUkZUvnRGCQz3XeOPyCafikgSrvXktWmjUuRd+CEIeLPtjfIZYKwL3lcYncqu08juEObC4RZ+2QUcVbQIJTSOYXINga0qA3Qx7BuBrZWua57Ksr4k3VRIQX/qwzI3iAyH/+hEt5vkvcjcgI/wf1S23rGKI8JVRDhIMyETeD4jDxAU3bDZVrI6x9cv6ED9V0AAvfGw6CNtfQCJ8gI2TaorsOz5gKhQ9rEzhAjJtne1rzqsLOrmy/HO4vDHMPru1R73w0gE7JwqJvlHveNFcDj60b4Errb2Kv//j3PPwY0hky0kBIIy0BnI+uAd8SllYpfkv5zZvHvhU/f7gBynspxKKsksuLi5T6aCWpaJh6DTy4q31CVGO2nAfRKZToL0/8zM1fzMnmsDbm/TiVCSBYRdMx8xWAKZQZMpnr08TNTNHWaoy6azRUvD6WqC5ODUAAfyziUvxeSzIimeMYScCJRHv58WG1O8sunKV2NX7R3olyqkw8rhgEttlWujp2fpjgk67wLjqJZT4NB8KBeicNvvtRBwk8N2MoHhmXX8t7F6LTRCztiRQRZkJ1vlLOPsaBy9GhmTYzzuxW/f3b5uc1TO8exm3VD6uMJT4FoE4368vUVFZml+qx3EHh5kmhzX6LZY1JGi22lAcSdRkoWdPkJ3Tjr9jTyvTMFLMTeyRF4MAEhhoxFuy1tYjvdDFFqKPP5xKmsGQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38100700002)(66556008)(6916009)(4326008)(53546011)(83380400001)(66946007)(36756003)(66476007)(31696002)(2616005)(6486002)(86362001)(186003)(508600001)(316002)(8936002)(8676002)(6666004)(5660300002)(44832011)(2906002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnJDTUhBR09CWVM4VHZ3a2RkT050UmtBQjRsYTZud05uY3IvdjB2WG1jMWp2?= =?utf-8?B?b0Zma2U1MFRndjVhWWxiMnFrYU1oRlFSRjBXbU1rZzc2cENFOG4rS2p6N0ha?= =?utf-8?B?N2I1cFBneDQzNmxTV2hyM0RodlRaRUhiRlJVQU1sQVZiMHp3ZUxUSTM2TFVR?= =?utf-8?B?YjRIMW1tUitDL3BnRkJEVk1IWVJnQUdGUks1OXUzNXJLV0dTcXdwNm84Yyta?= =?utf-8?B?Slh4RHhia2pxN3NGMkIzK1F6ZkdmMmgvQnllZHRXNnlWT21KV0dUVklsWUpS?= =?utf-8?B?M3FQVDZoOEdEbWxjZk83dFlOc1haVmFKcWt2RFR4ZG43SHROK2x1QklwOTgy?= =?utf-8?B?M1phdlJzZFNIcHpZN0kyUGUzMUNWTnNhQU9xMnJCbTFXenl2b0g3ZjVTM3R3?= =?utf-8?B?MzdmNnVPL1MvcWJZSzVHcDRGQlEzSksxYitKb3BCYUE0YlJvQzhGWjY5TGxV?= =?utf-8?B?SHdxZ3E5VUQ4cU1SV3ZlUXpFT2htQStUaENqSGFWWDl6QWpVSFl2ZG01cWli?= =?utf-8?B?cEtPMmM0N3hSdURSbjdCNUViWUZDNWlGbDR1OEd3Q0JzejFaNkwyVXB4dEhF?= =?utf-8?B?SUo3WHUvVWFNdkVlOHBMNDk5RnNGUjBlSWFKeUpsVS90bVg5dm45N2hiSmp1?= =?utf-8?B?WExTUU41RS94c0pBa09LdnNmSmhaNEFrMGFIajZ0d0ZSdk9aWE5nclh3djJn?= =?utf-8?B?dW1PWUlkVUU2Um9qVk5wK3N1MXJTK1hxSEZuQ2tKZEFZOHBHTEN6R0pIQzBH?= =?utf-8?B?MGlaS0NPY0h6QUZJRG8yTHVoS1VqRURmazk0ejhhTWYzYjNyL1dBSjZHTlV6?= =?utf-8?B?dkRPNnk0MWRkSHJrby8zM1lpQmg2YmoyU0ZIY2c0RkFYeTg2YUJvbWcrVE93?= =?utf-8?B?QlZOR0tpRmFaMUJONWZQY3NyTE1yNFBGeVJaVTRhbEVRa01qY2FsQ1JmdklO?= =?utf-8?B?emVxbGg0UFFkakdLOXU4akxBSlBBK2lhNE02M2NKVVNnQUtRZ3FXdkJjMTky?= =?utf-8?B?VWdla3lEYkNMOUZiUEo1bWJOb0JkeFVzS0tLNkl4ZEw2TC9ScFZ6TzZaSS84?= =?utf-8?B?QWY3eHg5YXl1US9xbEJtdEo1bko5RExpanlFaXErUDI3V24zRVppb3JCK01C?= =?utf-8?B?R3pmbnZiR3YrenFqcVQvKzFudS9iSFd2YjRpSGc4K3VwelBmT3FUOVJPUVVL?= =?utf-8?B?ZUt0TFVMVzArR3RFVmtwY2d5a2JMUDJwTHRmN05GbHI3bDhkNDc3aTBIL21C?= =?utf-8?B?dDh0R0MxUlJJU29tSlNiZUg3ZW4vdU9FV1ZVcDVEM1pSQzJCRzNrK3llTHB5?= =?utf-8?B?dDJ6dkZnRUpLTTk0WGJzbDVURmNDOE1vaWh1QlRGT01Eb1Y5Y0tpb2RHYmht?= =?utf-8?B?TEN4MWJVOENVUHJNTjV2TDBMSTVFTGI5L2hTVUxidXY5bHZtMy9BR2RJUjc2?= =?utf-8?B?ZUV2RFYrWG1sTWNVa2N0WHF1WnhUZFBCb3BGUHRGa1dLdzI3OU9QYTZPTjJB?= =?utf-8?B?WVcwUk1vQUM0UDlVUy8xbXdPRm51UTlaeEZhUnR2QzQ2UmgzZHBRbDdtK3VZ?= =?utf-8?B?TS9TRVVtVk9yMFdxRTNUeFFkRFlYeURhb3NjOTREaWhkNVIzWHJvUUhzWXRP?= =?utf-8?B?WVlXc1YvMnN2dlVIN3JTNHNORC9qTGlmTlZFT09oRjRTOGxkMVNtQkMvTUU5?= =?utf-8?B?ZnJ3WUR1cTlFR1pqSW1TcEllRDc2T2NCVVpOWVVTdDcwbW9PWENsVWpUUVhi?= =?utf-8?B?WEN3WHdCZkpYcGJaRndxL2d0T2I0YVhxREFBUEc4VzVGVUpDK1dFQkJ0VVJD?= =?utf-8?B?c0g1TzFtN3BWUld3VDFtUT09?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e928208-5710-406b-e920-08d9836175da X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 15:54:46.5001 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6nV7j5J6LjdGpu5sYpWoeIEV5+eyepN1lLs6YAMBO8OWGwvNCfuelOHHjeClogHU8AuIGW4OeXzjjudYx+7fUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5792 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10122 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2109290093 X-Proofpoint-GUID: 0FvPGehC7ZE32FL3A54bImFpCE0RiROK X-Proofpoint-ORIG-GUID: 0FvPGehC7ZE32FL3A54bImFpCE0RiROK X-Spam-Status: No, score=-15.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Sep 2021 15:55:14 -0000 On 9/29/21 12:14 AM, Richard Biener wrote: > On Tue, Sep 28, 2021 at 8:52 PM Indu Bhagat via Gcc-patches > wrote: >> >> CTF is supported for C only. Currently, a warning is emitted if the -gctf >> command line option is specified for a non-C frontend. This warning is also >> used by the GCC testsuite framework - it skips adding -gctf to the list of >> debug flags for automated testing, if CTF is not supported for the frontend. >> >> The following warning, however, is not useful in case of LTO: >> >> "lto1: note: CTF debug info requested, but not supported for ‘GNU GIMPLE’ >> frontend" >> >> This patch disables the generation of the above warning for GNU GIMPLE. >> >> Bootstrapped and regression tested on x86_64. >> >> gcc/ChangeLog: >> >> * toplev.c (process_options): Do not warn for GNU GIMPLE. >> --- >> gcc/toplev.c | 12 +++++++----- >> 1 file changed, 7 insertions(+), 5 deletions(-) >> >> diff --git a/gcc/toplev.c b/gcc/toplev.c >> index e1688aa..511a343 100644 >> --- a/gcc/toplev.c >> +++ b/gcc/toplev.c >> @@ -1416,14 +1416,16 @@ process_options (void) >> debug_info_level = DINFO_LEVEL_NONE; >> } >> >> - /* CTF is supported for only C at this time. >> - Compiling with -flto results in frontend language of GNU GIMPLE. */ >> + /* CTF is supported for only C at this time. */ >> if (!lang_GNU_C () >> && ctf_debug_info_level > CTFINFO_LEVEL_NONE) >> { >> - inform (UNKNOWN_LOCATION, >> - "CTF debug info requested, but not supported for %qs frontend", >> - language_string); >> + /* Compiling with -flto results in frontend language of GNU GIMPLE. It >> + is not useful to warn in that case. */ >> + if (!startswith (lang_hooks.name, "GNU GIMPLE")) > > please use in_lto_p instead > > OK with that change. > in_lto_p is set later in lto_init () (when its time for do_compile ()). in_lto_p's updated value is not available at this point in process_options (). >> + inform (UNKNOWN_LOCATION, >> + "CTF debug info requested, but not supported for %qs frontend", >> + language_string); >> ctf_debug_info_level = CTFINFO_LEVEL_NONE; >> } >> >> -- >> 1.8.3.1 >>