* [PATCH] ctf: Do not warn for CTF not supported for GNU GIMPLE
@ 2021-09-28 18:51 Indu Bhagat
2021-09-29 7:14 ` Richard Biener
0 siblings, 1 reply; 4+ messages in thread
From: Indu Bhagat @ 2021-09-28 18:51 UTC (permalink / raw)
To: gcc-patches
CTF is supported for C only. Currently, a warning is emitted if the -gctf
command line option is specified for a non-C frontend. This warning is also
used by the GCC testsuite framework - it skips adding -gctf to the list of
debug flags for automated testing, if CTF is not supported for the frontend.
The following warning, however, is not useful in case of LTO:
"lto1: note: CTF debug info requested, but not supported for ‘GNU GIMPLE’
frontend"
This patch disables the generation of the above warning for GNU GIMPLE.
Bootstrapped and regression tested on x86_64.
gcc/ChangeLog:
* toplev.c (process_options): Do not warn for GNU GIMPLE.
---
gcc/toplev.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/gcc/toplev.c b/gcc/toplev.c
index e1688aa..511a343 100644
--- a/gcc/toplev.c
+++ b/gcc/toplev.c
@@ -1416,14 +1416,16 @@ process_options (void)
debug_info_level = DINFO_LEVEL_NONE;
}
- /* CTF is supported for only C at this time.
- Compiling with -flto results in frontend language of GNU GIMPLE. */
+ /* CTF is supported for only C at this time. */
if (!lang_GNU_C ()
&& ctf_debug_info_level > CTFINFO_LEVEL_NONE)
{
- inform (UNKNOWN_LOCATION,
- "CTF debug info requested, but not supported for %qs frontend",
- language_string);
+ /* Compiling with -flto results in frontend language of GNU GIMPLE. It
+ is not useful to warn in that case. */
+ if (!startswith (lang_hooks.name, "GNU GIMPLE"))
+ inform (UNKNOWN_LOCATION,
+ "CTF debug info requested, but not supported for %qs frontend",
+ language_string);
ctf_debug_info_level = CTFINFO_LEVEL_NONE;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ctf: Do not warn for CTF not supported for GNU GIMPLE
2021-09-28 18:51 [PATCH] ctf: Do not warn for CTF not supported for GNU GIMPLE Indu Bhagat
@ 2021-09-29 7:14 ` Richard Biener
2021-09-29 15:54 ` Indu Bhagat
0 siblings, 1 reply; 4+ messages in thread
From: Richard Biener @ 2021-09-29 7:14 UTC (permalink / raw)
To: Indu Bhagat; +Cc: GCC Patches
On Tue, Sep 28, 2021 at 8:52 PM Indu Bhagat via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> CTF is supported for C only. Currently, a warning is emitted if the -gctf
> command line option is specified for a non-C frontend. This warning is also
> used by the GCC testsuite framework - it skips adding -gctf to the list of
> debug flags for automated testing, if CTF is not supported for the frontend.
>
> The following warning, however, is not useful in case of LTO:
>
> "lto1: note: CTF debug info requested, but not supported for ‘GNU GIMPLE’
> frontend"
>
> This patch disables the generation of the above warning for GNU GIMPLE.
>
> Bootstrapped and regression tested on x86_64.
>
> gcc/ChangeLog:
>
> * toplev.c (process_options): Do not warn for GNU GIMPLE.
> ---
> gcc/toplev.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/gcc/toplev.c b/gcc/toplev.c
> index e1688aa..511a343 100644
> --- a/gcc/toplev.c
> +++ b/gcc/toplev.c
> @@ -1416,14 +1416,16 @@ process_options (void)
> debug_info_level = DINFO_LEVEL_NONE;
> }
>
> - /* CTF is supported for only C at this time.
> - Compiling with -flto results in frontend language of GNU GIMPLE. */
> + /* CTF is supported for only C at this time. */
> if (!lang_GNU_C ()
> && ctf_debug_info_level > CTFINFO_LEVEL_NONE)
> {
> - inform (UNKNOWN_LOCATION,
> - "CTF debug info requested, but not supported for %qs frontend",
> - language_string);
> + /* Compiling with -flto results in frontend language of GNU GIMPLE. It
> + is not useful to warn in that case. */
> + if (!startswith (lang_hooks.name, "GNU GIMPLE"))
please use in_lto_p instead
OK with that change.
> + inform (UNKNOWN_LOCATION,
> + "CTF debug info requested, but not supported for %qs frontend",
> + language_string);
> ctf_debug_info_level = CTFINFO_LEVEL_NONE;
> }
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ctf: Do not warn for CTF not supported for GNU GIMPLE
2021-09-29 7:14 ` Richard Biener
@ 2021-09-29 15:54 ` Indu Bhagat
2021-09-30 7:27 ` Richard Biener
0 siblings, 1 reply; 4+ messages in thread
From: Indu Bhagat @ 2021-09-29 15:54 UTC (permalink / raw)
To: Richard Biener; +Cc: GCC Patches
On 9/29/21 12:14 AM, Richard Biener wrote:
> On Tue, Sep 28, 2021 at 8:52 PM Indu Bhagat via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
>>
>> CTF is supported for C only. Currently, a warning is emitted if the -gctf
>> command line option is specified for a non-C frontend. This warning is also
>> used by the GCC testsuite framework - it skips adding -gctf to the list of
>> debug flags for automated testing, if CTF is not supported for the frontend.
>>
>> The following warning, however, is not useful in case of LTO:
>>
>> "lto1: note: CTF debug info requested, but not supported for ‘GNU GIMPLE’
>> frontend"
>>
>> This patch disables the generation of the above warning for GNU GIMPLE.
>>
>> Bootstrapped and regression tested on x86_64.
>>
>> gcc/ChangeLog:
>>
>> * toplev.c (process_options): Do not warn for GNU GIMPLE.
>> ---
>> gcc/toplev.c | 12 +++++++-----
>> 1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/gcc/toplev.c b/gcc/toplev.c
>> index e1688aa..511a343 100644
>> --- a/gcc/toplev.c
>> +++ b/gcc/toplev.c
>> @@ -1416,14 +1416,16 @@ process_options (void)
>> debug_info_level = DINFO_LEVEL_NONE;
>> }
>>
>> - /* CTF is supported for only C at this time.
>> - Compiling with -flto results in frontend language of GNU GIMPLE. */
>> + /* CTF is supported for only C at this time. */
>> if (!lang_GNU_C ()
>> && ctf_debug_info_level > CTFINFO_LEVEL_NONE)
>> {
>> - inform (UNKNOWN_LOCATION,
>> - "CTF debug info requested, but not supported for %qs frontend",
>> - language_string);
>> + /* Compiling with -flto results in frontend language of GNU GIMPLE. It
>> + is not useful to warn in that case. */
>> + if (!startswith (lang_hooks.name, "GNU GIMPLE"))
>
> please use in_lto_p instead
>
> OK with that change.
>
in_lto_p is set later in lto_init () (when its time for do_compile ()).
in_lto_p's updated value is not available at this point in
process_options ().
>> + inform (UNKNOWN_LOCATION,
>> + "CTF debug info requested, but not supported for %qs frontend",
>> + language_string);
>> ctf_debug_info_level = CTFINFO_LEVEL_NONE;
>> }
>>
>> --
>> 1.8.3.1
>>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ctf: Do not warn for CTF not supported for GNU GIMPLE
2021-09-29 15:54 ` Indu Bhagat
@ 2021-09-30 7:27 ` Richard Biener
0 siblings, 0 replies; 4+ messages in thread
From: Richard Biener @ 2021-09-30 7:27 UTC (permalink / raw)
To: Indu Bhagat; +Cc: GCC Patches
On Wed, Sep 29, 2021 at 5:55 PM Indu Bhagat <indu.bhagat@oracle.com> wrote:
>
> On 9/29/21 12:14 AM, Richard Biener wrote:
> > On Tue, Sep 28, 2021 at 8:52 PM Indu Bhagat via Gcc-patches
> > <gcc-patches@gcc.gnu.org> wrote:
> >>
> >> CTF is supported for C only. Currently, a warning is emitted if the -gctf
> >> command line option is specified for a non-C frontend. This warning is also
> >> used by the GCC testsuite framework - it skips adding -gctf to the list of
> >> debug flags for automated testing, if CTF is not supported for the frontend.
> >>
> >> The following warning, however, is not useful in case of LTO:
> >>
> >> "lto1: note: CTF debug info requested, but not supported for ‘GNU GIMPLE’
> >> frontend"
> >>
> >> This patch disables the generation of the above warning for GNU GIMPLE.
> >>
> >> Bootstrapped and regression tested on x86_64.
> >>
> >> gcc/ChangeLog:
> >>
> >> * toplev.c (process_options): Do not warn for GNU GIMPLE.
> >> ---
> >> gcc/toplev.c | 12 +++++++-----
> >> 1 file changed, 7 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/gcc/toplev.c b/gcc/toplev.c
> >> index e1688aa..511a343 100644
> >> --- a/gcc/toplev.c
> >> +++ b/gcc/toplev.c
> >> @@ -1416,14 +1416,16 @@ process_options (void)
> >> debug_info_level = DINFO_LEVEL_NONE;
> >> }
> >>
> >> - /* CTF is supported for only C at this time.
> >> - Compiling with -flto results in frontend language of GNU GIMPLE. */
> >> + /* CTF is supported for only C at this time. */
> >> if (!lang_GNU_C ()
> >> && ctf_debug_info_level > CTFINFO_LEVEL_NONE)
> >> {
> >> - inform (UNKNOWN_LOCATION,
> >> - "CTF debug info requested, but not supported for %qs frontend",
> >> - language_string);
> >> + /* Compiling with -flto results in frontend language of GNU GIMPLE. It
> >> + is not useful to warn in that case. */
> >> + if (!startswith (lang_hooks.name, "GNU GIMPLE"))
> >
> > please use in_lto_p instead
> >
> > OK with that change.
> >
>
> in_lto_p is set later in lto_init () (when its time for do_compile ()).
>
> in_lto_p's updated value is not available at this point in
> process_options ().
I see - a bit ugly IMHO but I guess the patch is OK then.
Thanks,
Richard.
> >> + inform (UNKNOWN_LOCATION,
> >> + "CTF debug info requested, but not supported for %qs frontend",
> >> + language_string);
> >> ctf_debug_info_level = CTFINFO_LEVEL_NONE;
> >> }
> >>
> >> --
> >> 1.8.3.1
> >>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-30 7:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 18:51 [PATCH] ctf: Do not warn for CTF not supported for GNU GIMPLE Indu Bhagat
2021-09-29 7:14 ` Richard Biener
2021-09-29 15:54 ` Indu Bhagat
2021-09-30 7:27 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).