* [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
[not found] <1688582633587.6.46186@webmail-backend-production-7b8b7bc877-jfhdl>
@ 2024-05-20 14:44 ` Gerald Pfeifer
2024-05-21 6:05 ` Richard Biener
0 siblings, 1 reply; 6+ messages in thread
From: Gerald Pfeifer @ 2024-05-20 14:44 UTC (permalink / raw)
To: Joern Rennecke; +Cc: gcc, gcc-patches
On Wed, 5 Jul 2023, Joern Rennecke wrote:
> I haven't worked with these targets in years and can't really do
> sensible maintenance or reviews of patches for them. I am currently
> working on optimizations for other ports like RISC-V.
I noticed MAINTAINERS was not updated, so pushed the patch below.
Gerald
commit f94598ffaf5affbc9421ff230502357b07c55d9c
Author: Gerald Pfeifer <gerald@pfeifer.com>
Date: Mon May 20 16:43:05 2024 +0200
MAINTAINERS: Update Joern Rennecke's status
This is per his mail to gcc@gcc.gnu.org on 7 Jul 2023.
ChangeLog:
* MAINTAINERS: Move Joern Rennecke from arc and epiphany maintainer
to Write After Approval.
diff --git a/MAINTAINERS b/MAINTAINERS
index 8e0add6bef8..e2870eef2ef 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -56,7 +56,6 @@ aarch64 port Kyrylo Tkachov <ktkachov@gcc.gnu.org>
alpha port Richard Henderson <rth@gcc.gnu.org>
amdgcn port Julian Brown <julian@codesourcery.com>
amdgcn port Andrew Stubbs <ams@baylibre.com>
-arc port Joern Rennecke <gnu@amylaar.uk>
arc port Claudiu Zissulescu <claziss@synopsys.com>
arm port Nick Clifton <nickc@redhat.com>
arm port Richard Earnshaw <richard.earnshaw@arm.com>
@@ -68,7 +67,6 @@ c6x port Bernd Schmidt <bernds_cb1@t-online.de>
cris port Hans-Peter Nilsson <hp@axis.com>
c-sky port Xianmiao Qu <cooper.qu@linux.alibaba.com>
c-sky port Yunhai Shang <yunhai@linux.alibaba.com>
-epiphany port Joern Rennecke <gnu@amylaar.uk>
fr30 port Nick Clifton <nickc@redhat.com>
frv port Nick Clifton <nickc@redhat.com>
frv port Alexandre Oliva <aoliva@gcc.gnu.org>
@@ -634,6 +632,7 @@ Joe Ramsay <joe.ramsay@arm.com>
Rolf Rasmussen <rolfwr@gcc.gnu.org>
Fritz Reese <fritzoreese@gmail.com>
Volker Reichelt <v.reichelt@netcologne.de>
+Joern Rennecke <gnu@amylaar.uk>
Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Tom Rix <trix@redhat.com>
Thomas Rodgers <trodgers@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
2024-05-20 14:44 ` [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany Gerald Pfeifer
@ 2024-05-21 6:05 ` Richard Biener
2024-05-21 13:57 ` Jeff Law
0 siblings, 1 reply; 6+ messages in thread
From: Richard Biener @ 2024-05-21 6:05 UTC (permalink / raw)
To: Gerald Pfeifer; +Cc: Joern Rennecke, gcc, gcc-patches
On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer <gerald@pfeifer.com> wrote:
>
> On Wed, 5 Jul 2023, Joern Rennecke wrote:
> > I haven't worked with these targets in years and can't really do
> > sensible maintenance or reviews of patches for them. I am currently
> > working on optimizations for other ports like RISC-V.
>
> I noticed MAINTAINERS was not updated, so pushed the patch below.
That leaves the epiphany port unmaintained. Should we automatically add such
ports to the list of obsoleted ports?
Richard.
> Gerald
>
>
> commit f94598ffaf5affbc9421ff230502357b07c55d9c
> Author: Gerald Pfeifer <gerald@pfeifer.com>
> Date: Mon May 20 16:43:05 2024 +0200
>
> MAINTAINERS: Update Joern Rennecke's status
>
> This is per his mail to gcc@gcc.gnu.org on 7 Jul 2023.
>
> ChangeLog:
> * MAINTAINERS: Move Joern Rennecke from arc and epiphany maintainer
> to Write After Approval.
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8e0add6bef8..e2870eef2ef 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -56,7 +56,6 @@ aarch64 port Kyrylo Tkachov <ktkachov@gcc.gnu.org>
> alpha port Richard Henderson <rth@gcc.gnu.org>
> amdgcn port Julian Brown <julian@codesourcery.com>
> amdgcn port Andrew Stubbs <ams@baylibre.com>
> -arc port Joern Rennecke <gnu@amylaar.uk>
> arc port Claudiu Zissulescu <claziss@synopsys.com>
> arm port Nick Clifton <nickc@redhat.com>
> arm port Richard Earnshaw <richard.earnshaw@arm.com>
> @@ -68,7 +67,6 @@ c6x port Bernd Schmidt <bernds_cb1@t-online.de>
> cris port Hans-Peter Nilsson <hp@axis.com>
> c-sky port Xianmiao Qu <cooper.qu@linux.alibaba.com>
> c-sky port Yunhai Shang <yunhai@linux.alibaba.com>
> -epiphany port Joern Rennecke <gnu@amylaar.uk>
> fr30 port Nick Clifton <nickc@redhat.com>
> frv port Nick Clifton <nickc@redhat.com>
> frv port Alexandre Oliva <aoliva@gcc.gnu.org>
> @@ -634,6 +632,7 @@ Joe Ramsay <joe.ramsay@arm.com>
> Rolf Rasmussen <rolfwr@gcc.gnu.org>
> Fritz Reese <fritzoreese@gmail.com>
> Volker Reichelt <v.reichelt@netcologne.de>
> +Joern Rennecke <gnu@amylaar.uk>
> Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
> Tom Rix <trix@redhat.com>
> Thomas Rodgers <trodgers@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
2024-05-21 6:05 ` Richard Biener
@ 2024-05-21 13:57 ` Jeff Law
2024-05-21 14:02 ` Paul Koning
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Law @ 2024-05-21 13:57 UTC (permalink / raw)
To: Richard Biener, Gerald Pfeifer; +Cc: Joern Rennecke, gcc, gcc-patches
On 5/21/24 12:05 AM, Richard Biener via Gcc wrote:
> On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer <gerald@pfeifer.com> wrote:
>>
>> On Wed, 5 Jul 2023, Joern Rennecke wrote:
>>> I haven't worked with these targets in years and can't really do
>>> sensible maintenance or reviews of patches for them. I am currently
>>> working on optimizations for other ports like RISC-V.
>>
>> I noticed MAINTAINERS was not updated, so pushed the patch below.
>
> That leaves the epiphany port unmaintained. Should we automatically add such
> ports to the list of obsoleted ports?
Given that epiphany has randomly failed tests for the last 3+ years due
to bugs in its patterns, yes, it really needs to be deprecated.
I tried to fix the worst of the offenders in epiphany.md a few years
back and gave up. Essentially seemingly innocent changes in the RTL
will cause reload to occasionally not see a path to get constraints
satisfied. So a test which passes today, will flip to failing tomorrow
while some other test of tests will go the other way.
jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
2024-05-21 13:57 ` Jeff Law
@ 2024-05-21 14:02 ` Paul Koning
2024-05-21 16:21 ` Jeff Law
0 siblings, 1 reply; 6+ messages in thread
From: Paul Koning @ 2024-05-21 14:02 UTC (permalink / raw)
To: Jeff Law; +Cc: Richard Biener, Gerald Pfeifer, Joern Rennecke, gcc, gcc-patches
> On May 21, 2024, at 9:57 AM, Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
>
> On 5/21/24 12:05 AM, Richard Biener via Gcc wrote:
>> On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer <gerald@pfeifer.com> wrote:
>>>
>>> On Wed, 5 Jul 2023, Joern Rennecke wrote:
>>>> I haven't worked with these targets in years and can't really do
>>>> sensible maintenance or reviews of patches for them. I am currently
>>>> working on optimizations for other ports like RISC-V.
>>>
>>> I noticed MAINTAINERS was not updated, so pushed the patch below.
>> That leaves the epiphany port unmaintained. Should we automatically add such
>> ports to the list of obsoleted ports?
> Given that epiphany has randomly failed tests for the last 3+ years due to bugs in its patterns, yes, it really needs to be deprecated.
>
> I tried to fix the worst of the offenders in epiphany.md a few years back and gave up. Essentially seemingly innocent changes in the RTL will cause reload to occasionally not see a path to get constraints satisfied. So a test which passes today, will flip to failing tomorrow while some other test of tests will go the other way.
Does LRA make that issue go away, or does it not help?
paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
2024-05-21 14:02 ` Paul Koning
@ 2024-05-21 16:21 ` Jeff Law
2024-05-21 16:43 ` Richard Biener
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Law @ 2024-05-21 16:21 UTC (permalink / raw)
To: Paul Koning
Cc: Richard Biener, Gerald Pfeifer, Joern Rennecke, gcc, gcc-patches
On 5/21/24 8:02 AM, Paul Koning wrote:
>
>
>> On May 21, 2024, at 9:57 AM, Jeff Law <jeffreyalaw@gmail.com> wrote:
>>
>>
>>
>> On 5/21/24 12:05 AM, Richard Biener via Gcc wrote:
>>> On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer <gerald@pfeifer.com> wrote:
>>>>
>>>> On Wed, 5 Jul 2023, Joern Rennecke wrote:
>>>>> I haven't worked with these targets in years and can't really do
>>>>> sensible maintenance or reviews of patches for them. I am currently
>>>>> working on optimizations for other ports like RISC-V.
>>>>
>>>> I noticed MAINTAINERS was not updated, so pushed the patch below.
>>> That leaves the epiphany port unmaintained. Should we automatically add such
>>> ports to the list of obsoleted ports?
>> Given that epiphany has randomly failed tests for the last 3+ years due to bugs in its patterns, yes, it really needs to be deprecated.
>>
>> I tried to fix the worst of the offenders in epiphany.md a few years back and gave up. Essentially seemingly innocent changes in the RTL will cause reload to occasionally not see a path to get constraints satisfied. So a test which passes today, will flip to failing tomorrow while some other test of tests will go the other way.
>
> Does LRA make that issue go away, or does it not help?
LRA didn't trivially work on epiphany. I didn't care enough about the
port to try and make it LRA compatible.
jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
2024-05-21 16:21 ` Jeff Law
@ 2024-05-21 16:43 ` Richard Biener
0 siblings, 0 replies; 6+ messages in thread
From: Richard Biener @ 2024-05-21 16:43 UTC (permalink / raw)
To: Jeff Law; +Cc: Paul Koning, Gerald Pfeifer, Joern Rennecke, gcc, gcc-patches
On Tue, May 21, 2024 at 6:21 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
>
> On 5/21/24 8:02 AM, Paul Koning wrote:
> >
> >
> >> On May 21, 2024, at 9:57 AM, Jeff Law <jeffreyalaw@gmail.com> wrote:
> >>
> >>
> >>
> >> On 5/21/24 12:05 AM, Richard Biener via Gcc wrote:
> >>> On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer <gerald@pfeifer.com> wrote:
> >>>>
> >>>> On Wed, 5 Jul 2023, Joern Rennecke wrote:
> >>>>> I haven't worked with these targets in years and can't really do
> >>>>> sensible maintenance or reviews of patches for them. I am currently
> >>>>> working on optimizations for other ports like RISC-V.
> >>>>
> >>>> I noticed MAINTAINERS was not updated, so pushed the patch below.
> >>> That leaves the epiphany port unmaintained. Should we automatically add such
> >>> ports to the list of obsoleted ports?
> >> Given that epiphany has randomly failed tests for the last 3+ years due to bugs in its patterns, yes, it really needs to be deprecated.
> >>
> >> I tried to fix the worst of the offenders in epiphany.md a few years back and gave up. Essentially seemingly innocent changes in the RTL will cause reload to occasionally not see a path to get constraints satisfied. So a test which passes today, will flip to failing tomorrow while some other test of tests will go the other way.
> >
> > Does LRA make that issue go away, or does it not help?
> LRA didn't trivially work on epiphany. I didn't care enough about the
> port to try and make it LRA compatible.
In that case LRA will make the issue go away (the port, that is ...).
Richard.
>
> jeff
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-05-21 16:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1688582633587.6.46186@webmail-backend-production-7b8b7bc877-jfhdl>
2024-05-20 14:44 ` [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany Gerald Pfeifer
2024-05-21 6:05 ` Richard Biener
2024-05-21 13:57 ` Jeff Law
2024-05-21 14:02 ` Paul Koning
2024-05-21 16:21 ` Jeff Law
2024-05-21 16:43 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).