public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Edwin Lu <ewlu@rivosinc.com>, gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com
Subject: Re: [PATCH] RISC-V: Fix C23 (...) functions returning large aggregates [PR114175]
Date: Mon, 18 Mar 2024 21:07:36 -0600	[thread overview]
Message-ID: <c9463224-54cc-428c-a892-6f89b18520a0@gmail.com> (raw)
In-Reply-To: <20240318185454.1314630-1-ewlu@rivosinc.com>



On 3/18/24 12:54 PM, Edwin Lu wrote:
> We assume that TYPE_NO_NAMED_ARGS_STDARG_P don't have any named arguments and
> there is nothing to advance, but that is not the case for (...) functions
> returning by hidden reference which have one such artificial argument.
> This causes gcc.dg/c23-stdarg-[68].c to fail
> 
> Fix the issue by checking if arg.type is NULL as r14-9503-g218d1749612
> explains
> 
> Tested on linux rv64gcv.
> 
> gcc/ChangeLog:
> 
> 	PR target/114175
> 	* config/riscv/riscv.cc (riscv_setup_incoming_varargs): Only skip
> 	riscv_funciton_arg_advance for TYPE_NO_NAMED_ARGS_STDARG_P functions
> 	if arg.type is NULL
OK.  Thanks for taking care of this.

Jeff


  reply	other threads:[~2024-03-19  3:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-18 18:54 Edwin Lu
2024-03-19  3:07 ` Jeff Law [this message]
2024-03-19 16:57   ` [Committed] " Edwin Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9463224-54cc-428c-a892-6f89b18520a0@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=ewlu@rivosinc.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gnu-toolchain@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).