On 12/16/20 3:13 PM, Nikhil Benesch wrote:
> On 12/16/20 2:20 PM, Rainer Orth wrote:
>> Hi Nikhil,
>>
>>> On 12/15/20 3:00 AM, Nikhil Benesch wrote:
>>>> If this patch looks good, I'll submit it upstream tomorrow.
>>>
>>> Assuming no news is good news, I sent
>>> https://go-review.googlesource.com/c/gofrontend/+/278672.
>>
>> sorry for the delay, but unfortunately news is not so good: I get
>>
>> runtime_sysinfo.go:315:18: error: use of undefined type '_ucontext'
>>    315 | type _ucontext_t _ucontext
>>        |                  ^
> 
> No problem, Rainer. I figured there would be some hiccups. The somewhat good news
> is that this error appears to be independent of the patch I sent upstream.
> 
> I suspect what is happening here is that godump sees "typedef ucontext_t struct
> ucontext" and outputs the typedef immediately. Only later does it observe that
> "struct ucontext" is invalid. At that point it is too late to comment out the
> typedef for _ucontext_t.

Oh, wait, Rainer, did you apply *both* solaris-godump.patch and
invalid-dummy.patch? I think if you apply only the former (i.e., only
solaris-godump.patch), which is the only bit I've submitted upstream,
all will be well.

For good measure, I've also fixed the issue in invalid-dummy.patch
and attached a new version. But I'm still not sure whether it is a
worthwhile change, and it's something we can discuss separately from
solaris-godump.patch.

Nikhil