From: Tom de Vries <Tom_deVries@mentor.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Thomas Schwinge <thomas@codesourcery.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: [openacc, testsuite, committed] Fix libgomp.oacc-c-c++-common/{loop-red-g-1,routine-g-1}.c for non-nvidia devices
Date: Thu, 05 Oct 2017 08:34:00 -0000 [thread overview]
Message-ID: <c98b5ec2-3214-6b3f-791a-d6e60c27dd84@mentor.com> (raw)
In-Reply-To: <8d323e0d-9790-2fc0-3ea4-2ae73a7c3064@mentor.com>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
[ was : Re: [openacc, testsuite, committed] Fix
libgomp.oacc-c-c++-common/loop-g-{1,2}.c for non-nvidia devices ]
On 09/28/2017 08:47 AM, Tom de Vries wrote:
> Hi,
>
> this patch makes the test-cases libgomp.oacc-c-c++-common/loop-g-{1,2}.c
> Â work for non-nvidia devices.
>
> For nvidia devices, a vector_length of 32 is required for the test to pass.
>
> For devices with a non-32 forced vector_length, this test-case will fail
> the test for excess errors due to:
> ...
> warning: using vector_length (x), ignoring 32
> ...
>
> Fixed by removing the explicit vector_length setting. For nvidia
> devices, 32 is required, but that's also the forced default, so there's
> no need to be explicit about it.
>
> Committed as obvious.
Committed this similar patch.
Thanks,
- Tom
[-- Attachment #2: 0001-Fix-libgomp.oacc-c-c-common-loop-red-g-1-routine-g-1-.c-for-non-nvidia-devices.patch --]
[-- Type: text/x-patch, Size: 1649 bytes --]
Fix libgomp.oacc-c-c++-common/{loop-red-g-1,routine-g-1}.c for non-nvidia devices
2017-10-05 Tom de Vries <tom@codesourcery.com>
* testsuite/libgomp.oacc-c-c++-common/loop-red-g-1.c (main): Remove
vector_length(32) clause from acc parallel directive.
* testsuite/libgomp.oacc-c-c++-common/routine-g-1.c (main): Same.
---
libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-g-1.c | 2 +-
libgomp/testsuite/libgomp.oacc-c-c++-common/routine-g-1.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-g-1.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-g-1.c
index d241d41..929e01c 100644
--- a/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-g-1.c
+++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-red-g-1.c
@@ -11,7 +11,7 @@ int main ()
int ondev = 0;
int t = 0, h = 0;
-#pragma acc parallel num_gangs(32) vector_length(32) copy(ondev)
+#pragma acc parallel num_gangs(32) copy(ondev)
{
#pragma acc loop gang reduction (+:t)
for (unsigned ix = 0; ix < N; ix++)
diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/routine-g-1.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/routine-g-1.c
index 9d14c3b..b6ab713 100644
--- a/libgomp/testsuite/libgomp.oacc-c-c++-common/routine-g-1.c
+++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/routine-g-1.c
@@ -36,7 +36,7 @@ int main ()
for (ix = 0; ix < N;ix++)
ary[ix] = -1;
-#pragma acc parallel num_gangs(32) vector_length(32) copy(ary) copy(ondev)
+#pragma acc parallel num_gangs(32) copy(ary) copy(ondev)
{
ondev = __builtin_acc_on_device (5);
gang (ary);
prev parent reply other threads:[~2017-10-05 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 6:47 [openacc, testsuite, committed] Fix libgomp.oacc-c-c++-common/loop-g-{1,2}.c " Tom de Vries
2017-10-05 8:34 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c98b5ec2-3214-6b3f-791a-d6e60c27dd84@mentor.com \
--to=tom_devries@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).