From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id E47CD3858D32 for ; Sat, 3 Jun 2023 17:12:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E47CD3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1b026657a6fso28647035ad.0 for ; Sat, 03 Jun 2023 10:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685812365; x=1688404365; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IsW8887BnkMg3cxD+XKiz71c8dx9IBEOSBEvnP1MU4M=; b=CtbZmZBFZLwkmlM2ub+tLyP07xR+NdxvcMvj/SoTWqkhLnA5bBKqwTYKm3TxOyQo8p CT+Ib3tjH2EqpeQjuWskvhDUHh49X51cTOAPT7eL+PguSLaSRG1Zwg0EKXB/K3rfIFpd sY+LVCtoDK+RSxuVbBtt31K3wYrAYTduuKPXe6icFPR8hw9v8KKDDpfYK7PNByo+9L5h xDrxPJDeNZtaQN72b9UipDYgsL1wqX7O6eKOhokg2ZXEA+6OymN628qb2tBDxLVEjBpQ KhLP6Vm0bpHFokzQIKpWlHrl2HXO1HhTa9r3eNFDec57dPtmeeKc/zCnzhT6YfRrZwk8 459A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685812365; x=1688404365; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IsW8887BnkMg3cxD+XKiz71c8dx9IBEOSBEvnP1MU4M=; b=PnCSfLUJ6g+D9Nvt4rPzGgdmu69jg9S8BqEJYK7xpXPfvr2nYw0+ucL9/QSZ9HZCRi dUyJdQSHfWqOb+nha3wEYE+2FNtC6mMywUYf4ej6na6WOB6Lrr9DVNCG0PnbxYjPP7e8 POOZnx6wGrAKq16yEU2FukAgtRaUCCH0YC6RzG+vC8KHCVSoTxIfPCdc+dF+eZAOnmu/ Kb+8txlvEvdSi2e15IbueoGtyaqt+qUv0TQPiJudCHXmiBvONnXRE1ht9LL1q7MPRLfF XVXqCX3i8Y6gMM3aXn8QZpQRucKs9ca6tBpb+cpp9IVoYXikWLMOZVEyjmHiZ2QgkrxL 3Xmg== X-Gm-Message-State: AC+VfDwQhGaUr8243c2x4kP/1r1qTw6vEF/d21YU8pyUAciUCzLKC6ee YYU9zN+WwxEZKOGTUgjxYa8= X-Google-Smtp-Source: ACHHUZ5YqhV/p0Q+dvh5APmyLrJKPXVVE2fglu99yLt7xvRiK5qP+Jk9+O/mEJ0MX7mUcJ1zoJ4tpA== X-Received: by 2002:a17:902:b213:b0:1b0:2f15:e0b3 with SMTP id t19-20020a170902b21300b001b02f15e0b3mr3251386plr.50.1685812364724; Sat, 03 Jun 2023 10:12:44 -0700 (PDT) Received: from ?IPV6:2607:fb90:469:b40a:c15c:6a92:5516:c5a5? ([2607:fb90:469:b40a:c15c:6a92:5516:c5a5]) by smtp.gmail.com with ESMTPSA id f21-20020a170902ab9500b00192aa53a7d5sm3444305plr.8.2023.06.03.10.12.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Jun 2023 10:12:44 -0700 (PDT) Message-ID: Date: Sat, 3 Jun 2023 11:12:41 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/2] [RISC-V] fix cfi issue in save-restore. Content-Language: en-US To: Fei Gao , gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, palmer@dabbelt.com, sinan.lin@linux.alibaba.com, jiawei@iscas.ac.cn References: <20230602104247.26454-1-gaofei@eswincomputing.com> From: Jeff Law In-Reply-To: <20230602104247.26454-1-gaofei@eswincomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/2/23 04:42, Fei Gao wrote: > This patch fixes a cfi issue introduced by > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=60524be1e3929d83e15fceac6e2aa053c8a6fb20 > > Test code: > char my_getchar(); > float getf(); > int test_f0() > { > int s0 = my_getchar(); > float f0 = getf(); > int b = my_getchar(); > return f0+s0+b; > } > > cflags: -g -Os -march=rv32imafc -mabi=ilp32f -msave-restore -mcmodel=medlow > > before patch: > test_f0: > ... > .cfi_startproc > call t0,__riscv_save_1 > .cfi_offset 8, -8 > .cfi_offset 1, -4 > .cfi_def_cfa_offset 16 > ... > addi sp,sp,-16 > .cfi_def_cfa_offset 32 > > ... > > addi sp,sp,16 > .cfi_def_cfa_offset 0 // issue here > ... > tail __riscv_restore_1 > .cfi_restore 8 > .cfi_restore 1 > .cfi_def_cfa_offset -16 // issue here > .cfi_endproc > > after patch: > test_f0: > ... > .cfi_startproc > call t0,__riscv_save_1 > .cfi_offset 8, -8 > .cfi_offset 1, -4 > .cfi_def_cfa_offset 16 > ... > addi sp,sp,-16 > .cfi_def_cfa_offset 32 > > ... > > addi sp,sp,16 > .cfi_def_cfa_offset 16 // corrected here > ... > tail __riscv_restore_1 > .cfi_restore 8 > .cfi_restore 1 > .cfi_def_cfa_offset 0 // corrected here > .cfi_endproc > > gcc/ChangeLog: > > * config/riscv/riscv.cc (riscv_expand_epilogue): fix cfi issue with correct offset. I fixed a trivial whitespace problem, rewrapped the ChangeLog and pushed this patch to the trunk. Please consider adding a testcase for this bug to the testsuite. jeff