From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id B330B3857BB6 for ; Sun, 10 Jul 2022 01:45:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B330B3857BB6 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.52] (unknown [10.20.4.52]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9DxP9MmL8pi0R8UAA--.9418S2; Sun, 10 Jul 2022 09:45:11 +0800 (CST) Subject: Re: [PATCH v3] loongarch: fix mulsidi3_64bit instruction To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: Chenghua Xu , Wang Xuerui References: <243f46dcbef8c089e40e3860c50f5cf2f2699af8.camel@xry111.site> From: Lulu Cheng Message-ID: Date: Sun, 10 Jul 2022 09:45:10 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <243f46dcbef8c089e40e3860c50f5cf2f2699af8.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID: AQAAf9DxP9MmL8pi0R8UAA--.9418S2 X-Coremail-Antispam: 1UD129KBjvdXoW5Kw47uw45CF18GFW8AFyrZwb_yoWxXFcEqF 17AwnrCw4UAF4aqFsxtF15Gw17Ga9rWFyYvFWqgr4xAa4DZr4rGr1DZa4xAw47KFyF9rs8 KFW3JF9Ivas2qjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbIAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr1j6F 4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcVAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCYjI0SjxkI62AI1cAE67vI Y487MxkIecxEwVCm-wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s 026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_ JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20x vEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280 aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyT uYvjfU5WlkUUUUU X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jul 2022 01:45:19 -0000 在 2022/7/9 上午10:56, Xi Ruoyao 写道: > v3: Relax scan-assembler pattern in test case mulw_d_w.c. It's because > multiplication is Abelian and the compiler may switch the order of > operands in the future. > -- >8 -- > > (mult (sign_extend:DI rj:SI) (sign_extend:DI rk:SI)) should be > "mulw.d.w", not "mul.d". > > gcc/ChangeLog: > > * config/loongarch/loongarch.md (mulsidi3_64bit): Use mulw.d.w > instead of mul.d. > > gcc/testsuite/ChangeLog: > > * gcc.target/loongarch/mulw_d_w.c: New test. > * gcc.c-torture/execute/mul-sext.c: New test. > --- I think there is no problem with this modification. Thankes!