From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by sourceware.org (Postfix) with ESMTPS id 686B33AA9402 for ; Tue, 2 May 2023 20:18:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 686B33AA9402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pl1-x644.google.com with SMTP id d9443c01a7336-1ab0c697c84so9511435ad.3 for ; Tue, 02 May 2023 13:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1683058718; x=1685650718; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oSXQ6M5Ng+YXU6cDXqH7Xj6iVOVhUTxHOA+FleyHkuk=; b=jeGBhlKj2GZjAiHglFYlww+9ELn6bF6sT9ztB8beoaDonjJmHGfYv6aPyPIqbEZsvB YZ/QINzJa6k3zBIM8NWk6YDvac5UI1NhhnpyZdLWdyWyB8O1NfyQBLfwFzCB81v0Tld1 7lhcs0MNHH6toYRQeu5Hcn40TNbqQ3EkKZGPkiZBOmdcsbKE6WlTbGT3TjTz3pzAAIRb 6yQkEo32x5zx537Tag01AbeHdvbRuJ9p8pckRBQgQnau7jxHsKLaWNwLWSdwJ/BCwOok X13gAGrhEEGimAW7kFwo6f/X+amME10EDO/cN+/K5kow0sCsh9FoOaW1R8YrAowjQ2wf nnMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683058718; x=1685650718; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oSXQ6M5Ng+YXU6cDXqH7Xj6iVOVhUTxHOA+FleyHkuk=; b=eNildDDGIgb5jH8AO+4LaQAR3rWN6w28jHQIc6O7byYA1zKY398r+14yTDSD3wYOBm vRjuLDnMBq2r8r7eYpcZgepOcgLNlUMqQ2pz00YOoz2epfM1SY+//rspM9zkw1CG55dg lBojjL2jYUXWlB2bOkcoXFjfDi/tJY97lolprBVr/TWvsjcYq5lae7t9UkII7xRKDUL7 N1xd58JIghYEOqqatdSN0WJ/WOAZJ8akXm1oHMQJDYkHRsvVuzxD8GPER/5+iECrwJ0Z MmgFuYRI8iJcXhDku7aj9BfufhLdwtQRk1qvKwU/3yTvq5ai1lRG0dSuUCnB4L2q7Svn 5q7w== X-Gm-Message-State: AC+VfDydmKtdYLqikH7/bcBqzeC4l1nn0WjXeCjA/YO9K0dfZRnQvVFk cGYOke1lOIyP/VefFU4QmOKiwA== X-Google-Smtp-Source: ACHHUZ5ulANO9LKY9oz23TU0APSLFYImQs6ta7iW7VbfFQo35RzLzSJuNz2sA2EVPRbkvFT8vK+wKg== X-Received: by 2002:a17:903:283:b0:1aa:e739:4092 with SMTP id j3-20020a170903028300b001aae7394092mr13261497plr.52.1683058718412; Tue, 02 May 2023 13:18:38 -0700 (PDT) Received: from [10.0.17.156] ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id u7-20020a170903124700b001a260b5319bsm6769255plh.91.2023.05.02.13.18.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 13:18:38 -0700 (PDT) Message-ID: Date: Tue, 2 May 2023 13:18:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: [Committed 06/11] RISC-V: Strengthen atomic stores Content-Language: en-US To: Jeff Law , gcc-patches@gcc.gnu.org Cc: palmer@rivosinc.com, gnu-toolchain@rivosinc.com, vineetg@rivosinc.com, andrew@sifive.com, kito.cheng@sifive.com, dlustig@nvidia.com, cmuellner@gcc.gnu.org, andrea@rivosinc.com, hboehm@google.com References: <20230414170942.1695672-1-patrick@rivosinc.com> <20230427162301.1151333-1-patrick@rivosinc.com> <20230427162301.1151333-7-patrick@rivosinc.com> From: Patrick O'Neill In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/28/23 10:40, Jeff Law wrote: > > > On 4/27/23 10:22, Patrick O'Neill wrote: >> This change makes atomic stores strictly stronger than table A.6 of the >> ISA manual. This mapping makes the overall patchset compatible with >> table A.7 as well. >> >> 2023-04-27 Patrick O'Neill >> >>     PR 89835 > Should be "PR target/89835" > >> >> gcc/ChangeLog: >> >>     * config/riscv/sync.md: > Needs some text here :-) > > > I'm not objecting to this patch, but I think we've got an option > question about whether or not this approach is too expensive for > existing or soon arriving implementations. > > If the decision on that topic is to just pay the cost, then this patch > is fine.  If we decide to make compatibility optional to avoid the > additional cost, then this will need suitable adjustments. > > Jeff Acked in Patchworks meeting: https://inbox.sourceware.org/gcc-patches/c53ac2b2-4edf-34c6-a935-3b31644c9864@rivosinc.com/ Updated changelog and committed:     PR target/89835 gcc/ChangeLog:     * config/riscv/sync.md (atomic_store): Use simple store     instruction in combination with fence(s). gcc/testsuite/ChangeLog:     * gcc.target/riscv/pr89835.c: New test. Patrick