From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-356893-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 1695 invoked by alias); 2 Dec 2013 20:35:37 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 1685 invoked by uid 89); 2 Dec 2013 20:35:36 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=1.7 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RDNS_NONE,SPF_PASS autolearn=no version=3.3.2
X-HELO: mail-bk0-f50.google.com
Received: from Unknown (HELO mail-bk0-f50.google.com) (209.85.214.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 02 Dec 2013 20:35:34 +0000
Received: by mail-bk0-f50.google.com with SMTP id e11so5652000bkh.37        for <gcc-patches@gcc.gnu.org>; Mon, 02 Dec 2013 12:35:25 -0800 (PST)
X-Received: by 10.205.25.199 with SMTP id rj7mr2142590bkb.39.1386016525256;        Mon, 02 Dec 2013 12:35:25 -0800 (PST)
Received: from [192.168.178.20] (p54958496.dip0.t-ipconnect.de. [84.149.132.150])        by mx.google.com with ESMTPSA id j6sm65647937bki.17.2013.12.02.12.35.24        for <multiple recipients>        (version=TLSv1 cipher=RC4-SHA bits=128/128);        Mon, 02 Dec 2013 12:35:24 -0800 (PST)
User-Agent: K-9 Mail for Android
In-Reply-To: <20131202191916.GH9986@redhat.com>
References: <20130226182733.GG25197@redhat.com> <Pine.LNX.4.64.1302262315110.339@digraph.polyomino.org.uk> <20130227095625.GA15445@redhat.com> <CAFiYyc3oPMBH+KYFs=_5xcOX3_DVcZZRE-HaPs3rxu4XEZ4O1Q@mail.gmail.com> <Pine.LNX.4.64.1302271737240.14086@digraph.polyomino.org.uk> <CAFiYyc3L3b6uk+2Sh4wSg30S-8AdNNFQRPojtfSsF++1L1f3zA@mail.gmail.com> <20130305160621.GG28076@redhat.com> <20130313125702.GF18923@redhat.com> <CAFiYyc1-Z2GyG53+CDACc4afy7X2bCXzCbKKRhtTLZeFmMxGmQ@mail.gmail.com> <20131202164033.GF9986@redhat.com> <20131202191916.GH9986@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH] Fix PR56344
From: Richard Biener <richard.guenther@gmail.com>
Date: Mon, 02 Dec 2013 20:35:00 -0000
To: Marek Polacek <polacek@redhat.com>
CC: "Joseph S. Myers" <joseph@codesourcery.com>,GCC Patches <gcc-patches@gcc.gnu.org>
Message-ID: <c9f53694-84a1-4975-aed7-b5c305d1f2ee@email.android.com>
X-IsSubscribed: yes
X-SW-Source: 2013-12/txt/msg00131.txt.bz2

Marek Polacek <polacek@redhat.com> wrote:
>On Mon, Dec 02, 2013 at 05:40:33PM +0100, Marek Polacek wrote:
>> On Mon, Dec 02, 2013 at 04:01:05PM +0100, Richard Biener wrote:
>> > On Wed, Mar 13, 2013 at 1:57 PM, Marek Polacek <polacek@redhat.com>
>wrote:
>> > > Ping.
>> > 
>> > Ok.  (yay, oldest patch in my review queue ...)
>> 
>> ;) thanks.  Just to be sure, did you mean to ok this patch (that is,
>> the one with HOST_BITS_PER_INT)?

Yes, thanks,
Richard.

>> Bootstrap/regtest in progress.
>> 
>> 2013-12-02  Marek Polacek  <polacek@redhat.com>
>> 
>> 	PR middle-end/56344
>> 	* calls.c (expand_call): Disallow passing huge arguments
>> 	by value.
>> 
>> --- gcc/calls.c.mp4	2013-12-02 17:12:18.621057873 +0100
>> +++ gcc/calls.c	2013-12-02 17:32:35.523684716 +0100
>> @@ -3047,6 +3047,15 @@ expand_call (tree exp, rtx target, int i
>>  	    {
>>  	      rtx before_arg = get_last_insn ();
>>  
>> +	      /* We don't allow passing huge (> 2^30 B) arguments
>> +	         by value.  It would cause an overflow later on.  */
>> +	      if (adjusted_args_size.constant
>> +		  >= (1 << (HOST_BITS_PER_INT - 1)))
>
>Surely I meant to use "HOST_BITS_PER_INT - 2" here.
>
>	Marek