Re: [PATCH] testsuite, asan, hwsan: Add libstdc++ deps where required.

[Jeff Law <jeffreyalaw@gmail.com>]

On 1/30/24 03:30, Iain Sandoe wrote:
> tested on i686, x86_64 (and aarch64) Darwin, x86_64, aarch64 Linux,
> OK for trunk?
> thanks
> Iain
> 
> --- 8< ---
> 
> We use the shared asan/hwasan from both C,C++,D and Fortran.
> The sanitizer libraries link to libstdc++.
> 
> When we are using the C/gdc/gfortran driver, and the target might
> require a path to the libstdc++ (e.g. for handing -static-xxxx or
> for embedded runpaths), we need to add a suitable option (or we get
> fails at execution time because of the missing paths).
> 
> Conversely, we do not want to add multiple instances of these
> paths (since that leads to failures on tools that report warnings
> for duplicate runpaths).
> 
> This patch modifies the _init function to allow a single parameter
> that determines whether the *asan_init should add a path for
> libstdc++ (yes for C driver, no for C++ driver).
> 
> gcc/testsuite/ChangeLog:
> 
> 	* g++.dg/asan/asan.exp: Add a parameter to init to say that
> 	we expect the C++ driver to provide paths for libstdc++.
> 	* g++.dg/hwasan/hwasan.exp: Likewise
> 	* gcc.dg/asan/asan.exp: Add a parameter to init to say that
> 	we need a path added for libstdc++.
> 	* gcc.dg/hwasan/hwasan.exp: Likewise.
> 	* gdc.dg/asan/asan.exp: Likewise.
> 	* gfortran.dg/asan/asan.exp: Likewise.
> 	* lib/asan-dg.exp: Handle a single parameter to init that
> 	requests addition of a path to libstdc++ to link flags.
> 	* lib/hwasan-dg.exp: Likewise.
OK.  I don't think we really need to wait for the sanitizer folks to 
chime in.  This is just getting the link bits right, not twiddling the 
sanitizer itself.

jeff