From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id D739A3858C78 for ; Wed, 28 Feb 2024 17:58:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D739A3858C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D739A3858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709143103; cv=none; b=T5whzXhhSt800kPJt6UdwIXsOnOs+DTwrMvSTl4+MWdRYkF1BZamCyY7OFS0YleOJnZPEA/pAbibmKDuh9LLQq5uUH7jq/YvWvTfs+Ak/990TrHj5icOCrP1LE6wDS7/CaZa/0LHhuUSItPUqpK1AzvHdoeqOqS2zCVBKo2rK7U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709143103; c=relaxed/simple; bh=vJp7UOACEJApb23LyUSu1OfydQmyN4Oix78j+BAfKIY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=alrwWpDGrt5d8U3iog4DT9P67JFqxT5CEBWzynPR0RJKPM2fMVO5xNHGjx5Cf6vzSfPnhHgstEC9AFm0YDbXtcCDmOw8mFT7SxWG56o/fy/rDKWShWxmiOVCyGlRVJPbL5NgKdGQZyPVCS7oKhPfBcvJ2v8O2ITkfhcUOZiDyCo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41SHvhLv013855; Wed, 28 Feb 2024 17:58:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=LZ0Tq0Dp01tL0ZoOr28fm4lGYaqnWssaTLcJPWuOOkY=; b=jYtvrVX61nAKeOeOecfmFmL7waTUXiYHQeDTn8Ao+4pwJtFtSZxaRsF+9uAu05KqzTNS 2lkhLt8ECs/Np9L1L8FtUUUuC312tGhiCb2EGEaejFSmkuy8uSbe/96TVlsZzf1Xncbu OGffaT2+wM2HxW4bhbRTBG1pxKm5dAW5U2/M/rIw4oA7Xu55UkWDufD0cMT+8Ew/mgXj wbyC0tpR1OcFsP/VXkPfuAnwAzV/jCgh7CAGiVrBy/84y1x7+p9IDgLBI25UBqserFvW QOATtv/9auwcKRI6+fUGiWcOxJTWOT+ghGJQZ3nDU6334Wla6zqgHw34JLsqaJIUbW0M +w== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wj9ph00uw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Feb 2024 17:58:20 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41SHBSNs021345; Wed, 28 Feb 2024 17:58:20 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3wfusp7ynp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Feb 2024 17:58:20 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41SHwGeQ33227366 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Feb 2024 17:58:19 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 995005805E; Wed, 28 Feb 2024 17:58:16 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 275825805C; Wed, 28 Feb 2024 17:58:16 +0000 (GMT) Received: from [9.61.160.201] (unknown [9.61.160.201]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 28 Feb 2024 17:58:16 +0000 (GMT) Message-ID: Date: Wed, 28 Feb 2024 11:58:15 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] rs6000: Don't allow immediate value in the vsx_splat pattern [PR113950] Content-Language: en-US To: Segher Boessenkool Cc: jeevitha , GCC Patches , "Kewen.Lin" , Michael Meissner References: <7faaa8f2-d706-4f6a-811f-103b74f2de8a@linux.vnet.ibm.com> <17e8b572-e9c1-44f6-aff8-b14cda8321f9@linux.vnet.ibm.com> <20240227124008.GS19790@gate.crashing.org> <9c1fcbdd-3fb9-4e37-ab26-96c1307f333c@linux.ibm.com> <20240228143134.GT19790@gate.crashing.org> From: Peter Bergner In-Reply-To: <20240228143134.GT19790@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: fLNvvvB79MM8P3I_-7ydT5oJqVnAOU9J X-Proofpoint-ORIG-GUID: fLNvvvB79MM8P3I_-7ydT5oJqVnAOU9J X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-28_08,2024-02-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 mlxscore=0 mlxlogscore=590 priorityscore=1501 phishscore=0 suspectscore=0 adultscore=0 clxscore=1015 malwarescore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402280142 X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/28/24 8:31 AM, Segher Boessenkool wrote: > On Tue, Feb 27, 2024 at 04:50:02PM -0600, Peter Bergner wrote: >> So it seems you're not NAKing the use of splat_input_operand, but >> just that it needs more explanation in the git log entry, correct? > > I NAK the patch. _Of course_ there needs to be *something* done, there > is a bug after all, it needs to be fixed. > > But no, there are big questions about if splat_input_operand is correct > as well. This needs to be justified in the patch submission. Ok, then Jeevitha, repost the patch with the s/op1/operands[1]/ only change. Jeevitha has already bootstrapped and regtested that change and it does fix the bug. Clearly, the splat_input_operand change needs more discussion and would be a follow-on patch...if we decide to do it at all. Peter