From: Joseph Myers <joseph@codesourcery.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/2] [c] Fix PR 101364: ICE after error due to diagnose_arglist_conflict not checking for error
Date: Mon, 16 Oct 2023 21:38:14 +0000 [thread overview]
Message-ID: <ca8a5b-541e-a8b2-49e6-ea2dfbc16055@codesourcery.com> (raw)
In-Reply-To: <20231015011648.1608638-2-pinskia@gmail.com>
On Sat, 14 Oct 2023, Andrew Pinski wrote:
> When checking to see if we have a function declaration has a conflict due to
> promotations, there is no test to see if the type was an error mark and then calls
> c_type_promotes_to. c_type_promotes_to is not ready for error_mark and causes an
> ICE.
>
> This adds a check for error before the call of c_type_promotes_to.
>
> OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.
OK.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2023-10-16 21:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 1:16 [PATCH 1/2] Fix ICE due to c_safe_arg_type_equiv_p not checking for error_mark node Andrew Pinski
2023-10-15 1:16 ` [PATCH 2/2] [c] Fix PR 101364: ICE after error due to diagnose_arglist_conflict not checking for error Andrew Pinski
2023-10-16 21:38 ` Joseph Myers [this message]
2023-10-16 21:38 ` [PATCH 1/2] Fix ICE due to c_safe_arg_type_equiv_p not checking for error_mark node Joseph Myers
2023-10-16 21:40 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca8a5b-541e-a8b2-49e6-ea2dfbc16055@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).