From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Richard.Earnshaw@foss.arm.com>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by sourceware.org (Postfix) with ESMTP id D98283858D28
 for <gcc-patches@gcc.gnu.org>; Thu, 21 Jul 2022 11:09:47 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D98283858D28
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1AD121042;
 Thu, 21 Jul 2022 04:09:48 -0700 (PDT)
Received: from [10.57.10.55] (unknown [10.57.10.55])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 75DD33F70D;
 Thu, 21 Jul 2022 04:09:46 -0700 (PDT)
Message-ID: <ca8df88d-2a61-cc3b-1c7a-d4be9440cf7a@foss.arm.com>
Date: Thu, 21 Jul 2022 12:09:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 8/12 V3] arm: Introduce multilibs for PACBTI target feature
Content-Language: en-GB
To: Andrea Corallo <andrea.corallo@arm.com>
Cc: Richard Earnshaw <Richard.Earnshaw@arm.com>, nd <nd@arm.com>,
 Andrea Corallo via Gcc-patches <gcc-patches@gcc.gnu.org>
References: <gkrmtg5wqik.fsf@arm.com> <gkro80lv8ul.fsf@arm.com>
 <gkrsfooa7j2.fsf_-_@arm.com>
 <075cc158-d681-65b9-4d87-22c8800661fd@foss.arm.com>
 <fe121e75-d7c1-2ba7-ab5d-bca8058cd36a@foss.arm.com>
 <gkrr12e96re.fsf_-_@arm.com>
From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
In-Reply-To: <gkrr12e96re.fsf_-_@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3490.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Jul 2022 11:09:48 -0000



On 21/07/2022 10:04, Andrea Corallo via Gcc-patches wrote:
> Richard Earnshaw <Richard.Earnshaw@foss.arm.com> writes:
> 
> [...]
> 
>>> The documentation mentions -mbranch-protection=standard+leaf, so
>>> you're missing a mapping for that.
>>> OK with that change.
>>> R.
>>
>> Oh, and please add some tests to gcc/testsuite/gcc.target/arm/multilib.exp
>>
>> R.
> 
> Hi Richard,
> 
> thanks, here the updated patch.
> 
> PS I've also added three mlibarch -> march matches that were missing.
> 
> BR
> 
>    Andrea
> 

+MULTILIB_REQUIRED	+= 
mthumb/march=armv8.1-m.main+pacbti+fp/mbranch-protection=standard/mfloat-abi=hard
+MULTILIB_REQUIRED	+= 
mthumb/march=armv8.1-m.main+pacbti+fp.dp/mbranch-protection=standard/mfloat-abi=softfp
+MULTILIB_REQUIRED	+= 
mthumb/march=armv8.1-m.main+pacbti+fp.dp/mbranch-protection=standard/mfloat-abi=hard
+MULTILIB_REQUIRED	+= 
mthumb/march=armv8.1-m.main+pacbti+mve/mbranch-protection=standard/mfloat-abi=hard
+
+
  # Arch Matches
  MULTILIB_MATCHES	+= march?armv6s-m=march?armv6-m

Just one blank line between sections.

Otherwise OK.

R.