From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 4C2063858D28 for ; Fri, 22 Mar 2024 13:35:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4C2063858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4C2063858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711114529; cv=none; b=XhIa/8ssQJn60qi8LDa8yq/YD0TxDKvn9WSje1ehpZ6pe4q6ETEg9ppMwY5a5CQLu4SJ2XVwWKprPMN2nsTm2TmbK11Pw84DjX8UUkEph//BTe6xSHZaJ4SSZFrUyukK4euRv7yO6VpC2caqIkSMlgUcKNJfMi0Om/qq3wRCZlQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711114529; c=relaxed/simple; bh=KggMT1p4oxapUVb/UGmLtzS1779wv6RmkLZyoXcyRUs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=V6aWy0/N3ErBuDeWNxaqxn0Nt3LQJYWy2IaDC4PBvWle1GBBbNd9GJTeO/xhMof3dZ3oQ3DDBdrp/4ms0SC/LkwsjrBf5DEA77FPkVyJFKvDazEJ1Vp4ej7ICDStlBvox5t4XGJeT2QLXbfDEWHhpgj3d89rnUrJUmPhtjMFHHQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ot1-x331.google.com with SMTP id 46e09a7af769-6e68d358974so1016475a34.3 for ; Fri, 22 Mar 2024 06:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711114518; x=1711719318; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Yt8fmMq2uI75U4REa9Iz48QxXGz42nA7SAkZWB+B/Ig=; b=ECELM0EqC2IRGi6dBq/HEz9sExgenHzZiHL4mIXXhZzt0igMghVqGI9L5ZQ1RfrsXv nLCU0+0U4HGbda068uI+fZ8YDAjEf7dKsPIlfFwwwn2M2W3qJHveW7aH2wuBIva8G4D2 FeccaTjGB+w2ard5/1J22fZnhboteExWAvVwRiS949S9AGjufu9qJTfPUeS7XTU1k0c+ TGFMJ0vawoALU/ChJhinPKs4QxnjeVcff8Ol7Eawh8tEnwX6cA8dNFyBmyDg7vbkh3rX 0MMzMirkQUIgK/nJ7ZH7bF34O2QKCfAk02yk8Ds0Pjs/zzTyBhYVmfRrEsHWbFHdY+8v ODog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711114518; x=1711719318; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yt8fmMq2uI75U4REa9Iz48QxXGz42nA7SAkZWB+B/Ig=; b=u4DEO7CNZRuAGnHTqTFfu92Otv4q3EDA8/e07DLM6JpD+3JH6RjwTpwK2N6DsjdOoQ yIGO/kagYAXlr3EhOS/nPtDODOHdgO+XUgmS6O7GAgSPV/78wNjLaMiQQfphU21lIeyd XvZ1HXV9IEt4V8TNy9TBHCeiM5l2WMSiPGfWCxhBA6/AMAojezeINn7Tk0uhDw++aarr fJ3m0lVOOrk11/cYFl5sH/OqXglyLwDlJjWxFYwqIHKBi45x73eT3smJ3yPEJU/thJ+c fTSYKbSFKan+HIYyM0HPI9sqkqrPmOrjmh+yGM3Hyt2iv+5tQkGmQBoannQRZvbp8m9U 8aTA== X-Forwarded-Encrypted: i=1; AJvYcCVCslblCuyr170MjiiUTK8OprzPCE0HSmIhDM+IZPPNxQU5S76TtHSeXWL4TWyQNGegW7DBSXloNO9QuvK4v8lCCDCRrrxSLg== X-Gm-Message-State: AOJu0Yy+WYkQI6FkBijHHRvLp7tporT3/RiaC+286RK8rcjuprxwQrv1 FoLNyuzyxgxIGBll0BrwqbDq7fe0jP7DFDBb3LiBx/IIEVAAV3Nj X-Google-Smtp-Source: AGHT+IGEc3DmyQK1kA8w+pvEougt1mQlaj6cSk79XHPMzto4g0mENSp3LdAZCZCuDr1ZVSYzxmGm4Q== X-Received: by 2002:a54:4605:0:b0:3c3:9e0e:ac9a with SMTP id p5-20020a544605000000b003c39e0eac9amr2061885oip.17.1711114518301; Fri, 22 Mar 2024 06:35:18 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id j19-20020a544813000000b003c385d0ce00sm278864oij.3.2024.03.22.06.35.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Mar 2024 06:35:17 -0700 (PDT) Message-ID: Date: Fri, 22 Mar 2024 07:35:16 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH] handle unwind tables that are embedded within unwinding code, [PR111731] Content-Language: en-US To: Thomas Neumann , "gcc-patches@gcc.gnu.org" Cc: Jakub Jelinek References: <2a4776b9-9271-bb3c-a626-d5ec22dae6f3@in.tum.de> <91045a34-a534-4436-bb06-cac32d797a36@in.tum.de> <87sfibqu1s.fsf@oldenburg.str.redhat.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/15/24 4:29 AM, Thomas Neumann wrote: > Original bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111731 > Given that this is a regression, is this okay for gcc 13 and mainline? > > The unwinding mechanism registers both the code range and the unwind > table itself within a b-tree lookup structure. That data structure > assumes that is consists of non-overlappping intervals. This > becomes a problem if the unwinding table is embedded within the > code itself, as now the intervals do overlap. > > To fix this problem we now keep the unwind tables in a separate > b-tree, which prevents the overlap. > > libgcc/ChangeLog: >     PR libgcc/111731 >     * unwind-dw2-fde.c: Split unwind ranges if they contain the >     unwind table. I'll go ahead and give the final OK here :-) Jeff