From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DE5E8385828E for ; Fri, 17 Feb 2023 20:00:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE5E8385828E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676664043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Dt3umgHrjK5/W3xzN8N0TQUQGkx1+jWAslL9gxSiFkg=; b=E25tp+oyoQgzhBr6XWigWEBTZf9mM9i8PSeHYmuJxzpHO7dGBI0fv6iz52rGRHODHpjHpu NUl/JH3nk/3p+D2kmayQ+S8gvwHqnduUzFWimyFZmJn7bmOfkHRnoHYsV0TFqWArA3MX/f uI9NzH2uANz31b18mqr4pIN//RECWHk= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-55-uzU8sPVuMvyBnCQKOaTtFA-1; Fri, 17 Feb 2023 15:00:42 -0500 X-MC-Unique: uzU8sPVuMvyBnCQKOaTtFA-1 Received: by mail-qk1-f199.google.com with SMTP id i8-20020a05620a150800b0073bb0d77745so1139632qkk.18 for ; Fri, 17 Feb 2023 12:00:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dt3umgHrjK5/W3xzN8N0TQUQGkx1+jWAslL9gxSiFkg=; b=QNSgsJrwSPTEeJHamwruTtz62AIjPzoMjSRVLC5kPK/4R5SKbTb3epUX0QCHXth4pJ xgejd4NPQ/6JFoznEKfXKYr7N0WpY/Jn9fxITDartnq4y2UBrGZBopVnfwVCsB+cJ2LU cF7iZkcsDNoQcl0XEEtYrpvQ3qEB+GZE22h8tgERz3xNrqNbwAH8RDjyi59YBo6wsWGH ALfYu2IJevnc/HJoJxSDux/mPq1sWi3n8Q2QoUqRwUIAQ0BahftGR34sZ+sJmPQeTJoV F6BmPMFwCArEhfG7FZRZnALllOJ8+MsBM2BfJd6829ZusUzp9GBdTQHZGJ2q6RjPGUNK H3/w== X-Gm-Message-State: AO0yUKXOi/kVpA2jyLhKRd53P7MhmFvDyklxWpg7TAk4fYwCMCDCtZKs YEzu4lL8pCsfoTiQNxGgF34jWFwRniEBQEeUzQays6dpt29jfgudl6Oh+D67amKNepj22aw/MOh fEoIsCvCp4aiG3mjvQGC8eUA= X-Received: by 2002:a05:6214:c24:b0:56c:1ff0:7647 with SMTP id a4-20020a0562140c2400b0056c1ff07647mr2565769qvd.49.1676664041499; Fri, 17 Feb 2023 12:00:41 -0800 (PST) X-Google-Smtp-Source: AK7set9HFa8ZYDKBaeoVLvJAaRDl3nNDiSxW/oEVyZUCRUeZyoqzmLEK8wkwbSmJGxZtWIRrs22i9g== X-Received: by 2002:a05:6214:c24:b0:56c:1ff0:7647 with SMTP id a4-20020a0562140c2400b0056c1ff07647mr2565731qvd.49.1676664041153; Fri, 17 Feb 2023 12:00:41 -0800 (PST) Received: from [192.168.1.130] (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id t65-20020ae9df44000000b0073b2f1c8329sm3855535qkf.28.2023.02.17.12.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 12:00:40 -0800 (PST) From: Patrick Palka X-Google-Original-From: Patrick Palka Date: Fri, 17 Feb 2023 15:00:39 -0500 (EST) To: Marek Polacek cc: Jason Merrill , GCC Patches Subject: Re: [PATCH] c++: ICE with redundant capture [PR108829] In-Reply-To: <20230217185847.33102-1-polacek@redhat.com> Message-ID: References: <20230217185847.33102-1-polacek@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 17 Feb 2023, Marek Polacek via Gcc-patches wrote: > Here we crash in is_capture_proxy: > > /* Location wrappers should be stripped or otherwise handled by the > caller before using this predicate. */ > gcc_checking_assert (!location_wrapper_p (decl)); > > so fixed as the comment suggests. We only crash with the redundant > capture: > > int abyPage = [=, abyPage] { ... } > > because prune_lambda_captures is only called when there was a default > capture, and with [=] only abyPage won't be in LAMBDA_EXPR_CAPTURE_LIST. It's weird that we even get this far in var_to_maybe_prune. Shouldn't LAMBDA_CAPTURE_EXPLICIT_P be true for abyPage? > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk/12? > > PR c++/108829 > > gcc/cp/ChangeLog: > > * lambda.cc (var_to_maybe_prune): Strip location wrappers before > checking for a capture proxy. > > gcc/testsuite/ChangeLog: > > * g++.dg/cpp0x/lambda/lambda-108829.C: New test. > --- > gcc/cp/lambda.cc | 1 + > gcc/testsuite/g++.dg/cpp0x/lambda/lambda-108829.C | 11 +++++++++++ > 2 files changed, 12 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/cpp0x/lambda/lambda-108829.C > > diff --git a/gcc/cp/lambda.cc b/gcc/cp/lambda.cc > index c752622816d..a12b9c183c2 100644 > --- a/gcc/cp/lambda.cc > +++ b/gcc/cp/lambda.cc > @@ -1700,6 +1700,7 @@ var_to_maybe_prune (tree cap) > return NULL_TREE; > > tree init = TREE_VALUE (cap); > + STRIP_ANY_LOCATION_WRAPPER (init); > if (is_normal_capture_proxy (init)) > init = DECL_CAPTURED_VARIABLE (init); > if (decl_constant_var_p (init)) > diff --git a/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-108829.C b/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-108829.C > new file mode 100644 > index 00000000000..e621a0d14d0 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-108829.C > @@ -0,0 +1,11 @@ > +// PR c++/108829 > +// { dg-do compile { target c++11 } } > + > +template > +void f(void) { > + constexpr int IDX_PAGE_SIZE = 4096; > + int abyPage = [=, abyPage] { return IDX_PAGE_SIZE; }(); // { dg-error "redundant" } > +} > +void h() { > + f<1>(); > +} > > base-commit: 6245441e124846d0c3551f312d2feef598fe251c > -- > 2.39.2 > >