public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Robin Dapp <rdapp@linux.ibm.com>
To: Jeff Law <jeffreyalaw@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [RFC] postreload cse'ing vector constants
Date: Thu, 8 Sep 2022 15:04:23 +0200	[thread overview]
Message-ID: <caf21e5f-966e-d8e7-a7b5-feda97b9d543@linux.ibm.com> (raw)
In-Reply-To: <5b687817-126e-d463-9d88-b3d7d2dad861@gmail.com>

> Which is this from the mail archives:
> 
> https://gcc.gnu.org/pipermail/gcc-patches/1998-June/000308.html
> 
> I would tend to agree that for equal cost that the constant would be 
> preferred since that should be better from a scheduling/dependency 
> standpoint.   So it seems to me we can drive this purely from a costing 
> standpoint.

I did bootstrapping and ran the testsuite on x86(-64), aarch64, Power9
and s390.  Everything looks good except two additional fails on x86
where code actually looks worse.

gcc.target/i386/keylocker-encodekey128.c

17c17,18
<       movaps  %xmm4, k2(%rip)
---
>       pxor    %xmm0, %xmm0
>       movaps  %xmm0, k2(%rip)

gcc.target/i386/keylocker-encodekey256.c:

19c19,20
<       movaps  %xmm4, k3(%rip)
---
>       pxor    %xmm0, %xmm0
>       movaps  %xmm0, k3(%rip)

Regards
 Robin

  reply	other threads:[~2022-09-08 13:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 14:40 Robin Dapp
2022-09-07 15:06 ` Jeff Law
2022-09-07 15:33   ` Robin Dapp
2022-09-07 15:49     ` Jeff Law
2022-09-08 13:04       ` Robin Dapp [this message]
2022-09-27 17:40         ` Robin Dapp
2022-09-27 19:39           ` H.J. Lu
2022-09-28 16:48             ` Robin Dapp
2022-11-03 12:38               ` Robin Dapp
2022-11-20 16:40                 ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=caf21e5f-966e-d8e7-a7b5-feda97b9d543@linux.ibm.com \
    --to=rdapp@linux.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jeffreyalaw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).