* [PATCH v2] RISC-V: Test memcpy inlined on riscv_v
@ 2023-10-04 22:55 Patrick O'Neill
2023-10-05 22:14 ` Jeff Law
0 siblings, 1 reply; 3+ messages in thread
From: Patrick O'Neill @ 2023-10-04 22:55 UTC (permalink / raw)
To: gcc-patches, JeffreyALaw
Cc: joern.rennecke, gnu-toolchain, Patrick O'Neill
Since r14-4358-g9464e72bcc9 riscv_v targets use vector instructions to
perform a memcpy. We no longer expect memcpy for riscv_v targets.
gcc/testsuite/ChangeLog:
* gcc.dg/pr90263.c: Skip riscv_v targets.
* gcc.target/riscv/rvv/base/pr90263.c: New test.
Signed-off-by: Patrick O'Neill <patrick@rivosinc.com>
Co-authored-by: Joern Rennecke <joern.rennecke@embecosm.com>
---
Changes from v1:
[PATCH] RISC-V: xfail gcc.dg/pr90263.c for riscv_v
- Skip test rather than xfailing for riscv_v.
- Add testcase to ensure memcpy is not emitted on riscv_v.
---
gcc/testsuite/gcc.dg/pr90263.c | 1 +
gcc/testsuite/gcc.target/riscv/rvv/base/pr90263.c | 7 +++++++
2 files changed, 8 insertions(+)
create mode 100644 gcc/testsuite/gcc.target/riscv/rvv/base/pr90263.c
diff --git a/gcc/testsuite/gcc.dg/pr90263.c b/gcc/testsuite/gcc.dg/pr90263.c
index 3222a5331c1..831e098783b 100644
--- a/gcc/testsuite/gcc.dg/pr90263.c
+++ b/gcc/testsuite/gcc.dg/pr90263.c
@@ -2,6 +2,7 @@
/* { dg-do compile } */
/* { dg-options "-O2" } */
/* { dg-require-effective-target glibc } */
+/* { dg-skip-if "riscv_v uses an inline memcpy routine" { riscv_v } }*/
int *f (int *p, int *q, long n)
{
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/pr90263.c b/gcc/testsuite/gcc.target/riscv/rvv/base/pr90263.c
new file mode 100644
index 00000000000..7308428e2c3
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/rvv/base/pr90263.c
@@ -0,0 +1,7 @@
+/* { dg-do compile } */
+/* { dg-options "-O2" } */
+/* { dg-require-effective-target glibc } */
+
+#include "../../../../gcc.dg/pr90263.c"
+
+/* { dg-final { scan-assembler-not "memcpy" { target { riscv_v } } } } */
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] RISC-V: Test memcpy inlined on riscv_v
2023-10-04 22:55 [PATCH v2] RISC-V: Test memcpy inlined on riscv_v Patrick O'Neill
@ 2023-10-05 22:14 ` Jeff Law
2023-10-05 22:25 ` [Committed] " Patrick O'Neill
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2023-10-05 22:14 UTC (permalink / raw)
To: Patrick O'Neill, gcc-patches; +Cc: joern.rennecke, gnu-toolchain
On 10/4/23 16:55, Patrick O'Neill wrote:
> Since r14-4358-g9464e72bcc9 riscv_v targets use vector instructions to
> perform a memcpy. We no longer expect memcpy for riscv_v targets.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/pr90263.c: Skip riscv_v targets.
> * gcc.target/riscv/rvv/base/pr90263.c: New test.
OK
jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Committed] RISC-V: Test memcpy inlined on riscv_v
2023-10-05 22:14 ` Jeff Law
@ 2023-10-05 22:25 ` Patrick O'Neill
0 siblings, 0 replies; 3+ messages in thread
From: Patrick O'Neill @ 2023-10-05 22:25 UTC (permalink / raw)
To: Jeff Law, gcc-patches; +Cc: joern.rennecke, gnu-toolchain
On 10/5/23 15:14, Jeff Law wrote:
>
>
> On 10/4/23 16:55, Patrick O'Neill wrote:
>> Since r14-4358-g9464e72bcc9 riscv_v targets use vector instructions to
>> perform a memcpy. We no longer expect memcpy for riscv_v targets.
>>
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.dg/pr90263.c: Skip riscv_v targets.
>> * gcc.target/riscv/rvv/base/pr90263.c: New test.
> OK
> jeff
Committed.
Patrick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-05 22:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-04 22:55 [PATCH v2] RISC-V: Test memcpy inlined on riscv_v Patrick O'Neill
2023-10-05 22:14 ` Jeff Law
2023-10-05 22:25 ` [Committed] " Patrick O'Neill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).