From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19725 invoked by alias); 26 Sep 2018 12:05:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19715 invoked by uid 89); 26 Sep 2018 12:05:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Zhao, zhao, Qing X-HELO: userp2130.oracle.com Received: from userp2130.oracle.com (HELO userp2130.oracle.com) (156.151.31.86) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Sep 2018 12:05:08 +0000 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w8QC3wch153095; Wed, 26 Sep 2018 12:05:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=AUBucc97yVM7NicVu9z7NJWVQ0Ly4a2MiacDQnCnh/0=; b=MiOorSOQ3eNCHiLOPhIDX/i49hpT9cC/K0Axy+6DCNQ8nP9ut/REmSBitdGB+8iYdUPR rxqNgBeb9EBmdMqEWN0dTyD0e8Kiwu/iyc+TTaKPq+is8+jp4POpIJU4vvkJv+1F4INe 3FHcde37tFZqUCnOr0pEke/5e+kSRJ5a/Ing8kwthPI2V5vsFOPmcT8QzRU8gQBJNyIP M6uAo+UYkQxitVlJuJClIdKbHjLQCR0PCq/pv9RsMIIXqZnOr1DU3sV/QYWsgGdz4Fx+ QQsZPvQRk1jMNMEE7TwYhehG+7vGOWiydH8/u5G7kz44a0PCPmISWQ/PMYn7UGiGu0mr 8A== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2mnd5tj0ey-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Sep 2018 12:05:06 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w8QC56qs002516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Sep 2018 12:05:06 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w8QC553j030197; Wed, 26 Sep 2018 12:05:06 GMT Received: from [192.168.1.4] (/79.27.215.207) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 26 Sep 2018 05:05:05 -0700 Subject: Re: [PATCH][Middle-end][Version 4]Add a new option to control inlining only on static functions To: Alexander Monakov , Qing Zhao Cc: gcc Patches , jeff Law , Richard Guenther , Jakub Jelinek , andrew Pinski , martin Sebor References: <7f314cc6-8cd3-a6f2-27b1-df4ef637542e@gmail.com> From: Paolo Carlini Message-ID: Date: Wed, 26 Sep 2018 12:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg01536.txt.bz2 Hi, On 9/26/18 1:12 PM, Alexander Monakov wrote: > On Fri, 21 Sep 2018, Qing Zhao wrote: >> +2018-09-20 Qing Zhao >> + >> + * cif-code.def (FUNCTION_EXTERN): New CIFCODE. >> + * common.opt (-finline-only-static): New option. >> + * doc/invoke.texi: Document -finline-only-static. >> + * ipa-inline.c (can_inline_edge_p): Control inlining based on >> + function's linkage. > Note, I am not a reviewer. > > In my opinion, there's a problem with the patch that it looks like an ad-hoc, > incomplete solution. It is not. Actually, I don't understand why we are raising this sort of issue now, after so many messages, like, for example Jeff's, which should have fully clarified the rationale. Paolo.