From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 9A04E3857C5C for ; Wed, 12 Jan 2022 15:58:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A04E3857C5C Received: by mail-pl1-x631.google.com with SMTP id t18so4627642plg.9 for ; Wed, 12 Jan 2022 07:58:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=D36fmSl8uOde9924CyCNz5BoNQoJx0M5//U6j8cJwuQ=; b=D07qEPaFe/E8eiaZMvRDwAGtTUeUcmDgHDS0l3zcXMzo0JD1c/k1v0Wrrq7v8RblJ1 Igcfh/Kh507bgK5pWMQapOQeEM//dsr/uV+7waq1uHrhQvvjtOeNf7U6JbkVsFQmZBN4 Bg9Uj+AhYPNZFW0+ZLg5H4tSCW1NsAlTCnUxJjxAbLBufD1yNAsOlZSqMimIhkIOVLE9 RXodQwlByQg5b8s52iuepLFo1rRGNbnbdncgaTwSaxvKotqvxbG9Nlqa668h78m46k50 bsICShsq02kcC7InT5Jr6WLvBdWqA9n2Hy4ZseRGVwSd+BJGGH10O3oKN1tVi6mD5CC5 uMHQ== X-Gm-Message-State: AOAM5333eXtDZP6Id/g8xPLn1NDvgfD3tgrtGtoU6x5RYs055GYUs583 SI1Eit7n0EMxyad9oZy48zE= X-Google-Smtp-Source: ABdhPJzApffGQLPbaVMI+ymRKWdahozehq0WoYkMK5Q3vuL7/v08GMYyF2IU2Fz380TsvjMvHRCV/A== X-Received: by 2002:a05:6a00:15c2:b0:4bb:3ab:83ca with SMTP id o2-20020a056a0015c200b004bb03ab83camr30333pfu.18.1642003096558; Wed, 12 Jan 2022 07:58:16 -0800 (PST) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id h13sm134751pgq.63.2022.01.12.07.58.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 07:58:16 -0800 (PST) Message-ID: Date: Wed, 12 Jan 2022 08:58:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] Fix redefined macro for epiphany. Content-Language: en-US To: Richard Biener , Joern Wolfgang Rennecke Cc: =?UTF-8?Q?Martin_Li=c5=a1ka?= , GCC Patches References: <5ce1236e-6e83-0660-ddf6-3bc295a252e5@suse.cz> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jan 2022 15:58:19 -0000 On 1/12/2022 7:56 AM, Richard Biener wrote: > On Wed, Jan 12, 2022 at 3:23 PM Jeff Law via Gcc-patches > wrote: >> >> >> On 1/12/2022 2:47 AM, Martin Liška wrote: >>> The following warning is emitted gazillion times. >>> >>> Fixes: >>> >>> In file included from ./tm.h:23, >>> from gcc/genconfig.c:25: >>> gcc/config/elfos.h:209: warning: "READONLY_DATA_SECTION_ASM_OP" redefined >>> 209 | #define READONLY_DATA_SECTION_ASM_OP "\t.section\t.rodata" >>> | >>> In file included from ./tm.h:21, >>> from gcc/genconfig.c:25: >>> gcc/config/epiphany/epiphany.h:671: note: this is the location of the >>> previous definition >>> 671 | #define READONLY_DATA_SECTION_ASM_OP "\t.section .rodata" >>> >>> Ready to be installed? >>> Thanks, >>> Martin >>> >>> gcc/ChangeLog: >>> >>> * config/elfos.h (READONLY_DATA_SECTION_ASM_OP): Define only if >>> not defined. >> Please do. >> >> However, I think we should deprecate the epiphany. It's been broken for >> ~2 years randomly failing in reload. I tried to fix it once and quickly >> gave up. It currently ignores all testing failures in my tester as it's >> been horribly unstable. > Joern is still listed as maintainer so let's CC him before doing > anything. That said, > if it builds it's good enough for GCC 12 - we can discuss any target > deprecations > during stage1 (or deprecate those that don't even build right now, > though I'm not > aware of any). cr16 still uses cc0.  It's marked as deprecated in gcc-12 and assuming it doesn't get fixed, removal in gcc-13. m32c should be deprecated.  While it'll build libgcc, it'll fault (due to register allocation/reloading issues) building newlib or anything relatively complex.  This has been the case for at least 2 years. epiphany will build newlib consistently, so I guess keeping it another release is OK to see if Joern wants to step up and fix its reload issues. Jeff