public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] RISC-V:add a more appropriate type attribute
@ 2023-08-23 12:28 Zhangjin Liao
  2023-08-23 14:04 ` Jeff Law
  0 siblings, 1 reply; 2+ messages in thread
From: Zhangjin Liao @ 2023-08-23 12:28 UTC (permalink / raw)
  To: gcc-patches; +Cc: kito.cheng, Zhangjin Liao

Due to the more accurate type attribute added to the clz, ctz, and pcnt operations
in https://github.com/gcc-mirror/gcc/commit/07e2576d6f3 the same type attribute
should be used here.

gcc/ChangeLog:

        * config/riscv/bitmanip.md:add a more appropriate type attribute
---
 gcc/config/riscv/bitmanip.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/riscv/bitmanip.md b/gcc/config/riscv/bitmanip.md
index 0c99152ffc8..7b55528ee49 100644
--- a/gcc/config/riscv/bitmanip.md
+++ b/gcc/config/riscv/bitmanip.md
@@ -262,7 +262,7 @@
           (match_operand:DI 2 "const_int_operand")))]
   "TARGET_64BIT && TARGET_ZBB && ((INTVAL (operands[2]) & 0x3f) == 0x3f)"
   "<bitmanip_insn>w\t%0,%1"
-  [(set_attr "type" "bitmanip")
+  [(set_attr "type" "<bitmanip_insn>")
    (set_attr "mode" "SI")])
 
 (define_insn "*<bitmanip_optab>di2"
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] RISC-V:add a more appropriate type attribute
  2023-08-23 12:28 [PATCH] RISC-V:add a more appropriate type attribute Zhangjin Liao
@ 2023-08-23 14:04 ` Jeff Law
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2023-08-23 14:04 UTC (permalink / raw)
  To: Zhangjin Liao, gcc-patches; +Cc: kito.cheng



On 8/23/23 06:28, Zhangjin Liao wrote:
> Due to the more accurate type attribute added to the clz, ctz, and pcnt operations
> inhttps://github.com/gcc-mirror/gcc/commit/07e2576d6f3  the same type attribute
> should be used here.
> 
> gcc/ChangeLog:
> 
>          * config/riscv/bitmanip.md:add a more appropriate type attribute
Thanks.  I improved the ChangeLog slightly and pushed this to the trunk.

Jeff

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-23 14:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-23 12:28 [PATCH] RISC-V:add a more appropriate type attribute Zhangjin Liao
2023-08-23 14:04 ` Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).