From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28074 invoked by alias); 16 May 2008 15:42:12 -0000 Received: (qmail 28043 invoked by uid 22791); 16 May 2008 15:42:12 -0000 X-Spam-Check-By: sourceware.org Received: from hu-out-0506.google.com (HELO hu-out-0506.google.com) (72.14.214.231) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 16 May 2008 15:41:54 +0000 Received: by hu-out-0506.google.com with SMTP id 34so780828hud.6 for ; Fri, 16 May 2008 08:41:50 -0700 (PDT) Received: by 10.210.40.10 with SMTP id n10mr3791470ebn.131.1210952509902; Fri, 16 May 2008 08:41:49 -0700 (PDT) Received: by 10.210.137.18 with HTTP; Fri, 16 May 2008 08:41:49 -0700 (PDT) Message-ID: Date: Fri, 16 May 2008 16:42:00 -0000 From: "Sebastian Pop" To: janis187@us.ibm.com Subject: Re: PATCH 01: Testsuite: compare outputs of a testcase compiled and run with 2 flags Cc: "Jagasia, Harsha" , gcc-patches@gcc.gnu.org In-Reply-To: <1210891451.6325.9.camel@janis-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1209682504.6264.5.camel@janis-laptop> <1210891451.6325.9.camel@janis-laptop> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-05/txt/msg00986.txt.bz2 On Thu, May 15, 2008 at 5:44 PM, Janis Johnson wrote: > I cleaned up the use of torture options so now it should be easier to > add a suite that combines a specified list of torture options with > another specified list; see gcc/testsuite/objc/execute/execute.exp > for an example. All of the tests in a directory will be run with all > of those options. Does that do what you need? > No, this torture infrastructure is complementary to the changes proposed by Harsha. With the torture infrastructure one should encode the check for the correctness of the results in the testcase itself. This is difficult: we want a simpler way to do this checking, avoiding to write the check explicitely in the testcase. We want to avoid writing testcases like gcc/testsuite/gcc.dg/vect/vect-25.c where the check is explicitely in the testcase: /* check results: */ for (i = 0; i < N; i++) { if (ib[i] != k) abort (); } The patch proposed by Harsha allows to just write the testcase and compare outputs, avoiding the need of a check of the computation with abort calls. -- Sebastian Pop AMD - GNU Tools