--enable-link-serialization=1 doesn't work

--enable-link-serialization=1 doesn't work

[Matthias Klose]

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]

The attached patch makes the link targets a little bit more verbose. Ok to commit?

It shows that --enable-link-serialization=1 doesn't work:

$ grep ^Linking ../log
Linking gnat1 |==--                  | 9%
Linking cc1 |--                    | 0%
Linking cc1 |==                    | 9%
Linking gnat1 |====                  | 18%
Linking brig1 |====--                | 18%
Linking brig1 |======                | 27%
Linking cc1plus |======--              | 27%
Linking cc1plus |========              | 36%
Linking d21 |========--            | 36%
Linking d21 |==========            | 45%
Linking f951 |==========--          | 45%
Linking f951 |============          | 54%
Linking go1 |============--        | 54%
Linking go1 |==============        | 63%
Linking lto1 |==============--      | 63%
Linking lto1 |================      | 72%
Linking lto-dump |================--    | 72%
Linking lto-dump |==================    | 81%
Linking cc1obj |==================--  | 81%
Linking cc1obj |====================  | 90%
Linking cc1objplus |====================--| 90%
Linking cc1objplus |======================| 100%

At least the gnat1 link is started before the cc1 link finishes.

Matthias


[-- Attachment #2: linking-verbose.diff --]
[-- Type: text/x-patch, Size: 495 bytes --]

--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -1793,7 +1793,7 @@ DO_LINK_SERIALIZATION = @DO_LINK_SERIALIZATION@
 ifeq ($(DO_LINK_SERIALIZATION),)
 LINK_PROGRESS = :
 else
-LINK_PROGRESS = msg="Linking |"; cnt=0; if test "$(2)" = start; then \
+LINK_PROGRESS = msg="Linking $@ |"; cnt=0; if test "$(2)" = start; then \
   idx=0; cnt2=$(DO_LINK_SERIALIZATION); \
   while test $$cnt2 -le $(1); do msg="$${msg}=="; cnt2=`expr $$cnt2 + 1`; idx=`expr $$idx + 1`; done; \
   cnt=$$idx; \

Re: --enable-link-serialization=1 doesn't work

[Matthias Klose]

On 1/9/21 7:52 PM, Matthias Klose wrote:
> The attached patch makes the link targets a little bit more verbose. Ok to commit?

approved by Jakub on IRC, checked in.

> It shows that --enable-link-serialization=1 doesn't work:
> 
> $ grep ^Linking ../log
> Linking gnat1 |==--                  | 9%
> Linking cc1 |--                    | 0%
> Linking cc1 |==                    | 9%
> Linking gnat1 |====                  | 18%
> Linking brig1 |====--                | 18%
> Linking brig1 |======                | 27%
> Linking cc1plus |======--              | 27%
> Linking cc1plus |========              | 36%
> Linking d21 |========--            | 36%
> Linking d21 |==========            | 45%
> Linking f951 |==========--          | 45%
> Linking f951 |============          | 54%
> Linking go1 |============--        | 54%
> Linking go1 |==============        | 63%
> Linking lto1 |==============--      | 63%
> Linking lto1 |================      | 72%
> Linking lto-dump |================--    | 72%
> Linking lto-dump |==================    | 81%
> Linking cc1obj |==================--  | 81%
> Linking cc1obj |====================  | 90%
> Linking cc1objplus |====================--| 90%
> Linking cc1objplus |======================| 100%
> 
> At least the gnat1 link is started before the cc1 link finishes.

Jakub has a patch pending for that. Thanks for debugging.

Matthias