public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: "Robin Dapp" <rdapp.gcc@gmail.com>, 钟居哲 <juzhe.zhong@rivai.ai>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
	palmer <palmer@dabbelt.com>, "kito.cheng" <kito.cheng@gmail.com>
Subject: Re: [PATCH] RISC-V: Add initial pipeline description for an out-of-order core.
Date: Wed, 23 Aug 2023 17:21:37 -0600	[thread overview]
Message-ID: <cc38820b-ae87-c198-8ff7-b258862231a0@gmail.com> (raw)
In-Reply-To: <bd5fa95a-3b90-4e3c-e911-bc80bf6a932d@gmail.com>



On 8/23/23 08:56, Robin Dapp wrote:
>> Does this patch fix these 2 following PR:
>> 108271 – Missed RVV cost model (gnu.org) <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108271>
>> 108412 – RISC-V: Negative optimization of GCSE && LOOP INVARIANTS (gnu.org) <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108412>
>>
>> If yes, plz append these 2 cases into testsuite and indicate those 2 PR are fixed.
>> So that we can close them.
> 
> The second one is fixed on my local branch, the first not yet because there
> is more to it still.  The second one is more due to pressure-aware scheduling
> and I'm going to add it to the commit as well as the PR to the commit once this
> is verified.
Basically there's a little conditional in IRA which basically says don't 
rematerialize constants at their use points if register pressure 
sensitive scheduling has been enabled.    So turning on -fsched-pressure 
helps, it's a bit of a cop-out, but probably good enough for now.

Jeff

  reply	other threads:[~2023-08-23 23:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23 13:48 Robin Dapp
2023-08-23 14:29 ` 钟居哲
2023-08-23 14:56   ` Robin Dapp
2023-08-23 23:21     ` Jeff Law [this message]
2023-08-28  2:25     ` juzhe.zhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc38820b-ae87-c198-8ff7-b258862231a0@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=juzhe.zhong@rivai.ai \
    --cc=kito.cheng@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=rdapp.gcc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).