From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 9709C3858D32 for ; Wed, 19 Jul 2023 06:03:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9709C3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-4fdd31bf179so1383176e87.2 for ; Tue, 18 Jul 2023 23:03:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689746615; x=1692338615; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qQVfqZP/2dhWfrt6V6Zle8uTKjdII5KjEZIytvsE+kY=; b=WRrJbQO8dIWdB7fllp0nh7H3G4wD8fz5xiOS+MkVJ96K6cTGKD60ncPgz1UCT6Dy4h RM1JaUuTvqNlAJye04jE4BmEBXWyzQ4MXrGydgQI5VDFiMnkH7YEySnjF90F1DimOncf WYFyGHeQc+YHKgs6mowEkZrpuq9U/yuPQMXVghHvafnO7Fg87PPPqiWF6InEKISKVvgL w/F+LNDLGdDCdlPNW6GfGyHpBw7H32R+zynfW1nqcRw1nqLoA5EU3HrgtdGl4h3OcpLp dABbgKfdnm3k919yz/bbkHDhOdB/QgWb5ZnRf+ToxtO8u5UVQIR0a+pDtYxMaWk04EeK cITg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689746615; x=1692338615; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qQVfqZP/2dhWfrt6V6Zle8uTKjdII5KjEZIytvsE+kY=; b=W8aGfkDOl4+961Y9Gn5zdjDI17aEQs+kB8SxBRNxEVuNIGLyvDlG+iQzCQDreYUjeN Ekwv4xRUWvSJcOio4UCW6mxMdhy6OqdRGNA90a8gzAu4BQz0KDhms5DBkk8Mr4SSfTDA 9/ZXDevAM2ZdDXDns+LlVhITO9MmEERpGXLCBUrcGkPOO6j+4z6E76ZL8VA1+xAREjDa aci/9FXhvLafJ/5WHIYoe4PxDtZA6Rfl5k338VPE0Kad3vX3coIoK9hP23A1puUfi/dT ZCBjkYuaVXQlyBapXq1GJVdToR5+e9foHZolfUqzsK+XWijVuss2x6t27YMznz+Rtuir v45Q== X-Gm-Message-State: ABy/qLZmzsuecIqoujV3nHQ2pbug0JmPyKN7QXF85KbpgTLYumt1K0tW zYhMVdAM1nPQ0lw+Y+Esuwc= X-Google-Smtp-Source: APBJJlE/rKMpjBfBOpaYlBMLt08hCvsL+KG7cgQPmob6feDcObtPBH649D+bylfctz7hn1485ImuIg== X-Received: by 2002:a2e:9947:0:b0:2b5:8bb9:4dd6 with SMTP id r7-20020a2e9947000000b002b58bb94dd6mr1069092ljj.12.1689746614759; Tue, 18 Jul 2023 23:03:34 -0700 (PDT) Received: from [192.168.1.24] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id s21-20020a170906355500b00992b71d8f19sm1829342eja.133.2023.07.18.23.03.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 23:03:34 -0700 (PDT) Message-ID: Date: Wed, 19 Jul 2023 08:03:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: rdapp.gcc@gmail.com, juzhe.zhong@rivai.ai, kito.cheng@gmail.com, palmer@rivosinc.com, jeffreyalaw@gmail.com Subject: Re: [PATCH] RISC-V: Fix testcase failed when default -mcmodel=medany To: Lehua Ding , gcc-patches@gcc.gnu.org References: <20230719031258.25644-1-lehua.ding@rivai.ai> Content-Language: en-US From: Robin Dapp In-Reply-To: <20230719031258.25644-1-lehua.ding@rivai.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Lehua, > I think you are rigth, I would like to remove the `-mcmodel=medany` option and > relax assert from `__riscv_save/restore_4` to `__riscv_save/restore_(3|4)` to let > this testcase not brittle on any -mcmodel. Then I'm also going to add another > testcase (I dont known how to run -march=rv32imafc and -march=rv64imafc on > the same testcase) that uses -march=rv64imafc. Thanks, ideally we'd have a common include that contains the code but I don't think we need to stress on that now. At a later point, we'd ideally have no rv32/rv64 ever in the options (apart from specific bugs) and just run the test suite for both so only one file would be needed. But we don't have that yet, so LGTM. Regards Robin