From: Jeff Law <law@redhat.com>
To: Dragan Mladjenovic <dmladjenovic@wavecomp.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Jakub Jelinek <jakub@redhat.com>,
Matthew Fortune <mfortune@gmail.com>,
Joseph Myers <joseph@codesourcery.com>,
"Maciej W . Rozycki" <macro@linux-mips.org>,
Faraz Shahbazker <fshahbazker@wavecomp.com>
Subject: Re: [PATCH 1/2][MIPS] Emit .note.GNU-stack for soft-float linux targets.
Date: Fri, 09 Aug 2019 21:36:00 -0000 [thread overview]
Message-ID: <cc770cb9-f4b5-ff22-00a1-6d7f0a2d61ba@redhat.com> (raw)
In-Reply-To: <1565002044-5330-1-git-send-email-dmladjenovic@wavecomp.com>
On 8/5/19 4:47 AM, Dragan Mladjenovic wrote:
> From: "Dragan Mladjenovic" <dmladjenovic@wavecomp.com>
>
> gcc/ChangeLog:
>
> 2019-08-05 Dragan Mladjenovic <dmladjenovic@wavecomp.com>
>
> * config/mips/linux.h (NEED_INDICATE_EXEC_STACK): Define to
> TARGET_SOFT_FLOAT.
> * config/mips/mips.c (TARGET_ASM_FILE_END): Define to ...
> (mips_asm_file_end): New function. Delegate to
> file_end_indicate_exec_stack if NEED_INDICATE_EXEC_STACK is true.
> * config/mips/mips.h (NEED_INDICATE_EXEC_STACK): Define to 0.
>
> libgcc/ChangeLog:
>
> 2019-08-05 Dragan Mladjenovic <dmladjenovic@wavecomp.com>
>
> * config/mips/gnustack.h: New file.
> * config/mips/crti.S: Include gnustack.h.
> * config/mips/crtn.S: Likewise.
> * config/mips/mips16.S: Likewise.
> * config/mips/vr4120-div.S: Likewise.
Seems reasonable. What testing has been done for this patch? I don't
doubt it works for the MIPS linux targets, I'm more interested in making
sure it doesn't do the wrong thing for the embedded mips targets.
Do you have write access to the repository?
jeff
next prev parent reply other threads:[~2019-08-09 21:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 10:43 [PATCH 0/2] [MIPS] Emit .note.GNU-stack for " Dragan Mladjenovic
2019-08-05 10:48 ` [PATCH 1/2][MIPS] Emit .note.GNU-stack for soft-float " Dragan Mladjenovic
2019-08-09 21:36 ` Jeff Law [this message]
2019-08-12 16:34 ` [EXTERNAL]Re: " Dragan Mladjenovic
2019-08-20 7:26 ` Jeff Law
2019-08-05 10:49 ` [PATCH 2/2][MIPS][RFC] Emit .note.GNU-stack for hard-float " Dragan Mladjenovic
2019-08-09 21:38 ` Jeff Law
2019-08-09 23:13 ` Joseph Myers
2019-11-01 10:32 ` Dragan Mladjenovic
2019-11-07 17:05 ` Dragan Mladjenovic
2019-11-27 18:59 ` [PING] " Dragan Mladjenovic
2019-12-07 18:33 ` Jeff Law
2020-01-23 11:14 ` Dragan Mladjenovic
2020-01-23 15:22 ` Jeff Law
2020-01-29 12:20 ` Tobias Burnus
2020-01-30 0:14 ` [EXTERNAL]Re: " Dragan Mladjenovic
2020-01-30 9:20 ` Dragan Mladjenovic
2019-08-09 22:03 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc770cb9-f4b5-ff22-00a1-6d7f0a2d61ba@redhat.com \
--to=law@redhat.com \
--cc=dmladjenovic@wavecomp.com \
--cc=fshahbazker@wavecomp.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=macro@linux-mips.org \
--cc=mfortune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).