From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 75F713858415 for ; Sat, 5 Feb 2022 17:46:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 75F713858415 Received: by mail-pl1-x62d.google.com with SMTP id c3so7887849pls.5 for ; Sat, 05 Feb 2022 09:46:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2P1EuWVNZ0fVX7suPMxOps7PnCY0hEtNZjLpDwN7nFU=; b=w2QWH/h9gyHdpT3iVWFRRUeL3S8EPKhSll2z558BTjc80vPUCeJXr+v2TjuffezPfS BtzG1DzA+kD6Gh01vhnHBLhyd/F90ObmSNZ1pakQT6qkATK3v8Ou1AI34ADeuW0/iqQ+ cuO3ZsI01sFUJ3DfC7S3/iqp1+rromMO+Engiteai7/K+CPbcyBqQ5nj7TIk/DRCCeAp +kL33vwEUtVhLT8YVWtFlFazNVHTf4zkrbaT6oWNH25DAuJInh5AOHaERSPpPrnMJCsN GXQ2tYYX8dZLlC/E4mLq8MRHwOCzQKuytTL4hVrm4hVkZ/O0wGcJ5k4UsO+UlzFrYA8F XXIw== X-Gm-Message-State: AOAM531C+FTzj06+Cc2kgt3z4Bc9+h9wWZJvEL4/MF+rRQ7B096Q9/xO 7vku14xCF4yJse6EGg92FyY= X-Google-Smtp-Source: ABdhPJyiXXlyWayUx6j97vl6GO2Id37pqz9PJ74wrK2kPCArHQMV4v+SdGCVQYA2gl6YLVBdGJewxg== X-Received: by 2002:a17:903:18b:: with SMTP id z11mr8905125plg.94.1644083205477; Sat, 05 Feb 2022 09:46:45 -0800 (PST) Received: from [172.31.0.204] (c-73-63-24-84.hsd1.ut.comcast.net. [73.63.24.84]) by smtp.gmail.com with ESMTPSA id y18sm4429163pgh.67.2022.02.05.09.46.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Feb 2022 09:46:44 -0800 (PST) Message-ID: Date: Sat, 5 Feb 2022 10:46:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: ifcvt: Fix PR104153 and PR104198 Content-Language: en-US To: Robin Dapp , GCC Patches Cc: Richard Sandiford , ro@CeBiTec.Uni-Bielefeld.DE References: <35755ec2-0612-0d94-c2d5-d2527c384c3b@linux.ibm.com> <93eb6fa1-d1d3-baf4-f790-e99abcd8e0c5@gmail.com> <0264ca40-a10a-36d2-f15a-fb6763fd022c@linux.ibm.com> From: Jeff Law In-Reply-To: <0264ca40-a10a-36d2-f15a-fb6763fd022c@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Feb 2022 17:46:47 -0000 On 2/3/2022 1:00 AM, Robin Dapp wrote: >> Do you need to adjust anything now that this is emitting into TEMP >> rather than TARGET? > The idea now is to emit to TEMP in the first pass and check if we read > the initial condition. Overwriting the condition (and of course reading > it in every sequence) is the reason temporaries were needed in the first > place. > > In the second pass (always done now) we use TEMP for those > SETs/sequences before the last one that read the condition and TARGET > for those after it. Ideally it's TARGET for all of them which would > result in the best costing situation. OK.  Thanks for clarifying. > > The whole logic was/is really a bit convoluted for what we want to > achieve but I'd argue it's not much worse than before ;) Yea.  And it's not that far off from things we do elsewhere -- we generate some sequence then start grubbing around inside for things of interest. OK for the trunk. Any thoughts on the ARC failure which is triggered by your patch and still unresolved? https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104154 Jeff