From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 273113858D32 for ; Tue, 5 Sep 2023 06:22:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 273113858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1bf6ea270b2so9250485ad.0 for ; Mon, 04 Sep 2023 23:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693894952; x=1694499752; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=igcoHCSTQgnP3dqR0AzSbHyVm1B8Cu8/qak1b2Jk2fE=; b=QH3H2qJF+1mZcHt3kP54b7jAM0J001Jca4PkLgz7nKAHOho/ZaI5myId5iuku13hwA CUoRP0Xjua4Q6GdJcApFr1/5IDKOIMtQzGeemo9D0StSxq6SnGtnDG091HkZpUE7ChXT peUXHB86UCngksYWvXRvsgxkWOBoKALvHoisiJiBD7ysm5H7+196iy06aM/4fKjs5RuI O9pSRhjtEJsEglStuzpqWgSVFpl1z53zsJiRUc2pazNSUjQdnMBiM2wDVtuCDq0pPiU8 amDrfiMV3CzTUYngYGBA5X/FG79VJFjXp4tGiImOrvPQcm5PkyLJLokhq2h2utaaOZ86 pAKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693894952; x=1694499752; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=igcoHCSTQgnP3dqR0AzSbHyVm1B8Cu8/qak1b2Jk2fE=; b=k7RV/w8XsCok1fVuR6AVl9SnzeUpvut9djj9h+dASszVgLkTCUjG/GsnW9zICYRteb 268dMwBdoQC92Ui16CNZu60YKqSAxa8Fwz4NkUL3SgJrM1Ge8uuz7kHFU5+qBIQ8cfrL e/sm2h93q5rV6vl0L1eqkb4Av0dheBn26MTD/rnBev9BLFAyVVdQ9pfxJHD2cXrmuhhg aFpqdMttha0X5t10Zx9OhWj9YdApjbh+HL8rgT13Swz1CDc7RY13Ww8ElvBaSwaUV4wr 16ZWulPdu36lEPkQ32Mpv6G9w2Bg2a51BxgIOmlEfsYDcugeDO3smECHcpd+PoUV7ZjW 2QUA== X-Gm-Message-State: AOJu0YyUPQdvyB3OArfQNWDTxHphHf5zUKwpkxRGhA2LuNHMMHU94ZZs M+BJGAbUbrAPFOhfdBmElHk= X-Google-Smtp-Source: AGHT+IG9clZ9hq6NU5Hmh9hs7lm9JNOGjJ8jPAnJnd9josExWrbJHiIj+AIhRDHPJeG8INzH0s1uuQ== X-Received: by 2002:a17:903:24f:b0:1bf:1320:9743 with SMTP id j15-20020a170903024f00b001bf13209743mr11017799plh.45.1693894952057; Mon, 04 Sep 2023 23:22:32 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id i6-20020a170902eb4600b001bf846dd2d0sm8490218pli.13.2023.09.04.23.22.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Sep 2023 23:22:31 -0700 (PDT) Message-ID: Date: Tue, 5 Sep 2023 00:22:24 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] riscv: xtheadcondmov: Don't run tests with -Oz Content-Language: en-US To: Christoph Muellner , gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich References: <20230901102006.511665-1-christoph.muellner@vrull.eu> From: Jeff Law In-Reply-To: <20230901102006.511665-1-christoph.muellner@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_MANYTO,KAM_SHORT,LIKELY_SPAM_BODY,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/1/23 04:20, Christoph Muellner wrote: > From: Christoph Müllner > > Recently, these xtheadcondmov tests regressed with -Oz: > * FAIL: gcc.target/riscv/xtheadcondmov-mveqz-imm-eqz.c > * FAIL: gcc.target/riscv/xtheadcondmov-mveqz-imm-not.c > * FAIL: gcc.target/riscv/xtheadcondmov-mvnez-imm-cond.c > * FAIL: gcc.target/riscv/xtheadcondmov-mvnez-imm-nez.c > > As -Oz stands for "Optimize aggressively for size rather than speed.", > we need to inspect the generated code, which looks like this: > > -Oz > 0000000000000000 : > 0: e199 bnez a1,6 <.L2> > 2: 40100513 li a0,1025 > 0000000000000006 <.L2>: > 6: 8082 ret > > -O2: > 0000000000000000 : > 0: 40100793 li a5,1025 > 4: 40b7950b th.mveqz a0,a5,a1 > 8: 8082 ret > > As the generated code with -Oz consumes less size, there is nothing > wrong in the code generation. Instead, let's not run the xtheadcondmov > tests with -Oz. > > Signed-off-by: Christoph Müllner > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/xtheadcondmov-mveqz-imm-eqz.c: Disable for -Oz. > * gcc.target/riscv/xtheadcondmov-mveqz-imm-not.c: Likewise. > * gcc.target/riscv/xtheadcondmov-mveqz-reg-eqz.c: Likewise. > * gcc.target/riscv/xtheadcondmov-mveqz-reg-not.c: Likewise. > * gcc.target/riscv/xtheadcondmov-mvnez-imm-cond.c: Likewise. > * gcc.target/riscv/xtheadcondmov-mvnez-imm-nez.c: Likewise. > * gcc.target/riscv/xtheadcondmov-mvnez-reg-cond.c: Likewise. > * gcc.target/riscv/xtheadcondmov-mvnez-reg-nez.c: Likewise. OK jeff