From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id B792C385841A for ; Mon, 13 Sep 2021 13:33:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B792C385841A Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 18DBY6MK001712; Mon, 13 Sep 2021 09:33:24 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3b23h9xp0y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Sep 2021 09:33:23 -0400 Received: from m0098416.ppops.net (m0098416.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 18DBcqcI013000; Mon, 13 Sep 2021 09:33:23 -0400 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0b-001b2d01.pphosted.com with ESMTP id 3b23h9xp0h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Sep 2021 09:33:23 -0400 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 18DDVlMQ017013; Mon, 13 Sep 2021 13:33:22 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma01wdc.us.ibm.com with ESMTP id 3b0m38rv2x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Sep 2021 13:33:22 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 18DDXMZQ38142330 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Sep 2021 13:33:22 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 399F5AC059; Mon, 13 Sep 2021 13:33:22 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB7E0AC062; Mon, 13 Sep 2021 13:33:21 +0000 (GMT) Received: from Bills-MacBook-Pro.local (unknown [9.211.104.79]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 13 Sep 2021 13:33:21 +0000 (GMT) Reply-To: wschmidt@linux.ibm.com Subject: Re: [PATCHv5 00/18] Replace the Power target-specific builtin machinery To: gcc-patches@gcc.gnu.org Cc: dje.gcc@gmail.com, segher@kernel.crashing.org References: From: Bill Schmidt Message-ID: Date: Mon, 13 Sep 2021 08:33:21 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Language: en-GB X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: yqzJx3M5w7XHiHxMN-cvFFRcm0nNqPF1 X-Proofpoint-GUID: 5k2fca-6HBbFPi9CM0-uzQwXAF9Ff32m X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 mlxscore=0 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109130048 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, HTML_MESSAGE, KAM_SHORT, NICE_REPLY_A, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Sep 2021 13:33:28 -0000 Ping. Message-Id: Thanks! Bill On 9/1/21 11:13 AM, Bill Schmidt via Gcc-patches wrote: > Hi! > > Original patch series here: > https://gcc.gnu.org/pipermail/gcc-patches/2021-April/568840.html > > V2 patch series here: > https://gcc.gnu.org/pipermail/gcc-patches/2021-June/572231.html > > V3 patch series here: > https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573020.html > > V4 patch series here: > https://gcc.gnu.org/pipermail/gcc-patches/2021-July/576284.html > > Thanks for all the reviews so far! We're into the home stretch. I needed > to rebase this series again in order to pick up some changes from upstream. > > Patch 01/18 is a reposting of V4 patch 19/34, addressing some of the > comments. Full refactoring of this stuff will be done later, after this > patch series can burn in a little. This wasn't yet formally approved. > > Patch 02/18 is new, and is a minor bug fix. > > Patches 03/18 through 17/18 correspond to V4 patches 20/34 through 34/34. > These were adjusted for upstream changes, and I did some formatting > cleanups. I also provided better descriptions for some of the patches. > > Patch 18/18 is new, and improves the parser to handle escape-newline > input. With that in place, it cleans up all the long lines in the > input files. > > Bootstrapped and tested on powerpc64le-linux-gnu (P10) and > powerpc64-linux-gnu (32- and 64-bit, P8). There are no regressions for > little endian. There are a small handful of big-endian regressions that > have crept in, and I'll post patches for those after I work through them. > But no need to hold up reviews on the rest of this in the meantime. > > Thanks again for all of the helpful reviews so far! > > Bill > > > Bill Schmidt (18): > rs6000: Handle overloads during program parsing > rs6000: Move __builtin_mffsl to the [always] stanza > rs6000: Handle gimple folding of target built-ins > rs6000: Handle some recent MMA builtin changes > rs6000: Support for vectorizing built-in functions > rs6000: Builtin expansion, part 1 > rs6000: Builtin expansion, part 2 > rs6000: Builtin expansion, part 3 > rs6000: Builtin expansion, part 4 > rs6000: Builtin expansion, part 5 > rs6000: Builtin expansion, part 6 > rs6000: Update rs6000_builtin_decl > rs6000: Miscellaneous uses of rs6000_builtins_decl_x > rs6000: Debug support > rs6000: Update altivec.h for automated interfaces > rs6000: Test case adjustments > rs6000: Enable the new builtin support > rs6000: Add escape-newline support for builtins files > > gcc/config/rs6000/altivec.h | 519 +-- > gcc/config/rs6000/rs6000-builtin-new.def | 442 ++- > gcc/config/rs6000/rs6000-c.c | 1088 ++++++ > gcc/config/rs6000/rs6000-call.c | 3132 +++++++++++++++-- > gcc/config/rs6000/rs6000-gen-builtins.c | 312 +- > gcc/config/rs6000/rs6000.c | 272 +- > .../powerpc/bfp/scalar-extract-exp-2.c | 2 +- > .../powerpc/bfp/scalar-extract-sig-2.c | 2 +- > .../powerpc/bfp/scalar-insert-exp-2.c | 2 +- > .../powerpc/bfp/scalar-insert-exp-5.c | 2 +- > .../powerpc/bfp/scalar-insert-exp-8.c | 2 +- > .../powerpc/bfp/scalar-test-neg-2.c | 2 +- > .../powerpc/bfp/scalar-test-neg-3.c | 2 +- > .../powerpc/bfp/scalar-test-neg-5.c | 2 +- > .../gcc.target/powerpc/byte-in-set-2.c | 2 +- > gcc/testsuite/gcc.target/powerpc/cmpb-2.c | 2 +- > gcc/testsuite/gcc.target/powerpc/cmpb32-2.c | 2 +- > .../gcc.target/powerpc/crypto-builtin-2.c | 14 +- > .../powerpc/fold-vec-splat-floatdouble.c | 4 +- > .../powerpc/fold-vec-splat-longlong.c | 10 +- > .../powerpc/fold-vec-splat-misc-invalid.c | 8 +- > .../gcc.target/powerpc/int_128bit-runnable.c | 6 +- > .../gcc.target/powerpc/p8vector-builtin-8.c | 1 + > gcc/testsuite/gcc.target/powerpc/pr80315-1.c | 2 +- > gcc/testsuite/gcc.target/powerpc/pr80315-2.c | 2 +- > gcc/testsuite/gcc.target/powerpc/pr80315-3.c | 2 +- > gcc/testsuite/gcc.target/powerpc/pr80315-4.c | 2 +- > gcc/testsuite/gcc.target/powerpc/pr88100.c | 12 +- > .../gcc.target/powerpc/pragma_misc9.c | 2 +- > .../gcc.target/powerpc/pragma_power8.c | 2 + > .../gcc.target/powerpc/pragma_power9.c | 3 + > .../powerpc/test_fpscr_drn_builtin_error.c | 4 +- > .../powerpc/test_fpscr_rn_builtin_error.c | 12 +- > gcc/testsuite/gcc.target/powerpc/test_mffsl.c | 3 +- > gcc/testsuite/gcc.target/powerpc/vec-gnb-2.c | 2 +- > .../gcc.target/powerpc/vsu/vec-all-nez-7.c | 2 +- > .../gcc.target/powerpc/vsu/vec-any-eqz-7.c | 2 +- > .../gcc.target/powerpc/vsu/vec-cmpnez-7.c | 2 +- > .../gcc.target/powerpc/vsu/vec-cntlz-lsbb-2.c | 2 +- > .../gcc.target/powerpc/vsu/vec-cnttz-lsbb-2.c | 2 +- > .../gcc.target/powerpc/vsu/vec-xl-len-13.c | 2 +- > .../gcc.target/powerpc/vsu/vec-xst-len-12.c | 2 +- > 42 files changed, 4803 insertions(+), 1089 deletions(-) >