From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id C67183857C66 for ; Fri, 1 Oct 2021 11:03:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C67183857C66 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-49-P4HJzacQPgGgtxbbS5jRBA-1; Fri, 01 Oct 2021 07:03:14 -0400 X-MC-Unique: P4HJzacQPgGgtxbbS5jRBA-1 Received: by mail-wr1-f69.google.com with SMTP id x2-20020a5d54c2000000b0015dfd2b4e34so2702185wrv.6 for ; Fri, 01 Oct 2021 04:03:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=b0yUCwcyxNLruvF1jowI8s+TUbdmvb0Bwl0SYBiXBew=; b=cszIhsOpk6CZMOncPa9muQrvc04ghVWZ/Zd9r7vKZValyjwmfI89VQZgwLqd92kH7q oYEoHrIflBUoiaflluVHpEP+w8VixSAoi3Isfo7BP1ijcrEE7G0UtBYCKW5weBFgLJwk jMqI7FXhgzc/sCHsOVya4HuNbGN+VazG9Fc6MwTJYQwFR+WPgaCngcZCBVyVegAQE12E EbNIbnbeeym6aDx6ZlfC1i2EhlwP0LI31+pVkJJ2cMGwQfXr5301ydLT/acFTVfZOSdl j0QpFyKampWNoPkC6PmEOg5j/yjjJmoGbVcF04/Atg2hdj0Mhe0dm3lA8Fxb7ubHl47b Orfg== X-Gm-Message-State: AOAM532f7s0EXKQS2UHbh7XQMLAvgJgqFsy8Cw2iVgHduresypxmaHy8 sq68Cgua1a1aDCTz1Qi0xQGm9F6eXWk/XDjpKPKmxIIa0XneykAYQJRbnSFbd+DPfpeOSSRJhrd 8ypEVAVZYqJUlLhuJDeiPeyjmUJtyAFwtTRYeJL62DAa8lR+/332OMdzNQdGPXO53ig== X-Received: by 2002:a1c:3541:: with SMTP id c62mr3799933wma.68.1633086192913; Fri, 01 Oct 2021 04:03:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw81jhmDmbLpaNq4G1zPnz5fQ/FCTI4emLngjiyaZh/0LdSih9pfvJUOASeCi+6ifDApHO1/Q== X-Received: by 2002:a1c:3541:: with SMTP id c62mr3799898wma.68.1633086192687; Fri, 01 Oct 2021 04:03:12 -0700 (PDT) Received: from abulafia.quesejoda.com ([139.47.33.227]) by smtp.gmail.com with ESMTPSA id r27sm5379324wrr.70.2021.10.01.04.03.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Oct 2021 04:03:12 -0700 (PDT) Subject: Re: [PATCH] Replace VRP threader with a hybrid forward threader. To: Gerald Pfeifer , Jeff Law Cc: gcc-patches@gcc.gnu.org References: <20210924154653.1108992-1-aldyh@redhat.com> <6dccbae9-eab1-d1bc-551e-97188483e18@pfeifer.com> From: Aldy Hernandez Message-ID: Date: Fri, 1 Oct 2021 13:03:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <6dccbae9-eab1-d1bc-551e-97188483e18@pfeifer.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Oct 2021 11:03:17 -0000 On 10/1/21 12:55 PM, Gerald Pfeifer wrote: > On Fri, 24 Sep 2021, Aldy Hernandez via Gcc-patches wrote: >> This patch implements the new hybrid forward threader and replaces the >> embedded VRP threader with it. > > I'm not sure this is the right of the patches to follow-up around this, > but between Jeff writing > > "Note we've got massive failures in the tester starting sometime > yesterday and I suspect all the threader work. So I'm going to slow > down on reviews of that code as we stabilize stuff." Most of this has been resolved. Some of it was some out-of-tree patches Jeff had on his tree, and some other stuff were tests that needed adjustments on other architectures. Both have been fixed. That being said, the visium & bfin embedded targets have some failures I've yet to look at. On a similar topic, disallowing threading paths that cross loops has brought some problems that I'm looking at. > > in another thread and you > > "There seems to be a memory consumption issue on 32 bit hosts after > the hybrid threader patchset. I'm having a hard time reproducing..." This has been fixed by: commit 64dd46dbc682fbbc03a74e0298f7ac471c5e80f2 Author: Aldy Hernandez Date: Thu Sep 30 02:19:36 2021 +0200 Plug memory leak in hybrid_threader. Tested on x86-64 Linux. Aldy